From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.4 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,FSL_HELO_FAKE, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1BBA9C4320E for ; Fri, 6 Aug 2021 15:05:15 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 01DEE6101C for ; Fri, 6 Aug 2021 15:05:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S243632AbhHFPF2 (ORCPT ); Fri, 6 Aug 2021 11:05:28 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38974 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S243262AbhHFPFY (ORCPT ); Fri, 6 Aug 2021 11:05:24 -0400 Received: from mail-pj1-x102d.google.com (mail-pj1-x102d.google.com [IPv6:2607:f8b0:4864:20::102d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 750BFC0613CF for ; Fri, 6 Aug 2021 08:05:08 -0700 (PDT) Received: by mail-pj1-x102d.google.com with SMTP id m10-20020a17090a34cab0290176b52c60ddso18160914pjf.4 for ; Fri, 06 Aug 2021 08:05:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=5eZrYc9DJUkTA1iAssqHy9p2WRfYMo/VyY/QvADARYY=; b=scjfM2KAwvMr0J0xp0SYBnTDo3ApPj7hK5atstwmV/OGXWjEglaJS/poY5hkj1kzKz VYsVd9nNWgtisBaQNXTSQrwQjwPSG0BREg5oF/i/LHX4ghsTljrBb00qTaEUqAvv7m4Q wr90ti6/x0aFWJ6Ggh1coi9tpGKp4jaCPZLdTLI1zRNSCX9dfftJ4JwCCKMQ1gwO0XIA 0VALv7wyOrCj8xtB6rtAWhBfCxcuqS1nzuuGZvekZAEVWkUK/tUQiTFiE4NN/cyGBn9C TsbWFDeNNnmAHfa49asadyj9F+VDC9m2sfk5dS1IKBtTr8lr7rahWrh3HWKmO+6Z+IvK mNDA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=5eZrYc9DJUkTA1iAssqHy9p2WRfYMo/VyY/QvADARYY=; b=XYGF9Pt3TVYjNRzU6l+a+kOhPall1tO1U9G1/XZKOvgDxj3aq71u6aGcb5Zl6aF87H ByOSOEeyUdx4gVy6m3/hlkLGUm8XoLZdRknG0Ry+oD0IaPgge+R7zYjpoIvz/xsfLgIJ YGoNKnW451ncB9hiE8O6Ko3fMLxfN9cmaVsfoI1gBAynp/lEuQuiES4KfLT9QxoH0k7Z kUXLtdG7iCPhSImSw1MLAjVfaECNnk9P/b7NvzfwHzXis5r4jIhd7Qmq9s3Qb4ezywBo qScE73QYSqtLSysKCFUxfORUSkbCwK4Gsaml8yzoOJuLCwBTvXr5AqdznMBLIiVchxzf /oZA== X-Gm-Message-State: AOAM533Kr3BRQsRdZZhth1JAFqeaUoSHH59NY7ISzvj2Xtv8SzwVWe2g uEfsvMvtqHfeiR/kHtRGNk4nGA== X-Google-Smtp-Source: ABdhPJywOhz85rUeq9sfYzgRc3T33E50AG7rhHUhlIZkEJYslkgHGgdx50E1SFw0y9fZ0eki4xw4sw== X-Received: by 2002:a63:ef45:: with SMTP id c5mr122429pgk.78.1628262307730; Fri, 06 Aug 2021 08:05:07 -0700 (PDT) Received: from google.com (157.214.185.35.bc.googleusercontent.com. [35.185.214.157]) by smtp.gmail.com with ESMTPSA id dw15sm9422535pjb.42.2021.08.06.08.05.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 06 Aug 2021 08:05:07 -0700 (PDT) Date: Fri, 6 Aug 2021 15:05:03 +0000 From: Sean Christopherson To: Zeng Guang Cc: Paolo Bonzini , Vitaly Kuznetsov , Wanpeng Li , Jim Mattson , Joerg Roedel , "kvm@vger.kernel.org" , Dave Hansen , "Luck, Tony" , Kan Liang , Thomas Gleixner , Ingo Molnar , Borislav Petkov , "H. Peter Anvin" , Kim Phillips , Jarkko Sakkinen , Jethro Beekman , "Huang, Kai" , "x86@kernel.org" , "linux-kernel@vger.kernel.org" , "Hu, Robert" , "Gao, Chao" , Robert Hoo Subject: Re: [PATCH v3 2/6] KVM: VMX: Extend BUILD_CONTROLS_SHADOW macro to support 64-bit variation Message-ID: References: <20210805151317.19054-1-guang.zeng@intel.com> <20210805151317.19054-3-guang.zeng@intel.com> <86b1a46b-10b7-a495-8793-26374ebc9b90@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <86b1a46b-10b7-a495-8793-26374ebc9b90@intel.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Aug 06, 2021, Zeng Guang wrote: > On 8/6/2021 6:32 AM, Sean Christopherson wrote: > > On Thu, Aug 05, 2021, Zeng Guang wrote: > > > +BUILD_CONTROLS_SHADOW(tertiary_exec, TERTIARY_VM_EXEC_CONTROL, 64) > > This fails to compile because all the TERTIARY collateral is in a later patch. > > > Alternative to derive relative TERTIARY collateral and prepare them in this > patch. Ok for that ? It'd be better to move this line to the next patch, that way all the TERTIARY stuff is in a single patch and isolated from controls shadow enhancement.