From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.3 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,FSL_HELO_FAKE, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, UPPERCASE_50_75,USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6BD6AC4320A for ; Fri, 6 Aug 2021 16:31:05 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4B71C60F22 for ; Fri, 6 Aug 2021 16:31:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232346AbhHFQbT (ORCPT ); Fri, 6 Aug 2021 12:31:19 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58312 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231682AbhHFQbS (ORCPT ); Fri, 6 Aug 2021 12:31:18 -0400 Received: from mail-pj1-x102b.google.com (mail-pj1-x102b.google.com [IPv6:2607:f8b0:4864:20::102b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9F8A8C061798 for ; Fri, 6 Aug 2021 09:31:01 -0700 (PDT) Received: by mail-pj1-x102b.google.com with SMTP id m10-20020a17090a34cab0290176b52c60ddso18570032pjf.4 for ; Fri, 06 Aug 2021 09:31:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=84hY5jDAppUM2aQUi/DIf2atf7Ty47vhaafi4V0naGE=; b=KdvF1wfl42VsDxUShMXwSpC4rhv0zdr+gVFsmfAwaFUkHd6dylwqkqcDY3njHKRETd s06qFvZCIekJr6w7GgTCTZ5h3Nfx/uu8wHKfqkQVBQBxnf6ae3oa3Ger6bdeMGLDKOGF ISgPrQxVjOBP14Nw86opXLNvQ06SvJgbBOrjvjrfIMMJtj+Ik7ao8PnpFwtayUFflXuB dIa+tOyZxCong/Tga8xXnXn+86OS5lNlCqgZsHkO2Xq2zV/834HUHXabeViOwLBP1Low j2qk1swKizFSzRbW3RhpAWMOjPlYMj76B0oxTS7z4j3uI3Q5M2PE21ePHQcPDe0yMo9n NrbA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=84hY5jDAppUM2aQUi/DIf2atf7Ty47vhaafi4V0naGE=; b=cBIaEY/r/3v3G78JP3gyJkgLOHfo8ON4xf/8gY7kF+Wg0CuSkmIt+SwFORqk+TBl9V /r0X0fTZRhxV0TrObNC1dlZKQ2bykUoUunUPZK4520+cSu2BX2pNK0AYoymq3lztArSO zz7gOAPG+Ff72am+soj+OJiGBplcazxCallJ1fP7amoj2TxFQDo1iUOx3HTgnxwptEoZ /v62AtjDVNZgVvw8UbR2YLpVe7yu+zHlAHDzrgVjS2HXkLI3sDS6csIzgWIeIdlqkbU3 K8BFqFl7yRz04hGc8E7BTTjzfzBQrACOIiREUfoOOJ8lqsyUyA1yoF61HQbgoSx18BPM 1n3Q== X-Gm-Message-State: AOAM532ZAPyCnywW8HQDwc2PHpctjvb0XGmgCviY+7fNAIbFxB+KEvdl v1sgTkAoROF+A9486L/e/5rPHg== X-Google-Smtp-Source: ABdhPJyCtsGwyPBwANptW14Gj0TNbhDEtRkyTTY5E91Himc0xAxv1pOEj0Ovr0v9/IsQL37B65Pt3w== X-Received: by 2002:a17:90a:4894:: with SMTP id b20mr11434237pjh.13.1628267460943; Fri, 06 Aug 2021 09:31:00 -0700 (PDT) Received: from google.com (157.214.185.35.bc.googleusercontent.com. [35.185.214.157]) by smtp.gmail.com with ESMTPSA id iq4sm6145622pjb.28.2021.08.06.09.31.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 06 Aug 2021 09:31:00 -0700 (PDT) Date: Fri, 6 Aug 2021 16:30:56 +0000 From: Sean Christopherson To: Paolo Bonzini Cc: Zeng Guang , Vitaly Kuznetsov , Wanpeng Li , Jim Mattson , Joerg Roedel , kvm@vger.kernel.org, Dave Hansen , Tony Luck , Kan Liang , Thomas Gleixner , Ingo Molnar , Borislav Petkov , "H. Peter Anvin" , Kim Phillips , Jarkko Sakkinen , Jethro Beekman , Kai Huang , x86@kernel.org, linux-kernel@vger.kernel.org, Robert Hu , Gao Chao , Robert Hoo Subject: Re: [PATCH v3 2/6] KVM: VMX: Extend BUILD_CONTROLS_SHADOW macro to support 64-bit variation Message-ID: References: <20210805151317.19054-1-guang.zeng@intel.com> <20210805151317.19054-3-guang.zeng@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Aug 06, 2021, Paolo Bonzini wrote: > On 06/08/21 00:32, Sean Christopherson wrote: > > > -BUILD_CONTROLS_SHADOW(vm_entry, VM_ENTRY_CONTROLS) > > > -BUILD_CONTROLS_SHADOW(vm_exit, VM_EXIT_CONTROLS) > > > -BUILD_CONTROLS_SHADOW(pin, PIN_BASED_VM_EXEC_CONTROL) > > > -BUILD_CONTROLS_SHADOW(exec, CPU_BASED_VM_EXEC_CONTROL) > > > -BUILD_CONTROLS_SHADOW(secondary_exec, SECONDARY_VM_EXEC_CONTROL) > > > +BUILD_CONTROLS_SHADOW(vm_entry, VM_ENTRY_CONTROLS, 32) > > > +BUILD_CONTROLS_SHADOW(vm_exit, VM_EXIT_CONTROLS, 32) > > > +BUILD_CONTROLS_SHADOW(pin, PIN_BASED_VM_EXEC_CONTROL, 32) > > > +BUILD_CONTROLS_SHADOW(exec, CPU_BASED_VM_EXEC_CONTROL, 32) > > > +BUILD_CONTROLS_SHADOW(secondary_exec, SECONDARY_VM_EXEC_CONTROL, 32) > > > +BUILD_CONTROLS_SHADOW(tertiary_exec, TERTIARY_VM_EXEC_CONTROL, 64) > > > > This fails to compile because all the TERTIARY collateral is in a later patch. > > > > I think I'd also prefer hiding the 32/64 param via more macros, e.g. > > > > #define __BUILD_CONTROLS_SHADOW(lname, uname, bits) \ > > No, please don't. :) Also because the 64 bit version is used only once. LOL, fine. I'm beginning to think you have a filter for "macros" that sounds off alarms and flashing lights ;-)