From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Joseph Qi <joseph.qi@linux.alibaba.com>
Cc: Andrii Nakryiko <andrii.nakryiko@gmail.com>, dwarves@vger.kernel.org
Subject: Re: [PATCH] pahole: correct libbpf git url
Date: Fri, 6 Aug 2021 15:42:13 -0300 [thread overview]
Message-ID: <YQ2Chd/j62NCY2NX@kernel.org> (raw)
In-Reply-To: <1628244763-1113-1-git-send-email-joseph.qi@linux.alibaba.com>
Em Fri, Aug 06, 2021 at 06:12:43PM +0800, Joseph Qi escreveu:
> Otherwise it will encounter the following error:
> fatal: unable to access 'https://github.com/libbpf/libbpf/': Encountered end of file
> fatal: clone of 'https://github.com/libbpf/libbpf' into submodule path '/home/workspace/pahole/lib/bpf' failed
>
> Also update README to add step 'make'.
You forgot to add Andrii, the author of the patch you're fixing, to the
CC list, please do it next time.
- Arnaldo
> Fixes: 21507cd3e97b ("pahole: add libbpf as submodule under lib/bpf")
> Signed-off-by: Joseph Qi <joseph.qi@linux.alibaba.com>
> ---
> .gitmodules | 2 +-
> README | 3 ++-
> 2 files changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/.gitmodules b/.gitmodules
> index 6be99dc..8be5eb6 100644
> --- a/.gitmodules
> +++ b/.gitmodules
> @@ -1,3 +1,3 @@
> [submodule "lib/bpf"]
> path = lib/bpf
> - url = https://github.com/libbpf/libbpf
> + url = https://github.com/libbpf/libbpf.git
> diff --git a/README b/README
> index c9f1737..07f5876 100644
> --- a/README
> +++ b/README
> @@ -4,7 +4,8 @@ Build instructions:
> 2. mkdir build
> 3. cd build
> 4. cmake -D__LIB=lib ..
> -5. make install
> +5. make
> +6. make install
>
> cmake Options:
> -DBUILD_SHARED_LIBS
> --
> 1.8.3.1
>
--
- Arnaldo
next prev parent reply other threads:[~2021-08-06 18:42 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-06 10:12 [PATCH] pahole: correct libbpf git url Joseph Qi
2021-08-06 18:42 ` Arnaldo Carvalho de Melo [this message]
2021-08-06 18:45 ` Arnaldo Carvalho de Melo
2021-08-06 21:11 ` Andrii Nakryiko
2021-08-08 11:37 ` Joseph Qi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YQ2Chd/j62NCY2NX@kernel.org \
--to=acme@kernel.org \
--cc=andrii.nakryiko@gmail.com \
--cc=dwarves@vger.kernel.org \
--cc=joseph.qi@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.