From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 775D9C432BE for ; Sat, 7 Aug 2021 15:49:45 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 575C860FD8 for ; Sat, 7 Aug 2021 15:49:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232518AbhHGPuB (ORCPT ); Sat, 7 Aug 2021 11:50:01 -0400 Received: from vps0.lunn.ch ([185.16.172.187]:38282 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229828AbhHGPtv (ORCPT ); Sat, 7 Aug 2021 11:49:51 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Disposition:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:From:Sender:Reply-To:Subject: Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Content-Disposition:In-Reply-To:References; bh=hMRkLC9sX1iRCwMgCksqyJpH2Qs6Prl5IMtksM3Msb0=; b=a+Kv9/L2NlWb5RJtcVgT0AdPYB esCRXzwCdwjzZzonljtfHsyoWjPcKPZJC7jzTG1rSqUuPCpHoBjBZmz4AUU2ewPQbCYqLoAbut1E7 FnoEUcjLYQS5f5kAk4b6r2XCngmb1ayYX9e3xm2JrTAvzcGneoXOT9DZGCaHhXpvJ6z0=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1mCOZg-00GVS5-Op; Sat, 07 Aug 2021 17:49:24 +0200 Date: Sat, 7 Aug 2021 17:49:24 +0200 From: Andrew Lunn To: Saravana Kannan Cc: Heiner Kallweit , Russell King , "David S. Miller" , Jakub Kicinski , Marc Zyngier , Neil Armstrong , Kevin Hilman , kernel-team@android.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v1 3/3] net: mdio-mux: Handle -EPROBE_DEFER correctly Message-ID: References: <20210804214333.927985-1-saravanak@google.com> <20210804214333.927985-4-saravanak@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210804214333.927985-4-saravanak@google.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Aug 04, 2021 at 02:43:32PM -0700, Saravana Kannan wrote: > When registering mdiobus children, if we get an -EPROBE_DEFER, we shouldn't > ignore it and continue registering the rest of the mdiobus children. This > would permanently prevent the deferring child mdiobus from working instead > of reattempting it in the future. So, if a child mdiobus needs to be > reattempted in the future, defer the entire mdio-mux initialization. > > This fixes the issue where PHYs sitting under the mdio-mux aren't > initialized correctly if the PHY's interrupt controller is not yet ready > when the mdio-mux is being probed. Additional context in the link below. > > Link: https://lore.kernel.org/lkml/CAGETcx95kHrv8wA-O+-JtfH7H9biJEGJtijuPVN0V5dUKUAB3A@mail.gmail.com/#t > Signed-off-by: Saravana Kannan Reviewed-by: Andrew Lunn Andrew