All of lore.kernel.org
 help / color / mirror / Atom feed
From: Luis Chamberlain <mcgrof@kernel.org>
To: Bruno Goncalves <bgoncalv@redhat.com>
Cc: Rasmus Villemoes <linux@rasmusvillemoes.dk>,
	Alexander Egorenkov <egorenar@linux.ibm.com>,
	akpm@linux-foundation.org, bp@alien8.de, corbet@lwn.net,
	gregkh@linuxfoundation.org, jeyu@kernel.org,
	linux-kernel@vger.kernel.org, ndesaulniers@google.com,
	torvalds@linux-foundation.org, Dave Young <dyoung@redhat.com>
Subject: Re: [PATCH v3 1/2] init/initramfs.c: do unpacking asynchronously
Date: Tue, 27 Jul 2021 06:54:28 -0700	[thread overview]
Message-ID: <YQAQFMDMk09wS6Qv@bombadil.infradead.org> (raw)
In-Reply-To: <CA+QYu4pDGHj--z6yUrkhFs7oW-LUrY23i+-vKJwLPWaCO=z4vA@mail.gmail.com>

On Tue, Jul 27, 2021 at 09:31:54AM +0200, Bruno Goncalves wrote:
> On Mon, Jul 26, 2021 at 1:46 PM Rasmus Villemoes
> <linux@rasmusvillemoes.dk> wrote:
> >
> > On 24/07/2021 09.46, Alexander Egorenkov wrote:
> > > Hello,
> > >
> > > since e7cb072eb988 ("init/initramfs.c: do unpacking asynchronously"), we
> > > started seeing the following problem on s390 arch regularly:
> > >
> > > [    5.039734] wait_for_initramfs() called before rootfs_initcalls

So some context here, which might help.

The initramfs_cookie is initialized until a a rootfs_initcall() is
called, in this case populate_rootfs(). The code is small, so might
as well include it:

static int __init populate_rootfs(void)
{
	initramfs_cookie = async_schedule_domain(do_populate_rootfs, NULL,
						 &initramfs_domain);
	if (!initramfs_async)
		wait_for_initramfs();
	return 0;
}                                                                               
rootfs_initcall(populate_rootfs);

The warning you see comes from a situation where a wait_for_initramfs()
gets called but we haven't yet initialized initramfs_cookie.  There are
only a few calls for wait_for_initramfs() in the kernel, and the only
thing I can think of is that somehow s390 may rely on a usermode helper
early on, but not every time.

What umh calls does s390 issue?

> Unfortunately, we haven't been able to find the root cause, but since
> June 23rd we haven't hit this panic...
> 
> Btw, this panic we were hitting only when testing kernels from "scsi"
> and "block" trees.

Do you use drdb maybe?

  Luis

  reply	other threads:[~2021-07-27 13:54 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-13 21:25 [PATCH v3 0/2] background initramfs unpacking, and CONFIG_MODPROBE_PATH Rasmus Villemoes
2021-03-13 21:25 ` [PATCH v3 1/2] init/initramfs.c: do unpacking asynchronously Rasmus Villemoes
2021-03-15 20:21   ` Luis Chamberlain
2021-03-15 21:33   ` Andrew Morton
2021-03-15 21:59     ` Rasmus Villemoes
2021-07-24  7:46   ` Alexander Egorenkov
2021-07-26 11:46     ` Rasmus Villemoes
2021-07-27  7:31       ` Bruno Goncalves
2021-07-27 13:54         ` Luis Chamberlain [this message]
2021-07-27 14:12           ` Bruno Goncalves
2021-07-27 14:21             ` Luis Chamberlain
2021-07-27 14:27               ` Bruno Goncalves
2021-07-27 14:42                 ` Luis Chamberlain
2021-07-27 14:48                   ` Bruno Goncalves
2021-07-28 10:44                   ` Alexander Egorenkov
2021-07-28 10:38           ` Alexander Egorenkov
2021-07-28 10:36       ` Alexander Egorenkov
2021-07-28 11:49         ` Rasmus Villemoes
2021-03-13 21:25 ` [PATCH v3 2/2] modules: add CONFIG_MODPROBE_PATH Rasmus Villemoes
2021-03-15 20:06   ` Luis Chamberlain
2021-03-15 20:23 ` [PATCH v3 0/2] background initramfs unpacking, and CONFIG_MODPROBE_PATH Luis Chamberlain

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YQAQFMDMk09wS6Qv@bombadil.infradead.org \
    --to=mcgrof@kernel.org \
    --cc=akpm@linux-foundation.org \
    --cc=bgoncalv@redhat.com \
    --cc=bp@alien8.de \
    --cc=corbet@lwn.net \
    --cc=dyoung@redhat.com \
    --cc=egorenar@linux.ibm.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=jeyu@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@rasmusvillemoes.dk \
    --cc=ndesaulniers@google.com \
    --cc=torvalds@linux-foundation.org \
    --subject='Re: [PATCH v3 1/2] init/initramfs.c: do unpacking asynchronously' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.