All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sam Ravnborg <sam@ravnborg.org>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 0/5] video: fbdev: ssd1307fb: Optimizations and improvements
Date: Tue, 27 Jul 2021 17:26:35 +0200	[thread overview]
Message-ID: <YQAlq0/vmutrXCzi@ravnborg.org> (raw)
In-Reply-To: <20210727134730.3765898-1-geert@linux-m68k.org>

Hi Geert,
On Tue, Jul 27, 2021 at 03:47:25PM +0200, Geert Uytterhoeven wrote:
> 	Hi all,
> 
> This patch series optimizes console operations on ssd1307fb, after the
> customary fixes and cleanups.
> 
> Currently, each screen update triggers an I2C transfer of all screen
> data, up to 1 KiB of data for a 128x64 display, which takes at least 20
> ms in Fast mode.  While many displays are smaller, and thus require less
> data to be transferred, 20 ms is still an optimistic value, as the
> actual data transfer may be much slower, especially on bitbanged I2C
> drivers.  After this series, the amount of data transfer is reduced, as
> fillrect, copyarea, and imageblit only update the rectangle that
> changed.
> 
> Changes compared to v1[1]:
>   - Add Acked-by,
>   - Use two separate helpers instead of a single combined helper,
>   - Reorder operands in DIV_ROUND_UP() to improve readability.
> 
> This has been tested on an Adafruit FeatherWing OLED with an SSD1306
> controller and a 128x32 OLED, connected to an OrangeCrab ECP5 FPGA board
> running a 64 MHz VexRiscv RISC-V softcore, where it reduced the CPU
> usage for blinking the cursor from more than 70% to ca. 10%.
> 
> Thanks for applying!
Thanks for the respin - patches are now applied to drm-misc-next.

	Sam

      parent reply	other threads:[~2021-07-27 15:26 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-27 13:47 [PATCH v2 0/5] video: fbdev: ssd1307fb: Optimizations and improvements Geert Uytterhoeven
2021-07-27 13:47 ` Geert Uytterhoeven
2021-07-27 13:47 ` [PATCH v2 1/5] video: fbdev: ssd1307fb: Propagate errors via ssd1307fb_update_display() Geert Uytterhoeven
2021-07-27 13:47   ` Geert Uytterhoeven
2021-07-27 13:47 ` [PATCH v2 2/5] video: fbdev: ssd1307fb: Simplify ssd1307fb_update_display() Geert Uytterhoeven
2021-07-27 13:47   ` Geert Uytterhoeven
2021-07-27 13:47 ` [PATCH v2 3/5] video: fbdev: ssd1307fb: Extract ssd1307fb_set_{col,page}_range() Geert Uytterhoeven
2021-07-27 13:47   ` [PATCH v2 3/5] video: fbdev: ssd1307fb: Extract ssd1307fb_set_{col, page}_range() Geert Uytterhoeven
2021-07-27 13:47 ` [PATCH v2 4/5] video: fbdev: ssd1307fb: Optimize screen updates Geert Uytterhoeven
2021-07-27 13:47   ` Geert Uytterhoeven
2021-07-27 13:47 ` [PATCH v2 5/5] video: fbdev: ssd1307fb: Cache address ranges Geert Uytterhoeven
2021-07-27 13:47   ` Geert Uytterhoeven
2021-07-27 15:26 ` Sam Ravnborg [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YQAlq0/vmutrXCzi@ravnborg.org \
    --to=sam@ravnborg.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=geert@linux-m68k.org \
    --cc=linux-fbdev@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.