From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 99D27C432BE for ; Tue, 27 Jul 2021 15:56:42 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7CBD961B5F for ; Tue, 27 Jul 2021 15:56:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237154AbhG0P4l (ORCPT ); Tue, 27 Jul 2021 11:56:41 -0400 Received: from mail.kernel.org ([198.145.29.99]:54194 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229720AbhG0P4k (ORCPT ); Tue, 27 Jul 2021 11:56:40 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 8E3906136F; Tue, 27 Jul 2021 15:56:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1627401400; bh=4tb1WeA1yxMZbiqCRvE/QSWrfbsh5i+dQ9i2gAEILbA=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=uLTikFf1s8jckkQ2jsLde76FX/lAhqEB5GL+47frEwZmQBkooo9JqNigpm2TohWjL RL6Nn70+M025tATN1sPHZ+fjh56ajMTAxx0OdCuMIqJ3R3VQmFMmpBNbeNbysioCC1 hV2mUtd5IYm6p5pTtWu+wu+1VTLAGfMWTa94loDc= Date: Tue, 27 Jul 2021 17:56:38 +0200 From: Greg KH To: Masahiro Yamada Cc: linux-kbuild@vger.kernel.org, Wan Jiabing , Kees Cook , linux-kernel@vger.kernel.org, linux-hardening@vger.kernel.org, Andrew Morton Subject: Re: [PATCH] scripts: make some scripts executable Message-ID: References: <20210727153924.79473-1-masahiroy@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210727153924.79473-1-masahiroy@kernel.org> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jul 28, 2021 at 12:39:24AM +0900, Masahiro Yamada wrote: > Set the x bit to some scripts to make them directly executable. > > Especially, scripts/checkdeclares.pl is not hooked by anyone. > It should be executable since it is tedious to type > 'perl scripts/checkdeclares.pl'. > > The original patch [1] set the x bit properly, but it was lost when > it was merged as commit 21917bded72c ("scripts: a new script for > checking duplicate struct declaration"). > > [1] https://lore.kernel.org/lkml/20210401110943.1010796-1-wanjiabing@vivo.com/ > > Signed-off-by: Masahiro Yamada > --- > > scripts/checkdeclares.pl | 0 > scripts/gcc-plugins/gen-random-seed.sh | 0 > scripts/syscallnr.sh | 0 > scripts/xen-hypercalls.sh | 0 > 4 files changed, 0 insertions(+), 0 deletions(-) > mode change 100644 => 100755 scripts/checkdeclares.pl > mode change 100644 => 100755 scripts/gcc-plugins/gen-random-seed.sh > mode change 100644 => 100755 scripts/syscallnr.sh > mode change 100644 => 100755 scripts/xen-hypercalls.sh Please no, as other tools (i.e. patch), can not set mode bits, and some people still rely on patch in places. If these need to be called by other parts of the build, we should execute them properly, not rely on the mode settings. thanks, greg k-h