From: Liam Beguin <lvb@xiphos.com>
To: Stephen Boyd <sboyd@kernel.org>,
Michael Turquette <mturquette@baylibre.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-clk@vger.kernel.org" <linux-clk@vger.kernel.org>,
kernel test robot <lkp@intel.com>,
"liambeguin@gmail.com" <liambeguin@gmail.com>
Subject: RE: [PATCH 1/2] clk: lmk04832: Depend on SPI
Date: Tue, 29 Jun 2021 15:01:17 +0000 [thread overview]
Message-ID: <YQBPR0101MB1811EF89914E845264FA4DE8D8029@YQBPR0101MB1811.CANPRD01.PROD.OUTLOOK.COM> (raw)
In-Reply-To: <20210629060751.3119453-1-sboyd@kernel.org>
> -----Original Message-----
> From: Stephen Boyd <sboyd@kernel.org>
> Sent: June 29, 2021 2:08 AM
> To: Michael Turquette <mturquette@baylibre.com>; Stephen Boyd
> <sboyd@kernel.org>
> Cc: linux-kernel@vger.kernel.org; linux-clk@vger.kernel.org; kernel test
> robot <lkp@intel.com>; Liam Beguin <lvb@xiphos.com>
> Subject: [PATCH 1/2] clk: lmk04832: Depend on SPI
>
> This driver depends on SPI. Otherwise compilation fails
>
> clk-lmk04832.c:(.text+0x1668): undefined reference to `spi_get_device_id'
>
> Reported-by: kernel test robot <lkp@intel.com>
> Cc: Liam Beguin <lvb@xiphos.com>
> Fixes: 3bc61cfd6f4a ("clk: add support for the lmk04832")
> Signed-off-by: Stephen Boyd <sboyd@kernel.org>
Reviewed-by: Liam Beguin <lvb@xiphos.com>
> ---
> drivers/clk/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/clk/Kconfig b/drivers/clk/Kconfig
> index ccf77849bdbd..d49cf3ae52aa 100644
> --- a/drivers/clk/Kconfig
> +++ b/drivers/clk/Kconfig
> @@ -57,6 +57,7 @@ config CLK_HSDK
>
> config LMK04832
> tristate "Ti LMK04832 JESD204B Compliant Clock Jitter Cleaner"
> + depends on SPI
> select REGMAP_SPI
> help
> Say yes here to build support for Texas Instruments' LMK04832
> Ultra
> --
> https://git.kernel.org/pub/scm/linux/kernel/git/clk/linux.git/
> https://git.kernel.org/pub/scm/linux/kernel/git/sboyd/spmi.git
prev parent reply other threads:[~2021-06-29 15:01 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-29 6:07 [PATCH 1/2] clk: lmk04832: Depend on SPI Stephen Boyd
2021-06-29 6:07 ` [PATCH 2/2] clk: lmk04832: Use of match table Stephen Boyd
2021-06-29 15:03 ` Liam Beguin
2021-06-29 15:01 ` Liam Beguin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YQBPR0101MB1811EF89914E845264FA4DE8D8029@YQBPR0101MB1811.CANPRD01.PROD.OUTLOOK.COM \
--to=lvb@xiphos.com \
--cc=liambeguin@gmail.com \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lkp@intel.com \
--cc=mturquette@baylibre.com \
--cc=sboyd@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.