From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 37224C432BE for ; Wed, 28 Jul 2021 14:10:56 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1ED8860BD3 for ; Wed, 28 Jul 2021 14:10:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236707AbhG1OK4 (ORCPT ); Wed, 28 Jul 2021 10:10:56 -0400 Received: from vps0.lunn.ch ([185.16.172.187]:49924 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236668AbhG1OKz (ORCPT ); Wed, 28 Jul 2021 10:10:55 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Disposition:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:From:Sender:Reply-To:Subject: Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Content-Disposition:In-Reply-To:References; bh=dn7Kp73y2jWoHdQMYsqP+HDt7Jswx+VZ/Cd2d00WOak=; b=oDIUmU8rD1Z1i6GeQCvr9SAo2b op4tL38NAz23ewHcEPU8UnkGvI3vbXp0cQ873+q2r+zreVEB4JTlymNHLOkvyZc4Zmpw8+zCJERmi IKMZGsD0lniUXMd6+d9ed70GHGPOkiCcHI/ZKj8SsZAz9MoS7BiNR249pS/37fbTIM9U=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1m8kGl-00FB92-Q5; Wed, 28 Jul 2021 16:10:47 +0200 Date: Wed, 28 Jul 2021 16:10:47 +0200 From: Andrew Lunn To: Joakim Zhang Cc: davem@davemloft.net, kuba@kernel.org, robh+dt@kernel.org, shawnguo@kernel.org, s.hauer@pengutronix.de, kernel@pengutronix.de, festevam@gmail.com, linux-imx@nxp.com, netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH V2 net-next 5/7] net: fec: add MAC internal delayed clock feature support Message-ID: References: <20210728115203.16263-1-qiangqing.zhang@nxp.com> <20210728115203.16263-6-qiangqing.zhang@nxp.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210728115203.16263-6-qiangqing.zhang@nxp.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > + /* For rgmii internal delay, valid values are 0ps and 2000ps */ > + if (of_property_read_u32(np, "tx-internal-delay-ps", &rgmii_delay)) > + fep->rgmii_txc_dly = true; > + if (of_property_read_u32(np, "rx-internal-delay-ps", &rgmii_delay)) > + fep->rgmii_rxc_dly = true; I don't see any validation of the only supported values are 0ps and 2000ps. Andrew