* [PATCH V2] cfg80211: Fix possible memory leak in function cfg80211_bss_update
@ 2021-06-28 13:23 ` Nguyen Dinh Phi
0 siblings, 0 replies; 8+ messages in thread
From: Nguyen Dinh Phi @ 2021-06-28 13:23 UTC (permalink / raw)
To: johannes, davem, kuba
Cc: Nguyen Dinh Phi, linux-wireless, netdev, linux-kernel,
linux-kernel-mentees
When we exceed the limit of BSS entries, this function will free the
new entry, however, at this time, it is the last door to access the
inputed ies, so these ies will be unreferenced objects and cause memory
leak.
Therefore we should free its ies before deallocating the new entry, beside
of dropping it from hidden_list.
Signed-off-by: Nguyen Dinh Phi <phind.uet@gmail.com>
---
V2: - Add subsystem to the subject line.
- Use bss_ref_put function for better clean-up dynamically allocated
cfg80211_internal_bss objects. It helps to clean relative hidden_bss.
net/wireless/scan.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/net/wireless/scan.c b/net/wireless/scan.c
index f03c7ac8e184..7897b1478c3c 100644
--- a/net/wireless/scan.c
+++ b/net/wireless/scan.c
@@ -1754,16 +1754,14 @@ cfg80211_bss_update(struct cfg80211_registered_device *rdev,
* be grouped with this beacon for updates ...
*/
if (!cfg80211_combine_bsses(rdev, new)) {
- kfree(new);
+ bss_ref_put(rdev, new);
goto drop;
}
}
if (rdev->bss_entries >= bss_entries_limit &&
!cfg80211_bss_expire_oldest(rdev)) {
- if (!list_empty(&new->hidden_list))
- list_del(&new->hidden_list);
- kfree(new);
+ bss_ref_put(rdev, new);
goto drop;
}
--
2.25.1
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [PATCH V2] cfg80211: Fix possible memory leak in function cfg80211_bss_update
@ 2021-06-28 13:23 ` Nguyen Dinh Phi
0 siblings, 0 replies; 8+ messages in thread
From: Nguyen Dinh Phi @ 2021-06-28 13:23 UTC (permalink / raw)
To: johannes, davem, kuba
Cc: netdev, linux-wireless, linux-kernel, linux-kernel-mentees
When we exceed the limit of BSS entries, this function will free the
new entry, however, at this time, it is the last door to access the
inputed ies, so these ies will be unreferenced objects and cause memory
leak.
Therefore we should free its ies before deallocating the new entry, beside
of dropping it from hidden_list.
Signed-off-by: Nguyen Dinh Phi <phind.uet@gmail.com>
---
V2: - Add subsystem to the subject line.
- Use bss_ref_put function for better clean-up dynamically allocated
cfg80211_internal_bss objects. It helps to clean relative hidden_bss.
net/wireless/scan.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/net/wireless/scan.c b/net/wireless/scan.c
index f03c7ac8e184..7897b1478c3c 100644
--- a/net/wireless/scan.c
+++ b/net/wireless/scan.c
@@ -1754,16 +1754,14 @@ cfg80211_bss_update(struct cfg80211_registered_device *rdev,
* be grouped with this beacon for updates ...
*/
if (!cfg80211_combine_bsses(rdev, new)) {
- kfree(new);
+ bss_ref_put(rdev, new);
goto drop;
}
}
if (rdev->bss_entries >= bss_entries_limit &&
!cfg80211_bss_expire_oldest(rdev)) {
- if (!list_empty(&new->hidden_list))
- list_del(&new->hidden_list);
- kfree(new);
+ bss_ref_put(rdev, new);
goto drop;
}
--
2.25.1
_______________________________________________
Linux-kernel-mentees mailing list
Linux-kernel-mentees@lists.linuxfoundation.org
https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees
^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH V2] cfg80211: Fix possible memory leak in function cfg80211_bss_update
2021-06-28 13:23 ` Nguyen Dinh Phi
@ 2021-07-29 10:34 ` Greg KH
-1 siblings, 0 replies; 8+ messages in thread
From: Greg KH @ 2021-07-29 10:34 UTC (permalink / raw)
To: Nguyen Dinh Phi
Cc: johannes, davem, kuba, netdev, linux-wireless, linux-kernel,
linux-kernel-mentees
On Mon, Jun 28, 2021 at 09:23:34PM +0800, Nguyen Dinh Phi wrote:
> When we exceed the limit of BSS entries, this function will free the
> new entry, however, at this time, it is the last door to access the
> inputed ies, so these ies will be unreferenced objects and cause memory
> leak.
> Therefore we should free its ies before deallocating the new entry, beside
> of dropping it from hidden_list.
>
> Signed-off-by: Nguyen Dinh Phi <phind.uet@gmail.com>
> ---
> V2: - Add subsystem to the subject line.
> - Use bss_ref_put function for better clean-up dynamically allocated
> cfg80211_internal_bss objects. It helps to clean relative hidden_bss.
>
> net/wireless/scan.c | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/net/wireless/scan.c b/net/wireless/scan.c
> index f03c7ac8e184..7897b1478c3c 100644
> --- a/net/wireless/scan.c
> +++ b/net/wireless/scan.c
> @@ -1754,16 +1754,14 @@ cfg80211_bss_update(struct cfg80211_registered_device *rdev,
> * be grouped with this beacon for updates ...
> */
> if (!cfg80211_combine_bsses(rdev, new)) {
> - kfree(new);
> + bss_ref_put(rdev, new);
> goto drop;
> }
> }
>
> if (rdev->bss_entries >= bss_entries_limit &&
> !cfg80211_bss_expire_oldest(rdev)) {
> - if (!list_empty(&new->hidden_list))
> - list_del(&new->hidden_list);
> - kfree(new);
> + bss_ref_put(rdev, new);
> goto drop;
> }
>
> --
> 2.25.1
Did this change get lost somewhere?
thanks,
greg k-h
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH V2] cfg80211: Fix possible memory leak in function cfg80211_bss_update
@ 2021-07-29 10:34 ` Greg KH
0 siblings, 0 replies; 8+ messages in thread
From: Greg KH @ 2021-07-29 10:34 UTC (permalink / raw)
To: Nguyen Dinh Phi
Cc: netdev, linux-wireless, linux-kernel, kuba, johannes,
linux-kernel-mentees, davem
On Mon, Jun 28, 2021 at 09:23:34PM +0800, Nguyen Dinh Phi wrote:
> When we exceed the limit of BSS entries, this function will free the
> new entry, however, at this time, it is the last door to access the
> inputed ies, so these ies will be unreferenced objects and cause memory
> leak.
> Therefore we should free its ies before deallocating the new entry, beside
> of dropping it from hidden_list.
>
> Signed-off-by: Nguyen Dinh Phi <phind.uet@gmail.com>
> ---
> V2: - Add subsystem to the subject line.
> - Use bss_ref_put function for better clean-up dynamically allocated
> cfg80211_internal_bss objects. It helps to clean relative hidden_bss.
>
> net/wireless/scan.c | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/net/wireless/scan.c b/net/wireless/scan.c
> index f03c7ac8e184..7897b1478c3c 100644
> --- a/net/wireless/scan.c
> +++ b/net/wireless/scan.c
> @@ -1754,16 +1754,14 @@ cfg80211_bss_update(struct cfg80211_registered_device *rdev,
> * be grouped with this beacon for updates ...
> */
> if (!cfg80211_combine_bsses(rdev, new)) {
> - kfree(new);
> + bss_ref_put(rdev, new);
> goto drop;
> }
> }
>
> if (rdev->bss_entries >= bss_entries_limit &&
> !cfg80211_bss_expire_oldest(rdev)) {
> - if (!list_empty(&new->hidden_list))
> - list_del(&new->hidden_list);
> - kfree(new);
> + bss_ref_put(rdev, new);
> goto drop;
> }
>
> --
> 2.25.1
Did this change get lost somewhere?
thanks,
greg k-h
_______________________________________________
Linux-kernel-mentees mailing list
Linux-kernel-mentees@lists.linuxfoundation.org
https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH V2] cfg80211: Fix possible memory leak in function cfg80211_bss_update
2021-07-29 10:34 ` Greg KH
@ 2021-07-31 7:53 ` Kalle Valo
-1 siblings, 0 replies; 8+ messages in thread
From: Kalle Valo @ 2021-07-31 7:53 UTC (permalink / raw)
To: Greg KH
Cc: Nguyen Dinh Phi, johannes, davem, kuba, netdev, linux-wireless,
linux-kernel, linux-kernel-mentees
Greg KH <greg@kroah.com> writes:
> On Mon, Jun 28, 2021 at 09:23:34PM +0800, Nguyen Dinh Phi wrote:
>> When we exceed the limit of BSS entries, this function will free the
>> new entry, however, at this time, it is the last door to access the
>> inputed ies, so these ies will be unreferenced objects and cause memory
>> leak.
>> Therefore we should free its ies before deallocating the new entry, beside
>> of dropping it from hidden_list.
>>
>> Signed-off-by: Nguyen Dinh Phi <phind.uet@gmail.com>
[...]
> Did this change get lost somewhere?
Johannes applied it to the macc80211 tree:
https://git.kernel.org/pub/scm/linux/kernel/git/jberg/mac80211.git/commit/?id=f9a5c358c8d26fed0cc45f2afc64633d4ba21dff
Ah, and it's already in Linus' tree as well.
--
https://patchwork.kernel.org/project/linux-wireless/list/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH V2] cfg80211: Fix possible memory leak in function cfg80211_bss_update
@ 2021-07-31 7:53 ` Kalle Valo
0 siblings, 0 replies; 8+ messages in thread
From: Kalle Valo @ 2021-07-31 7:53 UTC (permalink / raw)
To: Greg KH
Cc: netdev, linux-wireless, linux-kernel, kuba, johannes,
linux-kernel-mentees, davem
Greg KH <greg@kroah.com> writes:
> On Mon, Jun 28, 2021 at 09:23:34PM +0800, Nguyen Dinh Phi wrote:
>> When we exceed the limit of BSS entries, this function will free the
>> new entry, however, at this time, it is the last door to access the
>> inputed ies, so these ies will be unreferenced objects and cause memory
>> leak.
>> Therefore we should free its ies before deallocating the new entry, beside
>> of dropping it from hidden_list.
>>
>> Signed-off-by: Nguyen Dinh Phi <phind.uet@gmail.com>
[...]
> Did this change get lost somewhere?
Johannes applied it to the macc80211 tree:
https://git.kernel.org/pub/scm/linux/kernel/git/jberg/mac80211.git/commit/?id=f9a5c358c8d26fed0cc45f2afc64633d4ba21dff
Ah, and it's already in Linus' tree as well.
--
https://patchwork.kernel.org/project/linux-wireless/list/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
_______________________________________________
Linux-kernel-mentees mailing list
Linux-kernel-mentees@lists.linuxfoundation.org
https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH V2] cfg80211: Fix possible memory leak in function cfg80211_bss_update
2021-07-31 7:53 ` Kalle Valo
@ 2021-07-31 8:02 ` Greg KH
-1 siblings, 0 replies; 8+ messages in thread
From: Greg KH @ 2021-07-31 8:02 UTC (permalink / raw)
To: Kalle Valo
Cc: Nguyen Dinh Phi, johannes, davem, kuba, netdev, linux-wireless,
linux-kernel, linux-kernel-mentees
On Sat, Jul 31, 2021 at 10:53:28AM +0300, Kalle Valo wrote:
> Greg KH <greg@kroah.com> writes:
>
> > On Mon, Jun 28, 2021 at 09:23:34PM +0800, Nguyen Dinh Phi wrote:
> >> When we exceed the limit of BSS entries, this function will free the
> >> new entry, however, at this time, it is the last door to access the
> >> inputed ies, so these ies will be unreferenced objects and cause memory
> >> leak.
> >> Therefore we should free its ies before deallocating the new entry, beside
> >> of dropping it from hidden_list.
> >>
> >> Signed-off-by: Nguyen Dinh Phi <phind.uet@gmail.com>
>
> [...]
>
> > Did this change get lost somewhere?
>
> Johannes applied it to the macc80211 tree:
>
> https://git.kernel.org/pub/scm/linux/kernel/git/jberg/mac80211.git/commit/?id=f9a5c358c8d26fed0cc45f2afc64633d4ba21dff
>
> Ah, and it's already in Linus' tree as well.
Ah, thanks, I had missed that it just landed there.
greg k-h
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH V2] cfg80211: Fix possible memory leak in function cfg80211_bss_update
@ 2021-07-31 8:02 ` Greg KH
0 siblings, 0 replies; 8+ messages in thread
From: Greg KH @ 2021-07-31 8:02 UTC (permalink / raw)
To: Kalle Valo
Cc: netdev, linux-wireless, linux-kernel, kuba, johannes,
linux-kernel-mentees, davem
On Sat, Jul 31, 2021 at 10:53:28AM +0300, Kalle Valo wrote:
> Greg KH <greg@kroah.com> writes:
>
> > On Mon, Jun 28, 2021 at 09:23:34PM +0800, Nguyen Dinh Phi wrote:
> >> When we exceed the limit of BSS entries, this function will free the
> >> new entry, however, at this time, it is the last door to access the
> >> inputed ies, so these ies will be unreferenced objects and cause memory
> >> leak.
> >> Therefore we should free its ies before deallocating the new entry, beside
> >> of dropping it from hidden_list.
> >>
> >> Signed-off-by: Nguyen Dinh Phi <phind.uet@gmail.com>
>
> [...]
>
> > Did this change get lost somewhere?
>
> Johannes applied it to the macc80211 tree:
>
> https://git.kernel.org/pub/scm/linux/kernel/git/jberg/mac80211.git/commit/?id=f9a5c358c8d26fed0cc45f2afc64633d4ba21dff
>
> Ah, and it's already in Linus' tree as well.
Ah, thanks, I had missed that it just landed there.
greg k-h
_______________________________________________
Linux-kernel-mentees mailing list
Linux-kernel-mentees@lists.linuxfoundation.org
https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2021-07-31 8:04 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-06-28 13:23 [PATCH V2] cfg80211: Fix possible memory leak in function cfg80211_bss_update Nguyen Dinh Phi
2021-06-28 13:23 ` Nguyen Dinh Phi
2021-07-29 10:34 ` Greg KH
2021-07-29 10:34 ` Greg KH
2021-07-31 7:53 ` Kalle Valo
2021-07-31 7:53 ` Kalle Valo
2021-07-31 8:02 ` Greg KH
2021-07-31 8:02 ` Greg KH
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.