From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AA767C4338F for ; Thu, 29 Jul 2021 11:55:35 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8762560EFD for ; Thu, 29 Jul 2021 11:55:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234664AbhG2Lzh (ORCPT ); Thu, 29 Jul 2021 07:55:37 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51870 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232122AbhG2Lzg (ORCPT ); Thu, 29 Jul 2021 07:55:36 -0400 Received: from mail-wr1-x432.google.com (mail-wr1-x432.google.com [IPv6:2a00:1450:4864:20::432]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C2C51C061765 for ; Thu, 29 Jul 2021 04:55:32 -0700 (PDT) Received: by mail-wr1-x432.google.com with SMTP id m12so1790759wru.12 for ; Thu, 29 Jul 2021 04:55:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=resnulli-us.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=zXAEOLN9SYnmGGjsihLTS/Qt+xjg3BkjUtxD75Hc1B0=; b=qktN/sJt3VVMEgerPW78YecwI/DVI1W01zC9uJlT0gtjdbtEEQxgiPgFQTb1o8KIqq 1Xu2+Nb7znYJU3T/0k1QkhZIMww9cREVnqBuIXZIIGAQCUgS8BKwRnJu8vC8a0rbS3xS SmMddVrcFwEHdI3hAwyelcQcPRxTQBN62VZ+LPFetBANe7Lb8LP3WFOC2pJC7yWYEcKY 7L58TpZVYUlg2YJ+s45T+Ng+I1kWsR0Fs4pDlCHoAhIIAU4n+S5x+gspJo60xSyZ3Knr soSwa7QBM+vL8ZlYHZBwaWYpQmPojhQvp1lGQkWrGJ+k4uq3pJCbLeLb6evrSIodvYF7 IjKg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=zXAEOLN9SYnmGGjsihLTS/Qt+xjg3BkjUtxD75Hc1B0=; b=FSKOhwA7QZGScN8SsMwTFa9ggZNc+jXZErB04GXlikenfIxrPdGWOw4XBH+5RyF1LU Kvw6Pfr22dI9WTD3Q63UmjuzQJVmZnIsdGwHNNoeEPBY08GUcAplVs+Xcm6MFCmeSd/x hFWFdD40KBqVloldxhjjtLU7jsEuwaT/ELpMpcUo5bJWvjFxkaKASVQPVlq7Wr5+Po0k 6w8AEqkuah8ltR9E9LoijJC0mctFM+0CMDQH5IFliz/buLgAZ7i4GdX8z/zequL/7eNs 3RAm0Ts0S3djuBRgqNgql6BDfWKckr1AObXf4ewNNHZ4+QMijruvf7AzHBKuKMNM/1aE klEw== X-Gm-Message-State: AOAM531ROWlAtI5jk6x3InzULXy3nEg8VfLliF6rHPQE/Gurx1cvUF+9 /zmmrKb+yxy+NPEeiR9BD9ijjQ== X-Google-Smtp-Source: ABdhPJw8gVdPhukKi7m7Re7PufSJ5utAmX0FeBiTeQ+8h/WG7HqlU8/4O3cNXce1P+c5pLBaBlNHpA== X-Received: by 2002:adf:d225:: with SMTP id k5mr4425617wrh.10.1627559731389; Thu, 29 Jul 2021 04:55:31 -0700 (PDT) Received: from localhost (host-213-179-129-39.customer.m-online.net. [213.179.129.39]) by smtp.gmail.com with ESMTPSA id j14sm3306941wru.58.2021.07.29.04.55.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 29 Jul 2021 04:55:30 -0700 (PDT) Date: Thu, 29 Jul 2021 13:55:29 +0200 From: Jiri Pirko To: Leon Romanovsky Cc: "David S. Miller" , Jakub Kicinski , Jiri Pirko , Leon Romanovsky , linux-kernel@vger.kernel.org, netdev@vger.kernel.org, Parav Pandit Subject: Re: [PATCH net-next 2/2] devlink: Allocate devlink directly in requested net namespace Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Thu, Jul 29, 2021 at 10:15:26AM CEST, leon@kernel.org wrote: >From: Leon Romanovsky > >There is no need in extra call indirection and check from impossible >flow where someone tries to set namespace without prior call >to devlink_alloc(). > >Instead of this extra logic and additional EXPORT_SYMBOL, use specialized >devlink allocation function that receives net namespace as an argument. > >Such specialized API allows clear view when devlink initialized in wrong >net namespace and/or kernel users don't try to change devlink namespace >under the hood. > >Signed-off-by: Leon Romanovsky >--- > drivers/net/netdevsim/dev.c | 4 ++-- > include/net/devlink.h | 14 ++++++++++++-- > net/core/devlink.c | 26 ++++++++------------------ > 3 files changed, 22 insertions(+), 22 deletions(-) > >diff --git a/drivers/net/netdevsim/dev.c b/drivers/net/netdevsim/dev.c >index 6348307bfa84..d538a39d4225 100644 >--- a/drivers/net/netdevsim/dev.c >+++ b/drivers/net/netdevsim/dev.c >@@ -1431,10 +1431,10 @@ int nsim_dev_probe(struct nsim_bus_dev *nsim_bus_dev) > struct devlink *devlink; > int err; > >- devlink = devlink_alloc(&nsim_dev_devlink_ops, sizeof(*nsim_dev)); >+ devlink = devlink_alloc_ns(&nsim_dev_devlink_ops, sizeof(*nsim_dev), >+ nsim_bus_dev->initial_net); > if (!devlink) > return -ENOMEM; >- devlink_net_set(devlink, nsim_bus_dev->initial_net); > nsim_dev = devlink_priv(devlink); > nsim_dev->nsim_bus_dev = nsim_bus_dev; > nsim_dev->switch_id.id_len = sizeof(nsim_dev->switch_id.id); >diff --git a/include/net/devlink.h b/include/net/devlink.h >index e48a62320407..b4691c40320f 100644 >--- a/include/net/devlink.h >+++ b/include/net/devlink.h >@@ -1540,8 +1540,18 @@ static inline struct devlink *netdev_to_devlink(struct net_device *dev) > struct ib_device; > > struct net *devlink_net(const struct devlink *devlink); >-void devlink_net_set(struct devlink *devlink, struct net *net); >-struct devlink *devlink_alloc(const struct devlink_ops *ops, size_t priv_size); >+/* This RAW call is intended for software devices that can Not sure what "RAW call" is, perhaps you can just avoid this here. Otherwise, this patch looks fine to me: Reviewed-by: Jiri Pirko [...]