From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3417CC4338F for ; Thu, 29 Jul 2021 15:41:28 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E4AE660E94 for ; Thu, 29 Jul 2021 15:41:27 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org E4AE660E94 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lunn.ch Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=HB04SS/ENAO1fM+cpOUZLbp274epkiT///HQWs3raXs=; b=4nG+gmVCthCxY5 xARzZajfVHSczC3LSdyQesqLrCaWpzW909C5ug3mJdslVnCneFS/I+iZEWCRvT57sY5KDoCnML1H/ Knn3G+T0SwCitQe2JfripmqLJ5RC9I8lQ4bMhIDqbShFZU8XUXzQMfGRBkSQpW/WDhIc3LdEtuH8x YIGGam8O0hlHvoxlHKGjI/gkWy0Ckfk6c/ttdSpPKK081veW0gPqWF81+hgV5CPi5ubm/wI7pX7aE O9gnp3FbxBeUgW+SYm8fYNccb1LQs886L8YAD0lxyGt2GSRfy5zfcJQgra+hVZYap9zv8zy0d7Cs0 3UNzc6wt1+lhxSwlLGxQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1m987N-004lTq-ST; Thu, 29 Jul 2021 15:38:42 +0000 Received: from vps0.lunn.ch ([185.16.172.187]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1m982M-004jta-QC for linux-arm-kernel@lists.infradead.org; Thu, 29 Jul 2021 15:33:32 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Disposition:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:From:Sender:Reply-To:Subject: Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Content-Disposition:In-Reply-To:References; bh=5ZotjzKPrVJ6xCePqW0vlERkjrNB5BqRtIAsddmpMmA=; b=gHaZc6wy49HS8kF+klnXM/xrcI WXS2rG6Wq4LnZX9cgMHSJKgHirHGUMjElLAeifmrIypxuTJlUCiXLXnC8zEc9Qlt/N2XuWfONt3kM a1U6nAP1/BHaCSw8NkJYFrEZ23NaH9Po+CAOnIz5tuchwuDgvQWQlcuS8AwGHm38HKgA=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1m982I-00FKQO-AP; Thu, 29 Jul 2021 17:33:26 +0200 Date: Thu, 29 Jul 2021 17:33:26 +0200 From: Andrew Lunn To: Linus Walleij Cc: linux-arm-kernel@lists.infradead.org, Imre Kaloz , Krzysztof Halasa , phj@phj.hu Subject: Re: [PATCH] ARM: dts: ixp4xx: Add devicetree for Linksys WRV54G Message-ID: References: <20210729082658.2815884-1-linus.walleij@linaro.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210729082658.2815884-1-linus.walleij@linaro.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210729_083330_920213_D47733CD X-CRM114-Status: GOOD ( 15.18 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org > + /* This set-up comes from an OpenWrt patch */ > + spi { > + compatible = "spi-gpio"; > + #address-cells = <1>; > + #size-cells = <0>; > + > + sck-gpios = <&gpio0 7 GPIO_ACTIVE_HIGH>; > + miso-gpios = <&gpio0 12 GPIO_ACTIVE_HIGH>; > + mosi-gpios = <&gpio0 6 GPIO_ACTIVE_HIGH>; > + cs-gpios = <&gpio0 5 GPIO_ACTIVE_LOW>; > + num-chipselects = <1>; > + > + switch@0 { > + compatible = "micrel,ks8995"; Hi Linus This does not exist in mainline. And when it does, i guess it will be called microchip,ksz8995. See microchip,ksz.yaml. It is also missing all the ethernet-ports nodes. Maybe leave this out until the driver gets ported? > + /* > + * EthB - connected to the KS8995 switch ports 1-4 > + * FIXME: the boardfile defines .phy_mask = 0x1e for this port to enable output to > + * all four switch ports, also using an out of tree multiphy patch. > + * Do we need a new binding and property for this? > + */ This sounds like an issue with the KS8995 driver in OpenWRT. > + ethernet@c8009000 { > + status = "ok"; > + queue-rx = <&qmgr 3>; > + queue-txready = <&qmgr 20>; > + phy-mode = "rgmii"; > + phy-handle = <&phy4>; It looks like phy4 is a switch PHY. It is not actually connected to this MAC? So this is wrong for mainline. > + > + mdio { > + #address-cells = <1>; > + #size-cells = <0>; > + > + /* Should be ports 1-4 on the KS8995 switch */ > + phy4: ethernet-phy@4 { > + reg = <4>; > + }; > + > + /* Should be port 5 on the KS8995 switch */ > + phy5: ethernet-phy@5 { > + reg = <5>; > + }; > + }; > + }; > + > + /* EthC - connected to KS8995 switch port 5 */ > + ethernet@c800a000 { > + status = "ok"; > + queue-rx = <&qmgr 4>; > + queue-txready = <&qmgr 21>; > + phy-mode = "rgmii"; > + phy-handle = <&phy5>; And i doubt this is correct. Unless there are back to back PHYs? I would suggest you leave out all the switch related properties until the switch driver is available. Andrew _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel