From: Peter Xu <peterx@redhat.com>
To: "Philippe Mathieu-Daudé" <philmd@redhat.com>
Cc: Juan Quintela <quintela@redhat.com>,
qemu-devel@nongnu.org,
"Dr . David Alan Gilbert" <dgilbert@redhat.com>,
Leonardo Bras Soares Passos <lsoaresp@redhat.com>,
Paolo Bonzini <pbonzini@redhat.com>,
Richard Henderson <rth@twiddle.net>
Subject: Re: [PATCH] tests: Fix migration-test build failure for sparc
Date: Thu, 29 Jul 2021 11:39:06 -0400 [thread overview]
Message-ID: <YQLLmrUMYURV8tgH@t490s> (raw)
In-Reply-To: <145cf8c7-84f3-6743-d1cd-02eba6a613bd@redhat.com>
On Thu, Jul 29, 2021 at 01:48:57AM +0200, Philippe Mathieu-Daudé wrote:
> On 7/28/21 11:41 PM, Peter Xu wrote:
> > Even if <linux/kvm.h> seems to exist for all archs on linux, however including
> > it with __linux__ defined seems to be not working yet as it'll try to include
> > asm/kvm.h and that can be missing for archs that do not support kvm.
> >
> > To fix this (instead of any attempt to fix linux headers..), we can mark the
> > header to be x86_64 only, because it's so far only service for adding the kvm
> > dirty ring test.
> >
> > No need to have "Fixes" as the issue is just introduced very recently.
>
> Personally I find it very useful to navigate in gitk without having
> to use git-blame.
Makes sense.
>
> Fixes: 1f546b709d6 ("tests: migration-test: Add dirty ring test")
> Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Thanks all!
--
Peter Xu
next prev parent reply other threads:[~2021-07-29 15:39 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-28 21:41 [PATCH] tests: Fix migration-test build failure for sparc Peter Xu
2021-07-28 22:02 ` Peter Xu
2021-07-28 23:05 ` Richard Henderson
2021-07-28 23:48 ` Philippe Mathieu-Daudé
2021-07-29 15:39 ` Peter Xu [this message]
2021-07-29 5:55 ` Thomas Huth
2021-07-29 8:26 ` Dr. David Alan Gilbert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YQLLmrUMYURV8tgH@t490s \
--to=peterx@redhat.com \
--cc=dgilbert@redhat.com \
--cc=lsoaresp@redhat.com \
--cc=pbonzini@redhat.com \
--cc=philmd@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
--cc=rth@twiddle.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.