From: Rob Herring <robh@kernel.org>
To: Guenter Roeck <linux@roeck-us.net>
Cc: Samuel Holland <samuel@sholland.org>,
Wim Van Sebroeck <wim@linux-watchdog.org>,
Maxime Ripard <mripard@kernel.org>, Chen-Yu Tsai <wens@csie.org>,
Jernej Skrabec <jernej.skrabec@gmail.com>,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-sunxi@lists.linux.dev, linux-watchdog@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/3] dt-bindings: watchdog: sunxi: Add compatible for D1
Date: Thu, 29 Jul 2021 16:39:47 -0600 [thread overview]
Message-ID: <YQMuM2McwNGzqAhe@robh.at.kernel.org> (raw)
In-Reply-To: <20210729042449.GA1716994@roeck-us.net>
On Wed, Jul 28, 2021 at 09:24:49PM -0700, Guenter Roeck wrote:
> On Sun, Jul 25, 2021 at 10:51:42PM -0500, Samuel Holland wrote:
> > D1 keeps the same register layout and clock sources as the R329, but it
> > adds a key field which must be set to update the watchdog's "CFG" and
> > "MODE" registers. Therefore it is not backward-compatible.
> >
> > Signed-off-by: Samuel Holland <samuel@sholland.org>
> > ---
> > .../devicetree/bindings/watchdog/allwinner,sun4i-a10-wdt.yaml | 2 ++
> > 1 file changed, 2 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/watchdog/allwinner,sun4i-a10-wdt.yaml b/Documentation/devicetree/bindings/watchdog/allwinner,sun4i-a10-wdt.yaml
> > index 853ceb1b7c0f..756e6ab99860 100644
> > --- a/Documentation/devicetree/bindings/watchdog/allwinner,sun4i-a10-wdt.yaml
> > +++ b/Documentation/devicetree/bindings/watchdog/allwinner,sun4i-a10-wdt.yaml
> > @@ -29,6 +29,7 @@ properties:
> > - items:
> > - const: allwinner,suniv-f1c100s-wdt
> > - const: allwinner,sun4i-a10-wdt
> > + - const: allwinner,sun20i-d1-wdt
>
> Alignment is off.
No, it's correct. It's not part of the above list, but a new 'oneOf'
entry.
Rob
WARNING: multiple messages have this Message-ID (diff)
From: Rob Herring <robh@kernel.org>
To: Guenter Roeck <linux@roeck-us.net>
Cc: Samuel Holland <samuel@sholland.org>,
Wim Van Sebroeck <wim@linux-watchdog.org>,
Maxime Ripard <mripard@kernel.org>, Chen-Yu Tsai <wens@csie.org>,
Jernej Skrabec <jernej.skrabec@gmail.com>,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-sunxi@lists.linux.dev, linux-watchdog@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/3] dt-bindings: watchdog: sunxi: Add compatible for D1
Date: Thu, 29 Jul 2021 16:39:47 -0600 [thread overview]
Message-ID: <YQMuM2McwNGzqAhe@robh.at.kernel.org> (raw)
In-Reply-To: <20210729042449.GA1716994@roeck-us.net>
On Wed, Jul 28, 2021 at 09:24:49PM -0700, Guenter Roeck wrote:
> On Sun, Jul 25, 2021 at 10:51:42PM -0500, Samuel Holland wrote:
> > D1 keeps the same register layout and clock sources as the R329, but it
> > adds a key field which must be set to update the watchdog's "CFG" and
> > "MODE" registers. Therefore it is not backward-compatible.
> >
> > Signed-off-by: Samuel Holland <samuel@sholland.org>
> > ---
> > .../devicetree/bindings/watchdog/allwinner,sun4i-a10-wdt.yaml | 2 ++
> > 1 file changed, 2 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/watchdog/allwinner,sun4i-a10-wdt.yaml b/Documentation/devicetree/bindings/watchdog/allwinner,sun4i-a10-wdt.yaml
> > index 853ceb1b7c0f..756e6ab99860 100644
> > --- a/Documentation/devicetree/bindings/watchdog/allwinner,sun4i-a10-wdt.yaml
> > +++ b/Documentation/devicetree/bindings/watchdog/allwinner,sun4i-a10-wdt.yaml
> > @@ -29,6 +29,7 @@ properties:
> > - items:
> > - const: allwinner,suniv-f1c100s-wdt
> > - const: allwinner,sun4i-a10-wdt
> > + - const: allwinner,sun20i-d1-wdt
>
> Alignment is off.
No, it's correct. It's not part of the above list, but a new 'oneOf'
entry.
Rob
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-07-29 22:39 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-26 3:51 [PATCH 1/3] dt-bindings: watchdog: sunxi: Add compatible for R329 Samuel Holland
2021-07-26 3:51 ` Samuel Holland
2021-07-26 3:51 ` [PATCH 2/3] dt-bindings: watchdog: sunxi: Add compatible for D1 Samuel Holland
2021-07-26 3:51 ` Samuel Holland
2021-07-29 4:24 ` Guenter Roeck
2021-07-29 4:24 ` Guenter Roeck
2021-07-29 22:39 ` Rob Herring [this message]
2021-07-29 22:39 ` Rob Herring
2021-07-30 1:14 ` Guenter Roeck
2021-07-30 1:14 ` Guenter Roeck
2021-07-29 22:40 ` Rob Herring
2021-07-29 22:40 ` Rob Herring
2021-07-26 3:51 ` [PATCH 3/3] watchdog: sunxi_wdt: Add support " Samuel Holland
2021-07-26 3:51 ` Samuel Holland
2021-07-29 4:11 ` Guenter Roeck
2021-07-29 4:11 ` Guenter Roeck
2021-07-29 12:18 ` [PATCH 1/3] dt-bindings: watchdog: sunxi: Add compatible for R329 Maxime Ripard
2021-07-29 12:18 ` Maxime Ripard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YQMuM2McwNGzqAhe@robh.at.kernel.org \
--to=robh@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jernej.skrabec@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sunxi@lists.linux.dev \
--cc=linux-watchdog@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=mripard@kernel.org \
--cc=samuel@sholland.org \
--cc=wens@csie.org \
--cc=wim@linux-watchdog.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.