From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-io1-f41.google.com (mail-io1-f41.google.com [209.85.166.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4670272 for ; Thu, 29 Jul 2021 22:39:50 +0000 (UTC) Received: by mail-io1-f41.google.com with SMTP id f6so3276502ioc.6 for ; Thu, 29 Jul 2021 15:39:50 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=XlptD/tZIHvjx581AafuTapU2M/nw56BX9ZwEjQcLOM=; b=L2UAGOibiz7YoosqX1kAq5iAc5Ugc54DQD8+aZJVtq0BmQthrUzaiARTXvrsHSBw5J R6H7zfTY9flq2Jhf+CWxplEzB1HPgRXG+YrKwBowSGQcItXstncWeca1kUifjFbPVqiV 2aPllWtyu1JGx7tF3+tgbDq8Pt78EL1RuHT8Mi3CImAIq7vfRydXtHr9xn7wW3FmQiPb knv1YxavsykzIcc4DRouseviyAv5HkacPW2CYEnWkKyd/RmJV9Vuk3EOhzujpEdZElEP 6KzWzKds0Whn0taa7zZC7lkZ8EnJ/SfrslkCKIRpIpdsECzXfj8klywBc06y0kt62w53 pRrw== X-Gm-Message-State: AOAM530Fw3c5V+nAjPsLaCkjiaydKd8WbPV4jCkl8Z5wsdaYgOpy7pHH 7cTToMzKt9nnnsmx5dh8ng== X-Google-Smtp-Source: ABdhPJzJOkvgxA1BTZ4PAi4OWpI9cFABggjmNMgJcaQ7V8JKyLgCLbuj+pSyPTNZmoVNLJoo924bRQ== X-Received: by 2002:a02:90cb:: with SMTP id c11mr6480022jag.53.1627598389390; Thu, 29 Jul 2021 15:39:49 -0700 (PDT) Received: from robh.at.kernel.org ([64.188.179.248]) by smtp.gmail.com with ESMTPSA id w14sm3078200ioa.47.2021.07.29.15.39.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 29 Jul 2021 15:39:48 -0700 (PDT) Received: (nullmailer pid 1035245 invoked by uid 1000); Thu, 29 Jul 2021 22:39:47 -0000 Date: Thu, 29 Jul 2021 16:39:47 -0600 From: Rob Herring To: Guenter Roeck Cc: Samuel Holland , Wim Van Sebroeck , Maxime Ripard , Chen-Yu Tsai , Jernej Skrabec , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-watchdog@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/3] dt-bindings: watchdog: sunxi: Add compatible for D1 Message-ID: References: <20210726035143.53132-1-samuel@sholland.org> <20210726035143.53132-2-samuel@sholland.org> <20210729042449.GA1716994@roeck-us.net> Precedence: bulk X-Mailing-List: linux-sunxi@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210729042449.GA1716994@roeck-us.net> On Wed, Jul 28, 2021 at 09:24:49PM -0700, Guenter Roeck wrote: > On Sun, Jul 25, 2021 at 10:51:42PM -0500, Samuel Holland wrote: > > D1 keeps the same register layout and clock sources as the R329, but it > > adds a key field which must be set to update the watchdog's "CFG" and > > "MODE" registers. Therefore it is not backward-compatible. > > > > Signed-off-by: Samuel Holland > > --- > > .../devicetree/bindings/watchdog/allwinner,sun4i-a10-wdt.yaml | 2 ++ > > 1 file changed, 2 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/watchdog/allwinner,sun4i-a10-wdt.yaml b/Documentation/devicetree/bindings/watchdog/allwinner,sun4i-a10-wdt.yaml > > index 853ceb1b7c0f..756e6ab99860 100644 > > --- a/Documentation/devicetree/bindings/watchdog/allwinner,sun4i-a10-wdt.yaml > > +++ b/Documentation/devicetree/bindings/watchdog/allwinner,sun4i-a10-wdt.yaml > > @@ -29,6 +29,7 @@ properties: > > - items: > > - const: allwinner,suniv-f1c100s-wdt > > - const: allwinner,sun4i-a10-wdt > > + - const: allwinner,sun20i-d1-wdt > > Alignment is off. No, it's correct. It's not part of the above list, but a new 'oneOf' entry. Rob From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 42FCDC4338F for ; Thu, 29 Jul 2021 22:41:53 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0C01F604D7 for ; Thu, 29 Jul 2021 22:41:53 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 0C01F604D7 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=ibkUtlE2oas3YV0Z+qL/YSj/peP8d/d5z3dAA4VMHqA=; b=t1P3ODqVZf6sGH GUKdKV76yqCjuNObL/UvIw7z48ADsTUHCqvRGibHHoTQxaYt/sBjLJgih0yk7Xj75486CzvF0FR5u s3xtNklnO+d6ViH29E+TOSJYYVTPMNhu/mEiQoWTOk8OzDWwwFgyyxJ/mXVqRYHC5xBV62jfNhDNS nZ7jwg9UpfLWrgxbvFywhGWDZ8F4dY+AsSPli67pdzDrRx1zl7ikfqe50oWSoY1pdK5StHdRK4J4P PmPzMPPRIjoL9hz8JVBAg4CIFkGbzn3ZSljd6WugxBzcdKGha9VV/mIKyj3TUVQtEPZuAnwL2M+uC Jrd83BH9kNT+ScIo17BA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1m9Eh0-006EpP-U5; Thu, 29 Jul 2021 22:39:55 +0000 Received: from mail-io1-f44.google.com ([209.85.166.44]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1m9Egw-006Eod-DN for linux-arm-kernel@lists.infradead.org; Thu, 29 Jul 2021 22:39:51 +0000 Received: by mail-io1-f44.google.com with SMTP id l18so9088098ioh.11 for ; Thu, 29 Jul 2021 15:39:50 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=XlptD/tZIHvjx581AafuTapU2M/nw56BX9ZwEjQcLOM=; b=RklQQ758vhzI3NVG/7ZTRxUtN64Xetu7zuCwfr4BI7ADSJWgueBJeOonxG0tjZzs9T t83KrfCxyZzq5dMZA+B5eaBLlW/saZwpXN/bacwIIQra82+NhfCArHknESjvtzZo93uS GTL9b6QuKdGcHL+qBescRMdo6CzbZnSK10wPb+ITkbAeX92AhNP0zSFkTk8aDtmTrV2O UhdCGmNB1twlGOmTFCehdmTIXKOdTyOluvKLnZvXuANkvbD3K/AMqfPTH0Ny6dYgztcI 8zSgb6QZ5YTvY/t7ZwHknOrpsr0OIlwQp/pk8Lp6UgvHzPFBKs05rwZ/fDP4FzX/oHwA s3Ig== X-Gm-Message-State: AOAM530+ilpAfSOa4miuaEizGniYjfbSGvE8LCDW5qwVT7JgxJrflGGj /auow7wH4eE/vsc9E0ZfPA== X-Google-Smtp-Source: ABdhPJzJOkvgxA1BTZ4PAi4OWpI9cFABggjmNMgJcaQ7V8JKyLgCLbuj+pSyPTNZmoVNLJoo924bRQ== X-Received: by 2002:a02:90cb:: with SMTP id c11mr6480022jag.53.1627598389390; Thu, 29 Jul 2021 15:39:49 -0700 (PDT) Received: from robh.at.kernel.org ([64.188.179.248]) by smtp.gmail.com with ESMTPSA id w14sm3078200ioa.47.2021.07.29.15.39.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 29 Jul 2021 15:39:48 -0700 (PDT) Received: (nullmailer pid 1035245 invoked by uid 1000); Thu, 29 Jul 2021 22:39:47 -0000 Date: Thu, 29 Jul 2021 16:39:47 -0600 From: Rob Herring To: Guenter Roeck Cc: Samuel Holland , Wim Van Sebroeck , Maxime Ripard , Chen-Yu Tsai , Jernej Skrabec , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-watchdog@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/3] dt-bindings: watchdog: sunxi: Add compatible for D1 Message-ID: References: <20210726035143.53132-1-samuel@sholland.org> <20210726035143.53132-2-samuel@sholland.org> <20210729042449.GA1716994@roeck-us.net> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210729042449.GA1716994@roeck-us.net> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210729_153950_498133_89591D4C X-CRM114-Status: GOOD ( 19.23 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Jul 28, 2021 at 09:24:49PM -0700, Guenter Roeck wrote: > On Sun, Jul 25, 2021 at 10:51:42PM -0500, Samuel Holland wrote: > > D1 keeps the same register layout and clock sources as the R329, but it > > adds a key field which must be set to update the watchdog's "CFG" and > > "MODE" registers. Therefore it is not backward-compatible. > > > > Signed-off-by: Samuel Holland > > --- > > .../devicetree/bindings/watchdog/allwinner,sun4i-a10-wdt.yaml | 2 ++ > > 1 file changed, 2 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/watchdog/allwinner,sun4i-a10-wdt.yaml b/Documentation/devicetree/bindings/watchdog/allwinner,sun4i-a10-wdt.yaml > > index 853ceb1b7c0f..756e6ab99860 100644 > > --- a/Documentation/devicetree/bindings/watchdog/allwinner,sun4i-a10-wdt.yaml > > +++ b/Documentation/devicetree/bindings/watchdog/allwinner,sun4i-a10-wdt.yaml > > @@ -29,6 +29,7 @@ properties: > > - items: > > - const: allwinner,suniv-f1c100s-wdt > > - const: allwinner,sun4i-a10-wdt > > + - const: allwinner,sun20i-d1-wdt > > Alignment is off. No, it's correct. It's not part of the above list, but a new 'oneOf' entry. Rob _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel