From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9BD97C4338F for ; Fri, 30 Jul 2021 18:00:49 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 83D1C60F4B for ; Fri, 30 Jul 2021 18:00:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230383AbhG3SAx (ORCPT ); Fri, 30 Jul 2021 14:00:53 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40714 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230312AbhG3SAx (ORCPT ); Fri, 30 Jul 2021 14:00:53 -0400 Received: from mail-ot1-x335.google.com (mail-ot1-x335.google.com [IPv6:2607:f8b0:4864:20::335]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2EB88C0613C1 for ; Fri, 30 Jul 2021 11:00:48 -0700 (PDT) Received: by mail-ot1-x335.google.com with SMTP id 19-20020a9d08930000b02904b98d90c82cso10409843otf.5 for ; Fri, 30 Jul 2021 11:00:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=wKcp94SXlzIL+rKCJfhPFUl8LwJ46IN+eIJM4QxPZ7Y=; b=EIHXCA0v5HstLP8hONQu8hfyiem8F2OPnEU12vCIXh/sEG7ViYP2/eNlFr4qce/DvY opBMGdlt5DgiSconUiX4fUNfVtnhFxxMOeOtk0D16LIjqHr3WAjtOBtXaPpk7qlHlZvy Zl7NKWloBgA6t0FMJK4jJTMo4Q5KycaUkVVsNqPi5VsysqdtP3UEroZANW3nEVYgWb0v EEVcZ5k+y11FysJUAJJLjiP68P0SNdVYMm2note2FhgLoUDg0TH4mihG8Z+NDW6GiyKP 7m2kbVSWI0zKYntLcB+qREW5oqPt1wdQKHthhZ0cdvMiJs8gjEQI59q1so2vyNrsofRP Zy3g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=wKcp94SXlzIL+rKCJfhPFUl8LwJ46IN+eIJM4QxPZ7Y=; b=psbDaXp9HEN5LDccxBwf0O1RLW54+UIb9Ost92NCYJC4fAMAw6olBgQuEQgdUcBDxO nt94wnOU+VPTSvCV5zfbK+Z8tswdk/eyI+YF8Nk3VZJoZNsoF7biBUFeod2bNQuo72au EYp5BPRwUiuyoiNFlOHglrDdPTCZ0f581NKixE6RJeBr4Aersl2HNxkizrvnBC9htFBl yIQxC+X4ojikSCqw6keVwp5L7DAbRo/oHzx9IUDJxHAHOpOp3h6eHaIRbfNcxUc0N8Bu wLW41pliYSoZfAd5iWmqfJ3ynyb+glDuWhOWFRfVAp5krr5Y4jV2a+AQ9QwI1zunSEcO /Zmw== X-Gm-Message-State: AOAM531nEX6fZ7ugAJLt4mmaaiNamxsB/Kj1du5WOG8sVoK3ykj5HwzC 5zt2/6xITsgFfP3N14JytG8wMA== X-Google-Smtp-Source: ABdhPJyXm3/c/DZWJx3M2wBcbj3susmf4EJpEeDHUy1dhDVv4ayHUWMRlCgXopkCSWt+HrWBQd08cg== X-Received: by 2002:a05:6830:114f:: with SMTP id x15mr2924468otq.356.1627668047529; Fri, 30 Jul 2021 11:00:47 -0700 (PDT) Received: from builder.lan (104-57-184-186.lightspeed.austtx.sbcglobal.net. [104.57.184.186]) by smtp.gmail.com with ESMTPSA id b16sm402742otl.59.2021.07.30.11.00.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 30 Jul 2021 11:00:46 -0700 (PDT) Date: Fri, 30 Jul 2021 13:00:44 -0500 From: Bjorn Andersson To: Sibi Sankar Cc: robh+dt@kernel.org, will@kernel.org, saiprakash.ranjan@codeaurora.org, ohad@wizery.com, agross@kernel.org, mathieu.poirier@linaro.org, robin.murphy@arm.com, joro@8bytes.org, p.zabel@pengutronix.de, linux-arm-msm@vger.kernel.org, linux-remoteproc@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, evgreen@chromium.org, dianders@chromium.org, swboyd@chromium.org Subject: Re: [PATCH 7/9] arm64: dts: qcom: sc7280: Add nodes to boot modem Message-ID: References: <1624564058-24095-1-git-send-email-sibis@codeaurora.org> <1624564058-24095-8-git-send-email-sibis@codeaurora.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1624564058-24095-8-git-send-email-sibis@codeaurora.org> Precedence: bulk List-ID: X-Mailing-List: linux-remoteproc@vger.kernel.org On Thu 24 Jun 14:47 CDT 2021, Sibi Sankar wrote: > Add miscellaneous nodes to boot the modem and support post-mortem debug > on SC7280 SoCs. > > Signed-off-by: Sibi Sankar > --- > arch/arm64/boot/dts/qcom/sc7280.dtsi | 20 ++++++++++++++++++++ > 1 file changed, 20 insertions(+) > > diff --git a/arch/arm64/boot/dts/qcom/sc7280.dtsi b/arch/arm64/boot/dts/qcom/sc7280.dtsi > index 5ed7a511bfc9..3fb6a6ef39f8 100644 > --- a/arch/arm64/boot/dts/qcom/sc7280.dtsi > +++ b/arch/arm64/boot/dts/qcom/sc7280.dtsi > @@ -547,6 +547,11 @@ > #hwlock-cells = <1>; > }; > > + tcsr_regs: syscon@1fc0000 { Is there a different "tcsr"? Does the "_regs" suffix add any value? > + compatible = "syscon"; Rob has pointed out a few times that a lone "syscon" isn't going to be accepted going forward. Could you also add a qualifying "qcom,sc7280-tcsr" or something like that? > + reg = <0 0x01fc0000 0 0x30000>; > + }; > + > lpasscc: lpasscc@3000000 { > compatible = "qcom,sc7280-lpasscc"; > reg = <0 0x03000000 0 0x40>, > @@ -1219,6 +1224,21 @@ > }; > }; > > + imem@146aa000 { > + compatible = "syscon", "simple-mfd"; As above "qcom,sc7280-imem"? I presume we need some new binding documents for these two though, perhaps you can add the specific compatibles and we agree that one of us will write these two bindings soon? Regards, Bjorn > + reg = <0 0x146aa000 0 0x2000>; > + > + #address-cells = <2>; > + #size-cells = <2>; > + > + ranges = <0 0x0 0 0x146aa000 0 0x2000>; > + > + pil-reloc@94c { > + compatible = "qcom,pil-reloc-info"; > + reg = <0 0x94c 0 0xc8>; > + }; > + }; > + > apps_smmu: iommu@15000000 { > compatible = "qcom,sc7280-smmu-500", "arm,mmu-500"; > reg = <0 0x15000000 0 0x100000>; > -- > The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, > a Linux Foundation Collaborative Project > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6DB4AC4338F for ; Fri, 30 Jul 2021 18:03:30 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3998D60F94 for ; Fri, 30 Jul 2021 18:03:30 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 3998D60F94 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=p1StelfPLUzrv/+pp/V8S5iyeigLNUlD+JI4Cj9umTk=; b=tGcOIrxUANZ3YZ pDEizsZH1ohnRZkyHGvbc1xDdNnkcxfM9WnaFvxiL67WlVMr5LriEHGrlItX3hateaChBd6JN1w+u bHSw/FL/po5RoH/3Lr6C+KHbD/wm5wM2r4N8ETzugkMsirnMNSzJWYSwBdc/X3xuRBvHZVndiDp2P oxyU0UKOuEvlmkOiMA3csq1hyj3Dx70R+R+NYCULNxVmwecYa+u0+wIKfBkPCtFxQ1E4oUldWByyJ xvbFd7+YwtKxp19aDPXGYD1V7SUjm1hS2Gqyoh6dNi5PvxAFLhxh390Pharsx473K1m0DpefEEf/Y oULpCOrcBkHJzmFBJ30g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1m9Woo-009p9D-Nu; Fri, 30 Jul 2021 18:01:11 +0000 Received: from mail-ot1-x331.google.com ([2607:f8b0:4864:20::331]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1m9WoS-009oyg-NC for linux-arm-kernel@lists.infradead.org; Fri, 30 Jul 2021 18:00:50 +0000 Received: by mail-ot1-x331.google.com with SMTP id h63-20020a9d14450000b02904ce97efee36so10384243oth.7 for ; Fri, 30 Jul 2021 11:00:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=wKcp94SXlzIL+rKCJfhPFUl8LwJ46IN+eIJM4QxPZ7Y=; b=EIHXCA0v5HstLP8hONQu8hfyiem8F2OPnEU12vCIXh/sEG7ViYP2/eNlFr4qce/DvY opBMGdlt5DgiSconUiX4fUNfVtnhFxxMOeOtk0D16LIjqHr3WAjtOBtXaPpk7qlHlZvy Zl7NKWloBgA6t0FMJK4jJTMo4Q5KycaUkVVsNqPi5VsysqdtP3UEroZANW3nEVYgWb0v EEVcZ5k+y11FysJUAJJLjiP68P0SNdVYMm2note2FhgLoUDg0TH4mihG8Z+NDW6GiyKP 7m2kbVSWI0zKYntLcB+qREW5oqPt1wdQKHthhZ0cdvMiJs8gjEQI59q1so2vyNrsofRP Zy3g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=wKcp94SXlzIL+rKCJfhPFUl8LwJ46IN+eIJM4QxPZ7Y=; b=rAfAeTdWm22i9vIbLRA0/f9imdn5rtTKlbz3Gk4JidUr0WitI6l1X4vwS4YX9BHi/g R46uS53Zm/Qd3twY+/SX9pDuwGsbCtb4Ij0863vM42KF8ho4bo2gf6Vg5B2WKgm0I0X0 CbfeK0fY7M1MkggCmTUsmJ2iAfbqTNIdcsVNwGqAr6fE7wNmexSzkT4/q4qU7fZ46X8b +lNPVoqNXZZpRqKy+/aTPxqMeXHdwLw1Ipj972FeZpVWARyfHXhcFEiqpgjdZEa5XBPF M/Fir60p97YyfvbU43FWoz9AMvdIlyivZtYMmo6dLaup1yv5OI+Y+SyzmhNrr9bER9Ar ygLg== X-Gm-Message-State: AOAM5333yVRNrWkcAZ+uC2wQk4PotzxP2qG4mUuYKYGg3BTL+VARz2eC /cqq0z+l3diyH/oCIJL9n/6oFw== X-Google-Smtp-Source: ABdhPJyXm3/c/DZWJx3M2wBcbj3susmf4EJpEeDHUy1dhDVv4ayHUWMRlCgXopkCSWt+HrWBQd08cg== X-Received: by 2002:a05:6830:114f:: with SMTP id x15mr2924468otq.356.1627668047529; Fri, 30 Jul 2021 11:00:47 -0700 (PDT) Received: from builder.lan (104-57-184-186.lightspeed.austtx.sbcglobal.net. [104.57.184.186]) by smtp.gmail.com with ESMTPSA id b16sm402742otl.59.2021.07.30.11.00.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 30 Jul 2021 11:00:46 -0700 (PDT) Date: Fri, 30 Jul 2021 13:00:44 -0500 From: Bjorn Andersson To: Sibi Sankar Cc: robh+dt@kernel.org, will@kernel.org, saiprakash.ranjan@codeaurora.org, ohad@wizery.com, agross@kernel.org, mathieu.poirier@linaro.org, robin.murphy@arm.com, joro@8bytes.org, p.zabel@pengutronix.de, linux-arm-msm@vger.kernel.org, linux-remoteproc@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, evgreen@chromium.org, dianders@chromium.org, swboyd@chromium.org Subject: Re: [PATCH 7/9] arm64: dts: qcom: sc7280: Add nodes to boot modem Message-ID: References: <1624564058-24095-1-git-send-email-sibis@codeaurora.org> <1624564058-24095-8-git-send-email-sibis@codeaurora.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1624564058-24095-8-git-send-email-sibis@codeaurora.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210730_110048_859160_7CFF638F X-CRM114-Status: GOOD ( 20.84 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu 24 Jun 14:47 CDT 2021, Sibi Sankar wrote: > Add miscellaneous nodes to boot the modem and support post-mortem debug > on SC7280 SoCs. > > Signed-off-by: Sibi Sankar > --- > arch/arm64/boot/dts/qcom/sc7280.dtsi | 20 ++++++++++++++++++++ > 1 file changed, 20 insertions(+) > > diff --git a/arch/arm64/boot/dts/qcom/sc7280.dtsi b/arch/arm64/boot/dts/qcom/sc7280.dtsi > index 5ed7a511bfc9..3fb6a6ef39f8 100644 > --- a/arch/arm64/boot/dts/qcom/sc7280.dtsi > +++ b/arch/arm64/boot/dts/qcom/sc7280.dtsi > @@ -547,6 +547,11 @@ > #hwlock-cells = <1>; > }; > > + tcsr_regs: syscon@1fc0000 { Is there a different "tcsr"? Does the "_regs" suffix add any value? > + compatible = "syscon"; Rob has pointed out a few times that a lone "syscon" isn't going to be accepted going forward. Could you also add a qualifying "qcom,sc7280-tcsr" or something like that? > + reg = <0 0x01fc0000 0 0x30000>; > + }; > + > lpasscc: lpasscc@3000000 { > compatible = "qcom,sc7280-lpasscc"; > reg = <0 0x03000000 0 0x40>, > @@ -1219,6 +1224,21 @@ > }; > }; > > + imem@146aa000 { > + compatible = "syscon", "simple-mfd"; As above "qcom,sc7280-imem"? I presume we need some new binding documents for these two though, perhaps you can add the specific compatibles and we agree that one of us will write these two bindings soon? Regards, Bjorn > + reg = <0 0x146aa000 0 0x2000>; > + > + #address-cells = <2>; > + #size-cells = <2>; > + > + ranges = <0 0x0 0 0x146aa000 0 0x2000>; > + > + pil-reloc@94c { > + compatible = "qcom,pil-reloc-info"; > + reg = <0 0x94c 0 0xc8>; > + }; > + }; > + > apps_smmu: iommu@15000000 { > compatible = "qcom,sc7280-smmu-500", "arm,mmu-500"; > reg = <0 0x15000000 0 0x100000>; > -- > The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, > a Linux Foundation Collaborative Project > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel