From: "Sassen, Rutger" <rsassen@comecer.com>
To: Arnout Vandecappelle <arnout@mind.be>,
"buildroot@buildroot.org" <buildroot@buildroot.org>
Cc: Peter Seiderer <ps.report@gmx.net>,
Martin Bark <martin@barkynet.com>,
Mahyar Koshkouei <mahyar.koshkouei@gmail.com>
Subject: Re: [Buildroot] [External] Re: [PATCH v3 1/1] package/rpi-firmware: fix missing files in overlays
Date: Tue, 22 Mar 2022 08:16:49 +0000 [thread overview]
Message-ID: <YQXPR01MB6121253D5991F7A70EEB49E3AE179@YQXPR01MB6121.CANPRD01.PROD.OUTLOOK.COM> (raw)
In-Reply-To: <c2c49834-638c-dbfe-bbba-7bcbe153a660@mind.be>
[-- Attachment #1.1: Type: text/plain, Size: 1788 bytes --]
Hi Arnout,
> > When supporting multiple hardware targets, overlay_map.dtb might
> > be needed to map overlay names to one of several implementations.
> >
> > Signed-off-by: Rutger Sassen <mailto:rsassen@comecer.com>
> > ---
> > package/rpi-firmware/Config.in | 12 ++++++++++++
> > package/rpi-firmware/rpi-firmware.mk | 7 +++++++
> > 2 files changed, 19 insertions(+)
> >
> > diff --git a/package/rpi-firmware/Config.in b/package/rpi-firmware/Config.in
> > index 8070dc3019..36054353f8 100644
> > --- a/package/rpi-firmware/Config.in
> > +++ b/package/rpi-firmware/Config.in
> > @@ -93,6 +93,18 @@ config BR2_PACKAGE_RPI_FIRMWARE_INSTALL_DTB_OVERLAYS
> > overlays, to support HATs (Hardware Attached on Top, add-on
> > modules).
> >
> > +if BR2_PACKAGE_RPI_FIRMWARE_INSTALL_DTB_OVERLAYS
> > +
> > +config BR2_PACKAGE_RPI_FIRMWARE_INSTALL_DTB_OVERLAY_MAP
>
> In the end, I don't think this option is very useful. So I removed it...
...
> ... reducing the patch to just this single line.
Almost back to the first iteration of my patch, where overlay_map.dtb and README were copied unconditionally 😉
> Please check if the commit [1] does what you need, if not I can recover the
> original patch with the http://Config.in option.
I've checked, and it works for me. Thanks.
> Applied to master, thanks.
>
> Regards,
> Arnout
>
> [1]
> https://git.buildroot.org/buildroot/commit/?id=da38cdead909aa133b9c468ddebf3f67c8d198f2
Regards,
Rutger
This email communication is CONFIDENTIAL. If you are not the intended recipient, you may not use, copy or disclose to anyone the message or any information contained in the message and I ask that you please notify me by return email and delete this communication immediately. Thank you.
[-- Attachment #1.2: Type: text/html, Size: 2574 bytes --]
[-- Attachment #2: Type: text/plain, Size: 150 bytes --]
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
next prev parent reply other threads:[~2022-03-22 8:17 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-17 11:06 [Buildroot] [PATCH v3 1/1] package/rpi-firmware: fix missing files in overlays Sassen, Rutger
2022-03-17 18:03 ` Peter Seiderer
2022-03-17 19:02 ` Bartosz Bilas
2022-03-21 21:56 ` Arnout Vandecappelle
2022-03-22 8:16 ` Sassen, Rutger [this message]
2022-03-23 19:35 ` Peter Seiderer
2022-03-23 19:49 ` Peter Seiderer
2022-03-23 20:06 ` Arnout Vandecappelle
2022-03-23 21:40 ` Peter Korsgaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YQXPR01MB6121253D5991F7A70EEB49E3AE179@YQXPR01MB6121.CANPRD01.PROD.OUTLOOK.COM \
--to=rsassen@comecer.com \
--cc=arnout@mind.be \
--cc=buildroot@buildroot.org \
--cc=mahyar.koshkouei@gmail.com \
--cc=martin@barkynet.com \
--cc=ps.report@gmx.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.