All of lore.kernel.org
 help / color / mirror / Atom feed
From: Eryu Guan <guan@eryu.me>
To: Josef Bacik <josef@toxicpanda.com>
Cc: fstests@vger.kernel.org, linux-btrfs@vger.kernel.org
Subject: Re: [PATCH] fstests: generic/204: fail if the mkfs fails
Date: Sun, 1 Aug 2021 20:53:36 +0800	[thread overview]
Message-ID: <YQaZUK880CRVf6Sn@desktop> (raw)
In-Reply-To: <YQaWmtw5/OoXm26Z@desktop>

On Sun, Aug 01, 2021 at 08:42:02PM +0800, Eryu Guan wrote:
> On Thu, Jul 29, 2021 at 04:35:53PM -0400, Josef Bacik wrote:
> > My nightly fstests runs on my Raspberry Pi got stuck trying to run
> > generic/204.  This boiled down to mkfs failing to make the scratch
> > device that small with the subpage blocksize support, and thus trying to
> > fill a 1tib drive with tiny files.  On one hand I'd like to make
> 
> So the underlying disk is 1TB in size, and we ended up using this 1T
> filesystem when _scratch_mkfs_sized failed?
> 
> But we have done _try_wipe_scratch_devs before each test to make sure we
> don't use previous scratch dev accidently (just like this case), and the
> subsesquent _scratch_mount will fail and fail the whole test. So it's
> not clear to me what caused the failure you hit.

Ah, if the previous test _notrun'd, then the scratch dev didn't get
wiped. I think patch "check: don't leave the scratch filesystem mounted
after _notrun" from Darrick should fix the bug for you. Would you please
confirm?

Thanks,
Eryu

  reply	other threads:[~2021-08-01 12:53 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-29 20:35 [PATCH] fstests: generic/204: fail if the mkfs fails Josef Bacik
2021-07-30  3:52 ` Theodore Ts'o
2021-08-01 12:42 ` Eryu Guan
2021-08-01 12:53   ` Eryu Guan [this message]
2021-08-01 15:57     ` Theodore Ts'o

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YQaZUK880CRVf6Sn@desktop \
    --to=guan@eryu.me \
    --cc=fstests@vger.kernel.org \
    --cc=josef@toxicpanda.com \
    --cc=linux-btrfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.