From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.0 required=3.0 tests=BAYES_00,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 62AF4C43214 for ; Mon, 2 Aug 2021 08:58:24 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 48C4C60EBD for ; Mon, 2 Aug 2021 08:58:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232897AbhHBI6c (ORCPT ); Mon, 2 Aug 2021 04:58:32 -0400 Received: from mail-wr1-f42.google.com ([209.85.221.42]:39899 "EHLO mail-wr1-f42.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232711AbhHBI6a (ORCPT ); Mon, 2 Aug 2021 04:58:30 -0400 Received: by mail-wr1-f42.google.com with SMTP id b11so15225179wrx.6; Mon, 02 Aug 2021 01:58:19 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=3w/K1BHHPdxnw4BgvCO49QjL9Du7QDixwLU5epoJCOs=; b=Wy6jb4B7sAb7Eg3ccboUFpNZ1vrE9l1oxNAzHRpv2I3xWimcrRyFOPNurFYv6xY2PE BhqI3wcqnXKHpU0cxVCSlPhqpm8vp5pPp5ADn+bdz2pYvv42l2SEq1M9/Yvx1c0M+sqg yKwupgsWKXwnr1KH4xf2cxty7UDSK40Ng18mtJ7/9s06Cm66g1RANUfGQ0USRp6JYrmL F1PVRWHSEAtQdNFDfPf1tiYAE0B9X5DHGbT5ViFmQYQkmnejWJTXQrXJ72hRyghWQVo4 +pPXh/vUTld7WnHjoYLp38oeOxDN48YVfrP+V/xrcnxALv80VJbCE1jhWWp1QtU3BI/Q x5MA== X-Gm-Message-State: AOAM532KvBeT3FxGJHYnduFWUWI9KptueDwNjX/SBqQulAG9/Kf6xWvm GSkL2OidxDljA3z8IvHRucw= X-Google-Smtp-Source: ABdhPJx0/tMXH15yaWP4fTnBDctEXhuDmohjGavsyW1cAWu4hdthkDNgpjt8Fdob5jAXYMN8mboFgA== X-Received: by 2002:adf:d194:: with SMTP id v20mr16017994wrc.126.1627894698889; Mon, 02 Aug 2021 01:58:18 -0700 (PDT) Received: from localhost ([149.172.45.165]) by smtp.gmail.com with ESMTPSA id l4sm3773280wrw.32.2021.08.02.01.58.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 02 Aug 2021 01:58:18 -0700 (PDT) Date: Mon, 2 Aug 2021 01:58:17 -0700 From: Moritz Fischer To: kajoljain Cc: will@kernel.org, hao.wu@intel.com, mark.rutland@arm.com, trix@redhat.com, yilun.xu@intel.com, mdf@kernel.org, linux-fpga@vger.kernel.org, maddy@linux.ibm.com, atrajeev@linux.vnet.ibm.com, linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, rnsastry@linux.ibm.com, linux-perf-users@vger.kernel.org, stable@vger.kernel.org Subject: Re: [PATCH v3] fpga: dfl: fme: Fix cpu hotplug issue in performance reporting Message-ID: References: <20210713074216.208391-1-kjain@linux.ibm.com> <61495dc0-f496-992c-1d2a-9229a04e6e44@linux.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <61495dc0-f496-992c-1d2a-9229a04e6e44@linux.ibm.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Aug 02, 2021 at 01:15:00PM +0530, kajoljain wrote: > > > On 7/13/21 1:12 PM, Kajol Jain wrote: > > The performance reporting driver added cpu hotplug > > feature but it didn't add pmu migration call in cpu > > offline function. > > This can create an issue incase the current designated > > cpu being used to collect fme pmu data got offline, > > as based on current code we are not migrating fme pmu to > > new target cpu. Because of that perf will still try to > > fetch data from that offline cpu and hence we will not > > get counter data. > > > > Patch fixed this issue by adding pmu_migrate_context call > > in fme_perf_offline_cpu function. > > > > Fixes: 724142f8c42a ("fpga: dfl: fme: add performance reporting support") > > Tested-by: Xu Yilun > > Acked-by: Wu Hao > > Signed-off-by: Kajol Jain > > Cc: stable@vger.kernel.org > > --- > > Any update on this patch? Please let me know if any changes required. > > Thanks, > Kajol Jain It's in my 'fixes' branch. - Moritz From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.0 required=3.0 tests=BAYES_00,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 31534C4338F for ; Mon, 2 Aug 2021 08:58:45 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id AC47760EBD for ; Mon, 2 Aug 2021 08:58:44 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org AC47760EBD Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.ozlabs.org Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4GdX3k5Y9Wz30Gg for ; Mon, 2 Aug 2021 18:58:42 +1000 (AEST) Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=gmail.com (client-ip=209.85.221.46; helo=mail-wr1-f46.google.com; envelope-from=moritz.fischer.private@gmail.com; receiver=) Received: from mail-wr1-f46.google.com (mail-wr1-f46.google.com [209.85.221.46]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4GdX3M22n6z2xv2 for ; Mon, 2 Aug 2021 18:58:22 +1000 (AEST) Received: by mail-wr1-f46.google.com with SMTP id z4so20580571wrv.11 for ; Mon, 02 Aug 2021 01:58:22 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=3w/K1BHHPdxnw4BgvCO49QjL9Du7QDixwLU5epoJCOs=; b=YSN4i65yaKWymLTLYCjT2zHIS8gonPQwOC5ZNK76Q0uWocBdtKTx1bp/wx2VmUzfjU QsdbvnNlz4DT8iT5329LSyja6Gpu82zcAAfOW1myWgDUJxnrX38WT8NQo+EOfpXEuTaX KkjuQ1cXFap8MYXy6kj3wpbhQIaEeJndCc1T4iklIypC6AYWJWm3knBhB1huwTrhYYqh V4vGHUuZ9U+pXltV94zRj0TNYpYzWlTKPOXOdji87rBzvyR8r0WhF1OqxdOh2JJoXU4f MePmRvQhU7qMizEeKSrPwcEswiHjEt+RokI3KMdhNB2ZkMZFGuh84KgkLEWWV/LOdUde vkWA== X-Gm-Message-State: AOAM533HzKyNjpaThYCyscJNFV745PLfDl5+ssE/boRBY/1CqXpHmvov fdieI9YQdDUeE7I7HOdBPf8= X-Google-Smtp-Source: ABdhPJx0/tMXH15yaWP4fTnBDctEXhuDmohjGavsyW1cAWu4hdthkDNgpjt8Fdob5jAXYMN8mboFgA== X-Received: by 2002:adf:d194:: with SMTP id v20mr16017994wrc.126.1627894698889; Mon, 02 Aug 2021 01:58:18 -0700 (PDT) Received: from localhost ([149.172.45.165]) by smtp.gmail.com with ESMTPSA id l4sm3773280wrw.32.2021.08.02.01.58.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 02 Aug 2021 01:58:18 -0700 (PDT) Date: Mon, 2 Aug 2021 01:58:17 -0700 From: Moritz Fischer To: kajoljain Subject: Re: [PATCH v3] fpga: dfl: fme: Fix cpu hotplug issue in performance reporting Message-ID: References: <20210713074216.208391-1-kjain@linux.ibm.com> <61495dc0-f496-992c-1d2a-9229a04e6e44@linux.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <61495dc0-f496-992c-1d2a-9229a04e6e44@linux.ibm.com> X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: mark.rutland@arm.com, maddy@linux.ibm.com, rnsastry@linux.ibm.com, trix@redhat.com, linux-fpga@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org, linux-perf-users@vger.kernel.org, atrajeev@linux.vnet.ibm.com, mdf@kernel.org, will@kernel.org, yilun.xu@intel.com, hao.wu@intel.com Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On Mon, Aug 02, 2021 at 01:15:00PM +0530, kajoljain wrote: > > > On 7/13/21 1:12 PM, Kajol Jain wrote: > > The performance reporting driver added cpu hotplug > > feature but it didn't add pmu migration call in cpu > > offline function. > > This can create an issue incase the current designated > > cpu being used to collect fme pmu data got offline, > > as based on current code we are not migrating fme pmu to > > new target cpu. Because of that perf will still try to > > fetch data from that offline cpu and hence we will not > > get counter data. > > > > Patch fixed this issue by adding pmu_migrate_context call > > in fme_perf_offline_cpu function. > > > > Fixes: 724142f8c42a ("fpga: dfl: fme: add performance reporting support") > > Tested-by: Xu Yilun > > Acked-by: Wu Hao > > Signed-off-by: Kajol Jain > > Cc: stable@vger.kernel.org > > --- > > Any update on this patch? Please let me know if any changes required. > > Thanks, > Kajol Jain It's in my 'fixes' branch. - Moritz