From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
	aws-us-west-2-korg-lkml-1.web.codeaurora.org
X-Spam-Level: 
X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00,
	HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS
	autolearn=no autolearn_force=no version=3.4.0
Received: from mail.kernel.org (mail.kernel.org [198.145.29.99])
	by smtp.lore.kernel.org (Postfix) with ESMTP id A787DC432BE
	for <linux-kernel@archiver.kernel.org>; Mon,  2 Aug 2021 13:38:39 +0000 (UTC)
Received: from vger.kernel.org (vger.kernel.org [23.128.96.18])
	by mail.kernel.org (Postfix) with ESMTP id 83A9C60F6D
	for <linux-kernel@archiver.kernel.org>; Mon,  2 Aug 2021 13:38:39 +0000 (UTC)
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S233974AbhHBNiq (ORCPT <rfc822;linux-kernel@archiver.kernel.org>);
        Mon, 2 Aug 2021 09:38:46 -0400
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36006 "EHLO
        lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S233859AbhHBNij (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Mon, 2 Aug 2021 09:38:39 -0400
Received: from theia.8bytes.org (8bytes.org [IPv6:2a01:238:4383:600:38bc:a715:4b6d:a889])
        by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9A2AFC06175F;
        Mon,  2 Aug 2021 06:38:29 -0700 (PDT)
Received: by theia.8bytes.org (Postfix, from userid 1000)
        id F3FFD379; Mon,  2 Aug 2021 15:38:26 +0200 (CEST)
Date:   Mon, 2 Aug 2021 15:38:16 +0200
From:   Joerg Roedel <joro@8bytes.org>
To:     Mingwei Zhang <mizhang@google.com>
Cc:     Paolo Bonzini <pbonzini@redhat.com>,
        Sean Christopherson <seanjc@google.com>,
        Vitaly Kuznetsov <vkuznets@redhat.com>,
        Wanpeng Li <wanpengli@tencent.com>,
        Jim Mattson <jmattson@google.com>, kvm@vger.kernel.org,
        linux-kernel@vger.kernel.org,
        Tom Lendacky <thomas.lendacky@amd.com>,
        Marc Orr <marcorr@google.com>,
        David Rientjes <rientjes@google.com>,
        Alper Gun <alpergun@google.com>,
        Dionna Glaze <dionnaglaze@google.com>,
        Vipin Sharma <vipinsh@google.com>
Subject: Re: [PATCH] KVM: SEV: improve the code readability for ASID
 management
Message-ID: <YQf1SDrEi8zl03Dv@8bytes.org>
References: <20210731011304.3868795-1-mizhang@google.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20210731011304.3868795-1-mizhang@google.com>
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, Jul 30, 2021 at 06:13:04PM -0700, Mingwei Zhang wrote:
> Fix the min_asid usage: ensure that its usage is consistent with its name;
> adjust its value before using it as a bitmap position. Add comments on ASID
> bitmap allocation to clarify the skipping-ASID-0 property.
> 
> Fixes: 80675b3ad45f (KVM: SVM: Update ASID allocation to support SEV-ES guests)

This looks more like an optimization to me, or does this fix any real
bug?