From: Joerg Roedel <joro@8bytes.org>
To: Tom Lendacky <thomas.lendacky@amd.com>
Cc: linux-kernel@vger.kernel.org, x86@kernel.org,
linuxppc-dev@lists.ozlabs.org, linux-s390@vger.kernel.org,
iommu@lists.linux-foundation.org, kvm@vger.kernel.org,
linux-efi@vger.kernel.org, platform-driver-x86@vger.kernel.org,
linux-graphics-maintainer@vmware.com,
amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
kexec@lists.infradead.org, linux-fsdevel@vger.kernel.org,
Borislav Petkov <bp@alien8.de>,
Brijesh Singh <brijesh.singh@amd.com>,
Andi Kleen <ak@linux.intel.com>,
Sathyanarayanan Kuppuswamy
<sathyanarayanan.kuppuswamy@linux.intel.com>,
Tianyu Lan <Tianyu.Lan@microsoft.com>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>
Subject: Re: [PATCH 06/11] x86/sev: Replace occurrences of sev_es_active() with prot_guest_has()
Date: Mon, 2 Aug 2021 12:45:23 +0200 [thread overview]
Message-ID: <YQfMw2FRO5M1osGF@8bytes.org> (raw)
In-Reply-To: <ba565128b88661a656fc3972f01bb2e295158a15.1627424774.git.thomas.lendacky@amd.com>
On Tue, Jul 27, 2021 at 05:26:09PM -0500, Tom Lendacky wrote:
> @@ -48,7 +47,7 @@ static void sme_sev_setup_real_mode(struct trampoline_header *th)
> if (prot_guest_has(PATTR_HOST_MEM_ENCRYPT))
> th->flags |= TH_FLAGS_SME_ACTIVE;
>
> - if (sev_es_active()) {
> + if (prot_guest_has(PATTR_GUEST_PROT_STATE)) {
> /*
> * Skip the call to verify_cpu() in secondary_startup_64 as it
> * will cause #VC exceptions when the AP can't handle them yet.
Not sure how TDX will handle AP booting, are you sure it needs this
special setup as well? Otherwise a check for SEV-ES would be better
instead of the generic PATTR_GUEST_PROT_STATE.
Regards,
Joerg
WARNING: multiple messages have this Message-ID (diff)
From: Joerg Roedel <joro@8bytes.org>
To: Tom Lendacky <thomas.lendacky@amd.com>
Cc: linux-s390@vger.kernel.org,
Sathyanarayanan Kuppuswamy
<sathyanarayanan.kuppuswamy@linux.intel.com>,
linux-efi@vger.kernel.org, Brijesh Singh <brijesh.singh@amd.com>,
kvm@vger.kernel.org, Tianyu Lan <Tianyu.Lan@microsoft.com>,
x86@kernel.org, kexec@lists.infradead.org,
linux-kernel@vger.kernel.org, amd-gfx@lists.freedesktop.org,
platform-driver-x86@vger.kernel.org,
iommu@lists.linux-foundation.org, Andi Kleen <ak@linux.intel.com>,
linux-graphics-maintainer@vmware.com,
dri-devel@lists.freedesktop.org, linux-fsdevel@vger.kernel.org,
Borislav Petkov <bp@alien8.de>,
Thomas Gleixner <tglx@linutronix.de>,
linuxppc-dev@lists.ozlabs.org, Ingo Molnar <mingo@redhat.com>
Subject: Re: [PATCH 06/11] x86/sev: Replace occurrences of sev_es_active() with prot_guest_has()
Date: Mon, 2 Aug 2021 12:45:23 +0200 [thread overview]
Message-ID: <YQfMw2FRO5M1osGF@8bytes.org> (raw)
In-Reply-To: <ba565128b88661a656fc3972f01bb2e295158a15.1627424774.git.thomas.lendacky@amd.com>
On Tue, Jul 27, 2021 at 05:26:09PM -0500, Tom Lendacky wrote:
> @@ -48,7 +47,7 @@ static void sme_sev_setup_real_mode(struct trampoline_header *th)
> if (prot_guest_has(PATTR_HOST_MEM_ENCRYPT))
> th->flags |= TH_FLAGS_SME_ACTIVE;
>
> - if (sev_es_active()) {
> + if (prot_guest_has(PATTR_GUEST_PROT_STATE)) {
> /*
> * Skip the call to verify_cpu() in secondary_startup_64 as it
> * will cause #VC exceptions when the AP can't handle them yet.
Not sure how TDX will handle AP booting, are you sure it needs this
special setup as well? Otherwise a check for SEV-ES would be better
instead of the generic PATTR_GUEST_PROT_STATE.
Regards,
Joerg
WARNING: multiple messages have this Message-ID (diff)
From: Joerg Roedel <joro@8bytes.org>
To: Tom Lendacky <thomas.lendacky@amd.com>
Cc: linux-s390@vger.kernel.org, linux-efi@vger.kernel.org,
Brijesh Singh <brijesh.singh@amd.com>,
kvm@vger.kernel.org, Tianyu Lan <Tianyu.Lan@microsoft.com>,
x86@kernel.org, kexec@lists.infradead.org,
linux-kernel@vger.kernel.org, amd-gfx@lists.freedesktop.org,
platform-driver-x86@vger.kernel.org,
iommu@lists.linux-foundation.org, Andi Kleen <ak@linux.intel.com>,
linux-graphics-maintainer@vmware.com,
dri-devel@lists.freedesktop.org, linux-fsdevel@vger.kernel.org,
Borislav Petkov <bp@alien8.de>,
Thomas Gleixner <tglx@linutronix.de>,
linuxppc-dev@lists.ozlabs.org, Ingo Molnar <mingo@redhat.com>
Subject: Re: [PATCH 06/11] x86/sev: Replace occurrences of sev_es_active() with prot_guest_has()
Date: Mon, 2 Aug 2021 12:45:23 +0200 [thread overview]
Message-ID: <YQfMw2FRO5M1osGF@8bytes.org> (raw)
In-Reply-To: <ba565128b88661a656fc3972f01bb2e295158a15.1627424774.git.thomas.lendacky@amd.com>
On Tue, Jul 27, 2021 at 05:26:09PM -0500, Tom Lendacky wrote:
> @@ -48,7 +47,7 @@ static void sme_sev_setup_real_mode(struct trampoline_header *th)
> if (prot_guest_has(PATTR_HOST_MEM_ENCRYPT))
> th->flags |= TH_FLAGS_SME_ACTIVE;
>
> - if (sev_es_active()) {
> + if (prot_guest_has(PATTR_GUEST_PROT_STATE)) {
> /*
> * Skip the call to verify_cpu() in secondary_startup_64 as it
> * will cause #VC exceptions when the AP can't handle them yet.
Not sure how TDX will handle AP booting, are you sure it needs this
special setup as well? Otherwise a check for SEV-ES would be better
instead of the generic PATTR_GUEST_PROT_STATE.
Regards,
Joerg
_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu
next prev parent reply other threads:[~2021-08-02 10:45 UTC|newest]
Thread overview: 214+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-27 22:26 [PATCH 00/11] Implement generic prot_guest_has() helper function Tom Lendacky
2021-07-27 22:26 ` Tom Lendacky
2021-07-27 22:26 ` Tom Lendacky
2021-07-27 22:26 ` Tom Lendacky
2021-07-27 22:26 ` Tom Lendacky via iommu
2021-07-27 22:26 ` Tom Lendacky
2021-07-27 22:26 ` [PATCH 01/11] mm: Introduce a function to check for virtualization protection features Tom Lendacky
2021-07-27 22:26 ` Tom Lendacky
2021-07-27 22:26 ` Tom Lendacky
2021-07-27 22:26 ` Tom Lendacky via iommu
2021-07-27 22:26 ` Tom Lendacky
2021-07-28 13:17 ` Christoph Hellwig
2021-07-28 13:17 ` Christoph Hellwig
2021-07-28 13:17 ` Christoph Hellwig
2021-07-28 13:17 ` Christoph Hellwig
2021-07-28 13:17 ` Christoph Hellwig
2021-07-28 16:28 ` Borislav Petkov
2021-07-28 16:28 ` Borislav Petkov
2021-07-28 16:28 ` Borislav Petkov
2021-07-28 16:28 ` Borislav Petkov
2021-07-28 16:28 ` Borislav Petkov
2021-08-02 10:34 ` Joerg Roedel
2021-08-02 10:34 ` Joerg Roedel
2021-08-02 10:34 ` Joerg Roedel
2021-08-02 10:34 ` Joerg Roedel
2021-08-11 14:53 ` Kuppuswamy, Sathyanarayanan
2021-08-11 14:53 ` Kuppuswamy, Sathyanarayanan
2021-08-11 14:53 ` Kuppuswamy, Sathyanarayanan
2021-08-11 14:53 ` Kuppuswamy, Sathyanarayanan
2021-08-11 14:53 ` Kuppuswamy, Sathyanarayanan
2021-08-11 15:39 ` Tom Lendacky
2021-08-11 15:39 ` Tom Lendacky
2021-08-11 15:39 ` Tom Lendacky
2021-08-11 15:39 ` Tom Lendacky via iommu
2021-08-11 15:39 ` Tom Lendacky
2021-07-27 22:26 ` [PATCH 02/11] x86/sev: Add an x86 version of prot_guest_has() Tom Lendacky
2021-07-27 22:26 ` Tom Lendacky
2021-07-27 22:26 ` Tom Lendacky
2021-07-27 22:26 ` Tom Lendacky via iommu
2021-07-27 22:26 ` Tom Lendacky
2021-07-28 13:22 ` Christoph Hellwig
2021-07-28 13:22 ` Christoph Hellwig
2021-07-28 13:22 ` Christoph Hellwig
2021-07-28 13:22 ` Christoph Hellwig
2021-07-28 13:22 ` Christoph Hellwig
2021-07-29 14:24 ` Tom Lendacky
2021-07-29 14:24 ` Tom Lendacky
2021-07-29 14:24 ` Tom Lendacky
2021-07-29 14:24 ` Tom Lendacky via iommu
2021-07-29 14:24 ` Tom Lendacky
2021-08-02 10:35 ` Joerg Roedel
2021-08-02 10:35 ` Joerg Roedel
2021-08-02 10:35 ` Joerg Roedel
2021-08-02 10:35 ` Joerg Roedel
2021-07-27 22:26 ` [PATCH 03/11] powerpc/pseries/svm: Add a powerpc " Tom Lendacky
2021-07-27 22:26 ` Tom Lendacky
2021-07-27 22:26 ` Tom Lendacky
2021-07-27 22:26 ` Tom Lendacky
2021-07-27 22:26 ` Tom Lendacky via iommu
2021-07-27 22:26 ` Tom Lendacky
2021-07-27 22:26 ` [PATCH 04/11] x86/sme: Replace occurrences of sme_active() with prot_guest_has() Tom Lendacky
2021-07-27 22:26 ` Tom Lendacky
2021-07-27 22:26 ` Tom Lendacky
2021-07-27 22:26 ` Tom Lendacky via iommu
2021-07-27 22:26 ` Tom Lendacky
2021-08-02 10:37 ` Joerg Roedel
2021-08-02 10:37 ` Joerg Roedel
2021-08-02 10:37 ` Joerg Roedel
2021-08-02 10:37 ` Joerg Roedel
2021-07-27 22:26 ` [PATCH 05/11] x86/sev: Replace occurrences of sev_active() " Tom Lendacky
2021-07-27 22:26 ` Tom Lendacky
2021-07-27 22:26 ` Tom Lendacky
2021-07-27 22:26 ` Tom Lendacky via iommu
2021-07-27 22:26 ` Tom Lendacky
2021-08-02 10:42 ` Joerg Roedel
2021-08-02 10:42 ` Joerg Roedel
2021-08-02 10:42 ` Joerg Roedel
2021-08-02 10:42 ` Joerg Roedel
2021-07-27 22:26 ` [PATCH 06/11] x86/sev: Replace occurrences of sev_es_active() " Tom Lendacky
2021-07-27 22:26 ` Tom Lendacky
2021-07-27 22:26 ` Tom Lendacky
2021-07-27 22:26 ` Tom Lendacky via iommu
2021-07-27 22:26 ` Tom Lendacky
2021-08-02 10:45 ` Joerg Roedel [this message]
2021-08-02 10:45 ` Joerg Roedel
2021-08-02 10:45 ` Joerg Roedel
2021-08-02 10:45 ` Joerg Roedel
2021-08-09 21:59 ` Tom Lendacky
2021-08-09 21:59 ` Tom Lendacky
2021-08-09 21:59 ` Tom Lendacky
2021-08-09 21:59 ` Tom Lendacky via iommu
2021-08-09 21:59 ` Tom Lendacky
2021-08-09 22:08 ` Kuppuswamy, Sathyanarayanan
2021-08-09 22:08 ` Kuppuswamy, Sathyanarayanan
2021-08-09 22:08 ` Kuppuswamy, Sathyanarayanan
2021-08-09 22:08 ` Kuppuswamy, Sathyanarayanan
2021-08-09 22:08 ` Kuppuswamy, Sathyanarayanan
2021-07-27 22:26 ` [PATCH 07/11] treewide: Replace the use of mem_encrypt_active() " Tom Lendacky
2021-07-27 22:26 ` Tom Lendacky
2021-07-27 22:26 ` Tom Lendacky
2021-07-27 22:26 ` Tom Lendacky
2021-07-27 22:26 ` Tom Lendacky via iommu
2021-07-27 22:26 ` Tom Lendacky
2021-07-30 22:34 ` Sean Christopherson
2021-07-30 22:34 ` Sean Christopherson
2021-07-30 22:34 ` Sean Christopherson
2021-07-30 22:34 ` Sean Christopherson via iommu
2021-07-30 22:34 ` Sean Christopherson
2021-08-09 21:55 ` Tom Lendacky
2021-08-09 21:55 ` Tom Lendacky
2021-08-09 21:55 ` Tom Lendacky
2021-08-09 21:55 ` Tom Lendacky via iommu
2021-08-09 21:55 ` Tom Lendacky
2021-08-02 12:42 ` Christophe Leroy
2021-08-02 12:42 ` Christophe Leroy
2021-08-02 12:42 ` Christophe Leroy
2021-08-02 12:42 ` Christophe Leroy
2021-08-02 12:42 ` Christophe Leroy
2021-08-09 22:04 ` Tom Lendacky
2021-08-09 22:04 ` Tom Lendacky
2021-08-09 22:04 ` Tom Lendacky
2021-08-09 22:04 ` Tom Lendacky via iommu
2021-08-09 22:04 ` Tom Lendacky
2021-08-10 18:45 ` Kuppuswamy, Sathyanarayanan
2021-08-10 18:45 ` Kuppuswamy, Sathyanarayanan
2021-08-10 18:45 ` Kuppuswamy, Sathyanarayanan
2021-08-10 18:45 ` Kuppuswamy, Sathyanarayanan
2021-08-10 18:45 ` Kuppuswamy, Sathyanarayanan
2021-08-10 19:48 ` Tom Lendacky
2021-08-10 19:48 ` Tom Lendacky
2021-08-10 19:48 ` Tom Lendacky
2021-08-10 19:48 ` Tom Lendacky via iommu
2021-08-10 19:48 ` Tom Lendacky
2021-08-10 20:09 ` Kuppuswamy, Sathyanarayanan
2021-08-10 20:09 ` Kuppuswamy, Sathyanarayanan
2021-08-10 20:09 ` Kuppuswamy, Sathyanarayanan
2021-08-10 20:09 ` Kuppuswamy, Sathyanarayanan
2021-08-10 20:09 ` Kuppuswamy, Sathyanarayanan
2021-08-11 12:19 ` Kirill A. Shutemov
2021-08-11 12:19 ` Kirill A. Shutemov
2021-08-11 12:19 ` Kirill A. Shutemov
2021-08-11 12:19 ` Kirill A. Shutemov
2021-08-11 12:19 ` Kirill A. Shutemov
2021-08-11 15:52 ` Tom Lendacky
2021-08-11 15:52 ` Tom Lendacky
2021-08-11 15:52 ` Tom Lendacky
2021-08-11 15:52 ` Tom Lendacky via iommu
2021-08-11 15:52 ` Tom Lendacky
2021-08-12 10:07 ` Kirill A. Shutemov
2021-08-12 10:07 ` Kirill A. Shutemov
2021-08-12 10:07 ` Kirill A. Shutemov
2021-08-12 10:07 ` Kirill A. Shutemov
2021-08-12 10:07 ` Kirill A. Shutemov
2021-08-13 17:08 ` Tom Lendacky
2021-08-13 17:08 ` Tom Lendacky
2021-08-13 17:08 ` Tom Lendacky
2021-08-13 17:08 ` Tom Lendacky via iommu
2021-08-13 17:08 ` Tom Lendacky
2021-08-13 20:17 ` Tom Lendacky
2021-08-13 20:17 ` Tom Lendacky
2021-08-13 20:17 ` Tom Lendacky
2021-08-13 20:17 ` Tom Lendacky via iommu
2021-08-13 20:17 ` Tom Lendacky
2021-07-27 22:26 ` [PATCH 08/11] mm: Remove the now unused mem_encrypt_active() function Tom Lendacky
2021-07-27 22:26 ` Tom Lendacky
2021-07-27 22:26 ` Tom Lendacky
2021-07-27 22:26 ` Tom Lendacky via iommu
2021-07-27 22:26 ` Tom Lendacky
2021-08-02 10:47 ` Joerg Roedel
2021-08-02 10:47 ` Joerg Roedel
2021-08-02 10:47 ` Joerg Roedel
2021-08-02 10:47 ` Joerg Roedel
2021-07-27 22:26 ` [PATCH 09/11] x86/sev: " Tom Lendacky
2021-07-27 22:26 ` Tom Lendacky
2021-07-27 22:26 ` Tom Lendacky
2021-07-27 22:26 ` Tom Lendacky via iommu
2021-07-27 22:26 ` Tom Lendacky
2021-08-02 10:46 ` Joerg Roedel
2021-08-02 10:46 ` Joerg Roedel
2021-08-02 10:46 ` Joerg Roedel
2021-08-02 10:46 ` Joerg Roedel
2021-07-27 22:26 ` [PATCH 10/11] powerpc/pseries/svm: " Tom Lendacky
2021-07-27 22:26 ` Tom Lendacky
2021-07-27 22:26 ` Tom Lendacky
2021-07-27 22:26 ` Tom Lendacky
2021-07-27 22:26 ` Tom Lendacky via iommu
2021-07-27 22:26 ` Tom Lendacky
2021-07-27 22:26 ` [PATCH 11/11] s390/mm: " Tom Lendacky
2021-07-27 22:26 ` Tom Lendacky
2021-07-27 22:26 ` Tom Lendacky
2021-07-27 22:26 ` Tom Lendacky via iommu
2021-07-27 22:26 ` Tom Lendacky
2021-07-27 22:37 ` [PATCH 00/11] Implement generic prot_guest_has() helper function Tom Lendacky
2021-07-27 22:37 ` Tom Lendacky
2021-07-27 22:37 ` Tom Lendacky
2021-07-27 22:37 ` Tom Lendacky
2021-07-27 22:37 ` Tom Lendacky via iommu
2021-07-27 22:37 ` Tom Lendacky
2021-07-28 11:50 ` Christian König
2021-07-28 11:50 ` Christian König
2021-07-28 11:50 ` Christian König
2021-07-28 11:50 ` Christian König
2021-07-28 11:50 ` Christian König
2021-07-28 11:50 ` Christian König
2021-08-09 1:41 ` Kuppuswamy, Sathyanarayanan
2021-08-09 1:41 ` Kuppuswamy, Sathyanarayanan
2021-08-09 1:41 ` Kuppuswamy, Sathyanarayanan
2021-08-09 1:41 ` Kuppuswamy, Sathyanarayanan
2021-08-09 1:41 ` Kuppuswamy, Sathyanarayanan
2021-08-09 22:16 ` Tom Lendacky
2021-08-09 22:16 ` Tom Lendacky
2021-08-09 22:16 ` Tom Lendacky
2021-08-09 22:16 ` Tom Lendacky via iommu
2021-08-09 22:16 ` Tom Lendacky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YQfMw2FRO5M1osGF@8bytes.org \
--to=joro@8bytes.org \
--cc=Tianyu.Lan@microsoft.com \
--cc=ak@linux.intel.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=bp@alien8.de \
--cc=brijesh.singh@amd.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=iommu@lists.linux-foundation.org \
--cc=kexec@lists.infradead.org \
--cc=kvm@vger.kernel.org \
--cc=linux-efi@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-graphics-maintainer@vmware.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mingo@redhat.com \
--cc=platform-driver-x86@vger.kernel.org \
--cc=sathyanarayanan.kuppuswamy@linux.intel.com \
--cc=tglx@linutronix.de \
--cc=thomas.lendacky@amd.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.