From: Joerg Roedel <joro@8bytes.org>
To: Luigi Rizzo <lrizzo@google.com>
Cc: Will Deacon <will@kernel.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
David Rientjes <rientjes@google.com>,
Luigi Rizzo <rizzo.unipi@gmail.com>,
Suravee Suthikulpanit <suravee.suthikulpanit@amd.com>
Subject: Re: [PATCH] amd/iommu: fix logic bug in amd_iommu_report_page_fault()
Date: Mon, 2 Aug 2021 16:38:52 +0200 [thread overview]
Message-ID: <YQgDfIcFW5h9TH+n@8bytes.org> (raw)
In-Reply-To: <CAMOZA0LEr+xM6RrsJErPMqHP7-0GdLmNDqbGVKbKTn92=Ncejg@mail.gmail.com>
On Mon, Aug 02, 2021 at 04:30:50PM +0200, Luigi Rizzo wrote:
> Ah didn't realize that. Thank you!
>
> Two questions on the topic:
> 1. how comes only the AMD driver is so verbose in reporting io page faults?
> Neither intel nor other iommu drivers seem to log anything
What do you mean by 'verbose'? It is only a line per fault, and at least
the Intel driver also logs DMAR faults with one line per fault :)
> 2. Would it make sense to have a control to disable such logging,
> either per-device or globally? Eg something like this (negative
> logic so it must be set explicitly to disable logging).
Yes, we can talk about that. But only after the trace-event for it
landed in the code. There must be some way to report the faults and if
userspace prefers to catch them via trace-events than we can disable
printing them to the kernel log.
Regards,
Joerg
next prev parent reply other threads:[~2021-08-02 14:39 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-31 19:26 [PATCH] amd/iommu: fix logic bug in amd_iommu_report_page_fault() Luigi Rizzo
2021-08-02 3:52 ` David Rientjes
2021-08-02 14:13 ` Joerg Roedel
2021-08-02 14:30 ` Luigi Rizzo
2021-08-02 14:38 ` Joerg Roedel [this message]
2021-08-02 15:26 ` Luigi Rizzo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YQgDfIcFW5h9TH+n@8bytes.org \
--to=joro@8bytes.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lrizzo@google.com \
--cc=rientjes@google.com \
--cc=rizzo.unipi@gmail.com \
--cc=suravee.suthikulpanit@amd.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.