All of lore.kernel.org
 help / color / mirror / Atom feed
From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: John Garry <john.garry@huawei.com>
Cc: peterz@infradead.org, mingo@redhat.com, mark.rutland@arm.com,
	alexander.shishkin@linux.intel.com, jolsa@redhat.com,
	namhyung@kernel.org, yao.jin@linux.intel.com,
	linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org,
	irogers@google.com, linuxarm@huawei.com
Subject: Re: [PATCH 02/11] perf jevents: Relocate test events to cpu folder
Date: Mon, 2 Aug 2021 11:54:42 -0300	[thread overview]
Message-ID: <YQgHMt4BsDeJnE09@kernel.org> (raw)
In-Reply-To: <1627566986-30605-3-git-send-email-john.garry@huawei.com>

Em Thu, Jul 29, 2021 at 09:56:17PM +0800, John Garry escreveu:
> In future to add support for sys events, relocate the core and uncore
> events to a cpu folder.
> 
> Signed-off-by: John Garry <john.garry@huawei.com>
> ---
>  .../pmu-events/arch/test/{test_cpu => test_soc/cpu}/branch.json | 0
>  .../pmu-events/arch/test/{test_cpu => test_soc/cpu}/cache.json  | 0
>  .../pmu-events/arch/test/{test_cpu => test_soc/cpu}/other.json  | 0
>  .../pmu-events/arch/test/{test_cpu => test_soc/cpu}/uncore.json | 0
>  tools/perf/pmu-events/jevents.c                                 | 2 +-
>  5 files changed, 1 insertion(+), 1 deletion(-)
>  rename tools/perf/pmu-events/arch/test/{test_cpu => test_soc/cpu}/branch.json (100%)
>  rename tools/perf/pmu-events/arch/test/{test_cpu => test_soc/cpu}/cache.json (100%)
>  rename tools/perf/pmu-events/arch/test/{test_cpu => test_soc/cpu}/other.json (100%)
>  rename tools/perf/pmu-events/arch/test/{test_cpu => test_soc/cpu}/uncore.json (100%)
> 
> diff --git a/tools/perf/pmu-events/arch/test/test_cpu/branch.json b/tools/perf/pmu-events/arch/test/test_soc/cpu/branch.json
> similarity index 100%
> rename from tools/perf/pmu-events/arch/test/test_cpu/branch.json
> rename to tools/perf/pmu-events/arch/test/test_soc/cpu/branch.json
> diff --git a/tools/perf/pmu-events/arch/test/test_cpu/cache.json b/tools/perf/pmu-events/arch/test/test_soc/cpu/cache.json
> similarity index 100%
> rename from tools/perf/pmu-events/arch/test/test_cpu/cache.json
> rename to tools/perf/pmu-events/arch/test/test_soc/cpu/cache.json
> diff --git a/tools/perf/pmu-events/arch/test/test_cpu/other.json b/tools/perf/pmu-events/arch/test/test_soc/cpu/other.json
> similarity index 100%
> rename from tools/perf/pmu-events/arch/test/test_cpu/other.json
> rename to tools/perf/pmu-events/arch/test/test_soc/cpu/other.json
> diff --git a/tools/perf/pmu-events/arch/test/test_cpu/uncore.json b/tools/perf/pmu-events/arch/test/test_soc/cpu/uncore.json
> similarity index 100%
> rename from tools/perf/pmu-events/arch/test/test_cpu/uncore.json
> rename to tools/perf/pmu-events/arch/test/test_soc/cpu/uncore.json
> diff --git a/tools/perf/pmu-events/jevents.c b/tools/perf/pmu-events/jevents.c
> index 9604446f8360..405bdd36b9b9 100644
> --- a/tools/perf/pmu-events/jevents.c
> +++ b/tools/perf/pmu-events/jevents.c
> @@ -814,7 +814,7 @@ static void print_mapping_test_table(FILE *outfp)
>  	fprintf(outfp, "\t.cpuid = \"testcpu\",\n");
>  	fprintf(outfp, "\t.version = \"v1\",\n");
>  	fprintf(outfp, "\t.type = \"core\",\n");
> -	fprintf(outfp, "\t.table = pme_test_cpu,\n");
> +	fprintf(outfp, "\t.table = pme_test_soc_cpu,\n");

Humm, is this already generated by some script? I.e. this
'pme_test_soc_cpu' table? Or does this works only when applying the full
patchset?

- Arnaldo

>  	fprintf(outfp, "},\n");
>  }
>  
> -- 
> 2.26.2
> 

-- 

- Arnaldo

  reply	other threads:[~2021-08-02 14:54 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-29 13:56 [PATCH 00/11] perf test: Improve pmu-events support John Garry
2021-07-29 13:56 ` [PATCH 01/11] perf test: Factor out pmu-events event comparison John Garry
2021-07-29 13:56 ` [PATCH 02/11] perf jevents: Relocate test events to cpu folder John Garry
2021-08-02 14:54   ` Arnaldo Carvalho de Melo [this message]
2021-08-02 15:02     ` John Garry
2021-08-03  8:19     ` John Garry
2021-08-09 15:46       ` John Garry
2021-08-10 14:01         ` Arnaldo Carvalho de Melo
2021-08-10 14:23           ` John Garry
2021-08-10 14:34             ` Arnaldo Carvalho de Melo
2021-08-10 17:58             ` Arnaldo Carvalho de Melo
2021-08-11  7:59               ` John Garry
2021-08-11 18:38                 ` Arnaldo Carvalho de Melo
2021-07-29 13:56 ` [PATCH 03/11] perf test: Declare pmu-events test events separately John Garry
2021-07-29 13:56 ` [PATCH 04/11] perf test: Factor out pmu-events alias comparison John Garry
2021-07-29 13:56 ` [PATCH 05/11] perf test: Test pmu-events core aliases separately John Garry
2021-07-29 13:56 ` [PATCH 06/11] perf pmu: Check .is_uncore field in pmu_add_cpu_aliases_map() John Garry
2021-07-29 13:56 ` [PATCH 07/11] perf test: Re-add pmu-event uncore PMU alias test John Garry
2021-07-29 13:56 ` [PATCH 08/11] perf test: Add more pmu-events uncore aliases John Garry
2021-07-29 13:56 ` [PATCH 09/11] perf pmu: Make pmu_add_sys_aliases() public John Garry
2021-07-29 13:56 ` [PATCH 10/11] perf jevents: Print SoC name per system event table John Garry
2021-07-29 13:56 ` [PATCH 11/11] perf test: Add pmu-events sys event support John Garry

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YQgHMt4BsDeJnE09@kernel.org \
    --to=acme@kernel.org \
    --cc=alexander.shishkin@linux.intel.com \
    --cc=irogers@google.com \
    --cc=john.garry@huawei.com \
    --cc=jolsa@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-perf-users@vger.kernel.org \
    --cc=linuxarm@huawei.com \
    --cc=mark.rutland@arm.com \
    --cc=mingo@redhat.com \
    --cc=namhyung@kernel.org \
    --cc=peterz@infradead.org \
    --cc=yao.jin@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.