All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ilias Apalodimas <ilias.apalodimas@linaro.org>
To: Simon Glass <sjg@chromium.org>
Cc: U-Boot Mailing List <u-boot@lists.denx.de>,
	Heinrich Schuchardt <xypron.glpk@gmx.de>,
	KASHI Takahiro <takahiro.akashi@linaro.org>,
	Alexander Graf <agraf@csgraf.de>,
	Masami Hiramatsu <masami.hiramatsu@linaro.org>,
	Sughosh Ganu <sughosh.ganu@linaro.org>
Subject: Re: [PATCH v2 0/3] efi: Minimal revert to rodata change
Date: Mon, 2 Aug 2021 18:37:35 +0300	[thread overview]
Message-ID: <YQgRP2VX0OhQwQsv@enceladus> (raw)
In-Reply-To: <20210802144431.2396678-1-sjg@chromium.org>

Hi Simon,

On Mon, Aug 02, 2021 at 08:44:28AM -0600, Simon Glass wrote:
> The changes to move from devicetree to rodata take things in the wrong
> direction for various reasons:
> 

As I said on the previous thread, I think this should remain as is for a
number of reasons (and mainly because it only works with 1/3 valid
CONFIG_OF_XXX U-Boot provides), but I'll let Heinrich decide.

> - devicetree is where config should be stored
> - it provides no memory production in any case, particularly when U-Boot
>   is relocated
> - testing becomes harder, with the suggestion of adding an entire new
>   sandbox build just for this
> 
> Revert this until a new direction can be established.
> 

Regards
/Ilias
> Changes in v2:
> - Also revert two other patches, based on comment from Takahiro
> 
> Simon Glass (3):
>   Revert "doc: Update CapsuleUpdate READMEs"
>   Revert "mkeficapsule: Remove dtb related options"
>   Revert "efi_capsule: Move signature from DTB to .rodata"
> 
>  board/emulation/common/Makefile             |   1 +
>  board/emulation/common/qemu_capsule.c       |  43 ++++
>  doc/board/emulation/qemu_capsule_update.rst | 203 +++++++++++++++++
>  doc/develop/uefi/uefi.rst                   | 125 -----------
>  include/asm-generic/sections.h              |   2 -
>  lib/efi_loader/Kconfig                      |   7 -
>  lib/efi_loader/Makefile                     |   8 -
>  lib/efi_loader/efi_capsule.c                |  18 +-
>  lib/efi_loader/efi_capsule_key.S            |  17 --
>  tools/mkeficapsule.c                        | 229 +++++++++++++++++++-
>  10 files changed, 472 insertions(+), 181 deletions(-)
>  create mode 100644 board/emulation/common/qemu_capsule.c
>  create mode 100644 doc/board/emulation/qemu_capsule_update.rst
>  delete mode 100644 lib/efi_loader/efi_capsule_key.S
> 
> -- 
> 2.32.0.554.ge1b32706d8-goog
> 

  parent reply	other threads:[~2021-08-02 15:37 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-02 14:44 [PATCH v2 0/3] efi: Minimal revert to rodata change Simon Glass
2021-08-02 14:44 ` [PATCH v2 1/3] Revert "doc: Update CapsuleUpdate READMEs" Simon Glass
2021-08-02 14:44 ` [PATCH v2 2/3] Revert "mkeficapsule: Remove dtb related options" Simon Glass
2021-08-03  5:29   ` KASHI Takahiro
2021-08-04 16:08     ` Simon Glass
2021-08-02 14:44 ` [PATCH v2 3/3] Revert "efi_capsule: Move signature from DTB to .rodata" Simon Glass
2021-08-02 15:37 ` Ilias Apalodimas [this message]
2021-08-02 20:02   ` [PATCH v2 0/3] efi: Minimal revert to rodata change Simon Glass
2021-08-03  5:43     ` Ilias Apalodimas
2021-08-03 15:27       ` Simon Glass
2021-08-02 17:30 ` Heinrich Schuchardt
2021-08-02 19:22   ` Simon Glass
2021-08-03  5:46     ` [PATCH v2 0/3] efi: Minimal revert to rodata change\ Ilias Apalodimas
2021-08-03 15:27       ` Simon Glass
2021-08-05 15:24 ` [PATCH v2 0/3] efi: Minimal revert to rodata change Heinrich Schuchardt
2021-08-05 15:46   ` Simon Glass
2021-08-06  0:13     ` KASHI Takahiro
2021-08-06  0:33       ` Simon Glass
2021-08-09 16:01     ` Tom Rini
2021-08-13 12:37       ` Tom Rini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YQgRP2VX0OhQwQsv@enceladus \
    --to=ilias.apalodimas@linaro.org \
    --cc=agraf@csgraf.de \
    --cc=masami.hiramatsu@linaro.org \
    --cc=sjg@chromium.org \
    --cc=sughosh.ganu@linaro.org \
    --cc=takahiro.akashi@linaro.org \
    --cc=u-boot@lists.denx.de \
    --cc=xypron.glpk@gmx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.