From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5EAA8C4338F for ; Mon, 2 Aug 2021 17:59:21 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3B1176101D for ; Mon, 2 Aug 2021 17:59:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230086AbhHBR73 (ORCPT ); Mon, 2 Aug 2021 13:59:29 -0400 Received: from mail.kernel.org ([198.145.29.99]:46458 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229567AbhHBR72 (ORCPT ); Mon, 2 Aug 2021 13:59:28 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id CDEB360243; Mon, 2 Aug 2021 17:59:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1627927159; bh=f+dnO3iDFBJhoP3js15szCurvm9jJkhKj5KcO5eUtjU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=usnb03wJNcMmJoQSWj/2UEECYBjYNOifXNJ+MEWrkctCaImDVTelbsDe+jJPdRiGa +rgbYOfmnxC/KJHlV/Vi+tLbIj4nn/bfWe9r5tni70vEPeG8wOzLXUeI6Dj+M4HNFl Jak8pVesjhQcDXWcm+/WzOPo8vKzJVJfu5r8An0YJ1iG9OaNdFKePlNJ/bmruYqqkz 0PuFKbmGLZ+JG4gkRcBsw2+SufsdqUKR3HmADlgurxg67uy8jgGNRECfF5VQT9piOL n6yApl7OptqfZaHFEUjsTQZtJ82xOf/37E0V4uqU7dAfpkdc6Qas5SySijKN5qd8av kqUXvKoWpQsxQ== Date: Mon, 2 Aug 2021 10:59:17 -0700 From: Jaegeuk Kim To: Chao Yu Cc: Yangtao Li , linux-kernel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net Subject: Re: [f2fs-dev] [PATCH] f2fs: reset free segment to prefree status when do_checkpoint() fail Message-ID: References: <20210427082106.2755-1-frank.li@vivo.com> <12ae52df-bc5e-82c3-4f78-1eafe7723f93@huawei.com> <5f37995c-2390-e8ca-d002-3639ad39e0d3@kernel.org> <8d2e3a63-72f9-bcb2-24e5-dddd84136001@kernel.org> <355ac2ff-f1f1-b9ea-bd8c-139cb24a03fb@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <355ac2ff-f1f1-b9ea-bd8c-139cb24a03fb@kernel.org> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 08/01, Chao Yu wrote: > On 2021/7/31 6:18, Jaegeuk Kim wrote: > > On 07/20, Chao Yu wrote: > > > On 2021/7/20 2:25, Jaegeuk Kim wrote: > > > > On 07/19, Chao Yu wrote: > > > > > On 2021/4/27 20:37, Chao Yu wrote: > > > > > > I think just reverting dirty/free bitmap is not enough if checkpoint fails, > > > > > > due to we have updated sbi->cur_cp_pack and nat/sit bitmap, next CP tries > > > > > > to overwrite last valid meta/node/data, then filesystem will be corrupted. > > > > > > > > > > > > So I suggest to set cp_error if do_checkpoint() fails until we can handle > > > > > > all cases, which is not so easy. > > > > > > > > > > > > How do you think? > > > > > > > > > > Let's add below patch first before you figure out the patch which covers all > > > > > things. > > > > > > > > > > From 3af957c98e9e04259f8bb93ca0b74ba164f3f27e Mon Sep 17 00:00:00 2001 > > > > > From: Chao Yu > > > > > Date: Mon, 19 Jul 2021 16:37:44 +0800 > > > > > Subject: [PATCH] f2fs: fix to stop filesystem update once CP failed > > > > > > > > > > During f2fs_write_checkpoint(), once we failed in > > > > > f2fs_flush_nat_entries() or do_checkpoint(), metadata of filesystem > > > > > such as prefree bitmap, nat/sit version bitmap won't be recovered, > > > > > it may cause f2fs image to be inconsistent, let's just set CP error > > > > > flag to avoid further updates until we figure out a scheme to rollback > > > > > all metadatas in such condition. > > > > > > > > > > Reported-by: Yangtao Li > > > > > Signed-off-by: Yangtao Li > > > > > Signed-off-by: Chao Yu > > > > > --- > > > > > fs/f2fs/checkpoint.c | 10 +++++++--- > > > > > 1 file changed, 7 insertions(+), 3 deletions(-) > > > > > > > > > > diff --git a/fs/f2fs/checkpoint.c b/fs/f2fs/checkpoint.c > > > > > index 6c208108d69c..096c85022f62 100644 > > > > > --- a/fs/f2fs/checkpoint.c > > > > > +++ b/fs/f2fs/checkpoint.c > > > > > @@ -1639,8 +1639,10 @@ int f2fs_write_checkpoint(struct f2fs_sb_info *sbi, struct cp_control *cpc) > > > > > > > > > > /* write cached NAT/SIT entries to NAT/SIT area */ > > > > > err = f2fs_flush_nat_entries(sbi, cpc); > > > > > - if (err) > > > > > + if (err) { > > > > > + f2fs_stop_checkpoint(sbi, false); > > > > > > > > I think we should abuse this, since we can get any known ENOMEM as well. > > > > > > Yup, but one critical issue here is it can break A/B update of NAT area, > > > so, in order to fix this hole, how about using NOFAIL memory allocation > > > in f2fs_flush_nat_entries() first until we figure out the finial scheme? > > > > NOFAIL is risky, so how about adding a retry logic on ENOMEM with a message > > and then giving up if we can't get the memory? BTW, what about EIO or other > > family? > > How about this? Hmm, it seems we won't get ENOMEM. __flush_nat_entry_set -> get_next_nat_page -> ... -> __get_meta_page -> repeat on ENOMEM, but stop_checkpoint on EIO If we have an error here, we should have stopped checkpoint. Have you seen other issue? > > From ffb50d9a8220be7d9e159b8555533adcf11957a8 Mon Sep 17 00:00:00 2001 > From: Chao Yu > Date: Mon, 19 Jul 2021 16:37:44 +0800 > Subject: [PATCH v2] f2fs: fix to stop filesystem update once CP failed > > During f2fs_write_checkpoint(), once we failed in > f2fs_flush_nat_entries() or do_checkpoint(), metadata of filesystem > such as prefree bitmap, nat/sit version bitmap won't be recovered, > it may cause f2fs image to be inconsistent, let's just set CP error > flag to avoid further updates until we figure out a scheme to rollback > all metadatas in such condition. > > Reported-by: Yangtao Li > Signed-off-by: Yangtao Li > Signed-off-by: Chao Yu > --- > fs/f2fs/checkpoint.c | 12 +++++++++--- > fs/f2fs/node.c | 9 ++++++++- > 2 files changed, 17 insertions(+), 4 deletions(-) > > diff --git a/fs/f2fs/checkpoint.c b/fs/f2fs/checkpoint.c > index 6c208108d69c..f3f66871ae42 100644 > --- a/fs/f2fs/checkpoint.c > +++ b/fs/f2fs/checkpoint.c > @@ -1639,8 +1639,11 @@ int f2fs_write_checkpoint(struct f2fs_sb_info *sbi, struct cp_control *cpc) > > /* write cached NAT/SIT entries to NAT/SIT area */ > err = f2fs_flush_nat_entries(sbi, cpc); > - if (err) > + if (err) { > + f2fs_err(sbi, "f2fs_flush_nat_entries failed err:%d, stop checkpoint", err); > + f2fs_stop_checkpoint(sbi, false); > goto stop; > + } > > f2fs_flush_sit_entries(sbi, cpc); > > @@ -1648,10 +1651,13 @@ int f2fs_write_checkpoint(struct f2fs_sb_info *sbi, struct cp_control *cpc) > f2fs_save_inmem_curseg(sbi); > > err = do_checkpoint(sbi, cpc); > - if (err) > + if (err) { > + f2fs_err(sbi, "do_checkpoint failed err:%d, stop checkpoint", err); > + f2fs_stop_checkpoint(sbi, false); > f2fs_release_discard_addrs(sbi); > - else > + } else { > f2fs_clear_prefree_segments(sbi, cpc); > + } > > f2fs_restore_inmem_curseg(sbi); > stop: > diff --git a/fs/f2fs/node.c b/fs/f2fs/node.c > index 5840b82ce311..7162836d71c1 100644 > --- a/fs/f2fs/node.c > +++ b/fs/f2fs/node.c > @@ -141,13 +141,20 @@ static struct page *get_next_nat_page(struct f2fs_sb_info *sbi, nid_t nid) > void *src_addr; > void *dst_addr; > struct f2fs_nm_info *nm_i = NM_I(sbi); > + bool retried = false; > > dst_off = next_nat_addr(sbi, current_nat_addr(sbi, nid)); > > +retry: > /* get current nat block page with lock */ > src_page = get_current_nat_page(sbi, nid); > - if (IS_ERR(src_page)) > + if (IS_ERR(src_page)) { > + if (PTR_ERR(src_page) == -ENOMEM && !retried) { > + retried = true; > + goto retry; > + } > return src_page; > + } > dst_page = f2fs_grab_meta_page(sbi, dst_off); > f2fs_bug_on(sbi, PageDirty(src_page)); > > -- > 2.22.1 > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 70A59C4338F for ; Mon, 2 Aug 2021 17:59:30 +0000 (UTC) Received: from lists.sourceforge.net (lists.sourceforge.net [216.105.38.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2C09160F36 for ; Mon, 2 Aug 2021 17:59:30 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 2C09160F36 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.sourceforge.net Received: from [127.0.0.1] (helo=sfs-ml-1.v29.lw.sourceforge.com) by sfs-ml-1.v29.lw.sourceforge.com with esmtp (Exim 4.90_1) (envelope-from ) id 1mAcDn-0007Zu-PK; Mon, 02 Aug 2021 17:59:27 +0000 Received: from [172.30.20.202] (helo=mx.sourceforge.net) by sfs-ml-1.v29.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mAcDl-0007ZY-Q1 for linux-f2fs-devel@lists.sourceforge.net; Mon, 02 Aug 2021 17:59:25 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=In-Reply-To:Content-Type:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=gsu8jQIBQr7L9TPnARHE/kcU28p+IsBXt9IKRJ0K6Sg=; b=HuaSAQIPTcLM3kE+Byb+kbzrw/ //ql7fJpGE0dYMGxHMNv3BoyCcVAYwCMOzzwZMMJqOYDXcyyR6zkoX7nvG98rYlpGIulyzUbD+aow XkxOPxjF5uX0Uyqxgqd+xUmCPE7hubZxKGKux9D3oKVCtHQN/406xC2Ke0PBUSGF6Am4=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To :From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=gsu8jQIBQr7L9TPnARHE/kcU28p+IsBXt9IKRJ0K6Sg=; b=P3U75Yp/ysMuUBJDxByip946d3 0ycaKcBUJ9FC5iM6Em/31XbciXjFV932Zf54a9mXXZNn3k58qBs9M/HjyAt9WIoLIQAHrAahULnvm nWm3v4XOXKNQKZHDYYZQ77EOtkSDel73mUC1ssKCs6K/dOvFMrDuQr6FY35826h5Y8OI=; Received: from mail.kernel.org ([198.145.29.99]) by sfi-mx-1.v28.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.92.3) id 1mAcDk-00ASVQ-C0 for linux-f2fs-devel@lists.sourceforge.net; Mon, 02 Aug 2021 17:59:25 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id CDEB360243; Mon, 2 Aug 2021 17:59:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1627927159; bh=f+dnO3iDFBJhoP3js15szCurvm9jJkhKj5KcO5eUtjU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=usnb03wJNcMmJoQSWj/2UEECYBjYNOifXNJ+MEWrkctCaImDVTelbsDe+jJPdRiGa +rgbYOfmnxC/KJHlV/Vi+tLbIj4nn/bfWe9r5tni70vEPeG8wOzLXUeI6Dj+M4HNFl Jak8pVesjhQcDXWcm+/WzOPo8vKzJVJfu5r8An0YJ1iG9OaNdFKePlNJ/bmruYqqkz 0PuFKbmGLZ+JG4gkRcBsw2+SufsdqUKR3HmADlgurxg67uy8jgGNRECfF5VQT9piOL n6yApl7OptqfZaHFEUjsTQZtJ82xOf/37E0V4uqU7dAfpkdc6Qas5SySijKN5qd8av kqUXvKoWpQsxQ== Date: Mon, 2 Aug 2021 10:59:17 -0700 From: Jaegeuk Kim To: Chao Yu Message-ID: References: <20210427082106.2755-1-frank.li@vivo.com> <12ae52df-bc5e-82c3-4f78-1eafe7723f93@huawei.com> <5f37995c-2390-e8ca-d002-3639ad39e0d3@kernel.org> <8d2e3a63-72f9-bcb2-24e5-dddd84136001@kernel.org> <355ac2ff-f1f1-b9ea-bd8c-139cb24a03fb@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <355ac2ff-f1f1-b9ea-bd8c-139cb24a03fb@kernel.org> X-Headers-End: 1mAcDk-00ASVQ-C0 Subject: Re: [f2fs-dev] [PATCH] f2fs: reset free segment to prefree status when do_checkpoint() fail X-BeenThere: linux-f2fs-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-f2fs-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org, Yangtao Li Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: linux-f2fs-devel-bounces@lists.sourceforge.net On 08/01, Chao Yu wrote: > On 2021/7/31 6:18, Jaegeuk Kim wrote: > > On 07/20, Chao Yu wrote: > > > On 2021/7/20 2:25, Jaegeuk Kim wrote: > > > > On 07/19, Chao Yu wrote: > > > > > On 2021/4/27 20:37, Chao Yu wrote: > > > > > > I think just reverting dirty/free bitmap is not enough if checkpoint fails, > > > > > > due to we have updated sbi->cur_cp_pack and nat/sit bitmap, next CP tries > > > > > > to overwrite last valid meta/node/data, then filesystem will be corrupted. > > > > > > > > > > > > So I suggest to set cp_error if do_checkpoint() fails until we can handle > > > > > > all cases, which is not so easy. > > > > > > > > > > > > How do you think? > > > > > > > > > > Let's add below patch first before you figure out the patch which covers all > > > > > things. > > > > > > > > > > From 3af957c98e9e04259f8bb93ca0b74ba164f3f27e Mon Sep 17 00:00:00 2001 > > > > > From: Chao Yu > > > > > Date: Mon, 19 Jul 2021 16:37:44 +0800 > > > > > Subject: [PATCH] f2fs: fix to stop filesystem update once CP failed > > > > > > > > > > During f2fs_write_checkpoint(), once we failed in > > > > > f2fs_flush_nat_entries() or do_checkpoint(), metadata of filesystem > > > > > such as prefree bitmap, nat/sit version bitmap won't be recovered, > > > > > it may cause f2fs image to be inconsistent, let's just set CP error > > > > > flag to avoid further updates until we figure out a scheme to rollback > > > > > all metadatas in such condition. > > > > > > > > > > Reported-by: Yangtao Li > > > > > Signed-off-by: Yangtao Li > > > > > Signed-off-by: Chao Yu > > > > > --- > > > > > fs/f2fs/checkpoint.c | 10 +++++++--- > > > > > 1 file changed, 7 insertions(+), 3 deletions(-) > > > > > > > > > > diff --git a/fs/f2fs/checkpoint.c b/fs/f2fs/checkpoint.c > > > > > index 6c208108d69c..096c85022f62 100644 > > > > > --- a/fs/f2fs/checkpoint.c > > > > > +++ b/fs/f2fs/checkpoint.c > > > > > @@ -1639,8 +1639,10 @@ int f2fs_write_checkpoint(struct f2fs_sb_info *sbi, struct cp_control *cpc) > > > > > > > > > > /* write cached NAT/SIT entries to NAT/SIT area */ > > > > > err = f2fs_flush_nat_entries(sbi, cpc); > > > > > - if (err) > > > > > + if (err) { > > > > > + f2fs_stop_checkpoint(sbi, false); > > > > > > > > I think we should abuse this, since we can get any known ENOMEM as well. > > > > > > Yup, but one critical issue here is it can break A/B update of NAT area, > > > so, in order to fix this hole, how about using NOFAIL memory allocation > > > in f2fs_flush_nat_entries() first until we figure out the finial scheme? > > > > NOFAIL is risky, so how about adding a retry logic on ENOMEM with a message > > and then giving up if we can't get the memory? BTW, what about EIO or other > > family? > > How about this? Hmm, it seems we won't get ENOMEM. __flush_nat_entry_set -> get_next_nat_page -> ... -> __get_meta_page -> repeat on ENOMEM, but stop_checkpoint on EIO If we have an error here, we should have stopped checkpoint. Have you seen other issue? > > From ffb50d9a8220be7d9e159b8555533adcf11957a8 Mon Sep 17 00:00:00 2001 > From: Chao Yu > Date: Mon, 19 Jul 2021 16:37:44 +0800 > Subject: [PATCH v2] f2fs: fix to stop filesystem update once CP failed > > During f2fs_write_checkpoint(), once we failed in > f2fs_flush_nat_entries() or do_checkpoint(), metadata of filesystem > such as prefree bitmap, nat/sit version bitmap won't be recovered, > it may cause f2fs image to be inconsistent, let's just set CP error > flag to avoid further updates until we figure out a scheme to rollback > all metadatas in such condition. > > Reported-by: Yangtao Li > Signed-off-by: Yangtao Li > Signed-off-by: Chao Yu > --- > fs/f2fs/checkpoint.c | 12 +++++++++--- > fs/f2fs/node.c | 9 ++++++++- > 2 files changed, 17 insertions(+), 4 deletions(-) > > diff --git a/fs/f2fs/checkpoint.c b/fs/f2fs/checkpoint.c > index 6c208108d69c..f3f66871ae42 100644 > --- a/fs/f2fs/checkpoint.c > +++ b/fs/f2fs/checkpoint.c > @@ -1639,8 +1639,11 @@ int f2fs_write_checkpoint(struct f2fs_sb_info *sbi, struct cp_control *cpc) > > /* write cached NAT/SIT entries to NAT/SIT area */ > err = f2fs_flush_nat_entries(sbi, cpc); > - if (err) > + if (err) { > + f2fs_err(sbi, "f2fs_flush_nat_entries failed err:%d, stop checkpoint", err); > + f2fs_stop_checkpoint(sbi, false); > goto stop; > + } > > f2fs_flush_sit_entries(sbi, cpc); > > @@ -1648,10 +1651,13 @@ int f2fs_write_checkpoint(struct f2fs_sb_info *sbi, struct cp_control *cpc) > f2fs_save_inmem_curseg(sbi); > > err = do_checkpoint(sbi, cpc); > - if (err) > + if (err) { > + f2fs_err(sbi, "do_checkpoint failed err:%d, stop checkpoint", err); > + f2fs_stop_checkpoint(sbi, false); > f2fs_release_discard_addrs(sbi); > - else > + } else { > f2fs_clear_prefree_segments(sbi, cpc); > + } > > f2fs_restore_inmem_curseg(sbi); > stop: > diff --git a/fs/f2fs/node.c b/fs/f2fs/node.c > index 5840b82ce311..7162836d71c1 100644 > --- a/fs/f2fs/node.c > +++ b/fs/f2fs/node.c > @@ -141,13 +141,20 @@ static struct page *get_next_nat_page(struct f2fs_sb_info *sbi, nid_t nid) > void *src_addr; > void *dst_addr; > struct f2fs_nm_info *nm_i = NM_I(sbi); > + bool retried = false; > > dst_off = next_nat_addr(sbi, current_nat_addr(sbi, nid)); > > +retry: > /* get current nat block page with lock */ > src_page = get_current_nat_page(sbi, nid); > - if (IS_ERR(src_page)) > + if (IS_ERR(src_page)) { > + if (PTR_ERR(src_page) == -ENOMEM && !retried) { > + retried = true; > + goto retry; > + } > return src_page; > + } > dst_page = f2fs_grab_meta_page(sbi, dst_off); > f2fs_bug_on(sbi, PageDirty(src_page)); > > -- > 2.22.1 > _______________________________________________ Linux-f2fs-devel mailing list Linux-f2fs-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel