From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E09ADC4338F for ; Wed, 4 Aug 2021 16:04:03 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 802B860E97 for ; Wed, 4 Aug 2021 16:04:03 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 802B860E97 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ravnborg.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 95B5C6E1D8; Wed, 4 Aug 2021 16:04:02 +0000 (UTC) Received: from mx1.smtp.larsendata.com (mx1.smtp.larsendata.com [91.221.196.215]) by gabe.freedesktop.org (Postfix) with ESMTPS id B05706E1D8 for ; Wed, 4 Aug 2021 16:03:59 +0000 (UTC) Received: from mail01.mxhotel.dk (mail01.mxhotel.dk [91.221.196.236]) by mx1.smtp.larsendata.com (Halon) with ESMTPS id 974b6047-f53d-11eb-9082-0050568c148b; Wed, 04 Aug 2021 16:04:04 +0000 (UTC) Received: from ravnborg.org (80-162-45-141-cable.dk.customer.tdc.net [80.162.45.141]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: sam@ravnborg.org) by mail01.mxhotel.dk (Postfix) with ESMTPSA id 84625194B87; Wed, 4 Aug 2021 18:04:22 +0200 (CEST) Date: Wed, 4 Aug 2021 18:03:54 +0200 X-Report-Abuse-To: abuse@mxhotel.dk From: Sam Ravnborg To: Shawn Guo Cc: Thierry Reding , Daniel Vetter , Rob Herring , dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org Subject: Re: [PATCH 1/2] dt-bindings: display: panel: Add Truly NT35521 panel support Message-ID: References: <20210804081352.30595-1-shawn.guo@linaro.org> <20210804081352.30595-2-shawn.guo@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210804081352.30595-2-shawn.guo@linaro.org> X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Hi Shawn, On Wed, Aug 04, 2021 at 04:13:51PM +0800, Shawn Guo wrote: > The Truly NT35521 is a 5.24" 1280x720 DSI panel, and the backlight is > managed through DSI link. > > Signed-off-by: Shawn Guo Please consider adding an optional port node, so we can use this panels in a setup using a graph. A simple port: true would do the trick. I am aware that it may not be used today, this is a preparation for potential future use. With this fixed, Reviewed-by: Sam Ravnborg Sam