From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D4993C4338F for ; Wed, 4 Aug 2021 18:35:25 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9B1D561002 for ; Wed, 4 Aug 2021 18:35:25 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 9B1D561002 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ravnborg.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=fheQWiNTdDyQ/nhg68klxLm7xPIUy10H8xQU4lAcTsc=; b=uY7Hvau5NFgeur bIQkmj0JSZxQsvLRmJLgvVpjKvSaVI1FFHoxY59wKfxm/kkEhaFIT29eI/bUO+yqIk7xfVBzSOPyw DyRvEL1XLyevCGaS3pCx7Tn8TJ1x5X60pFNtOsyjv6xU3PVJAU2U2fZ2Kynu0nhh++g9yn2lqxgMd vK5j8Vb8umjQZEY1m7hxNuz3h4cg1cRWtfOVd/F8y7FQyX1aLKDemXqYnZ5ZvjzVuoXcrROyMyNDh LDnqMgbCLm51H9dynH9Fay37NJ0F2VidosdGxq+rM0ue1e4rImkLJzgR+xIK6NvGD8Yt997R4r7sH 9ygn1JXrTjT8ITnr9PNg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mBLi6-007Aik-5y; Wed, 04 Aug 2021 18:33:46 +0000 Received: from mx2.smtp.larsendata.com ([91.221.196.228]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mBLi2-007AhV-5f for linux-arm-kernel@lists.infradead.org; Wed, 04 Aug 2021 18:33:43 +0000 Received: from mail01.mxhotel.dk (mail01.mxhotel.dk [91.221.196.236]) by mx2.smtp.larsendata.com (Halon) with ESMTPS id 8496dbbf-f552-11eb-8d1a-0050568cd888; Wed, 04 Aug 2021 18:33:52 +0000 (UTC) Received: from ravnborg.org (80-162-45-141-cable.dk.customer.tdc.net [80.162.45.141]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: sam@ravnborg.org) by mail01.mxhotel.dk (Postfix) with ESMTPSA id 365E9194B00; Wed, 4 Aug 2021 20:33:58 +0200 (CEST) Date: Wed, 4 Aug 2021 20:33:30 +0200 X-Report-Abuse-To: abuse@mxhotel.dk From: Sam Ravnborg To: Thomas Zimmermann Subject: Re: [PATCH v2 11/14] drm/tilcdc: Convert to Linux IRQ interfaces Message-ID: References: <20210803090704.32152-1-tzimmermann@suse.de> <20210803090704.32152-12-tzimmermann@suse.de> <896793e5-f5a8-fe74-1d8f-3dd1450d3fae@suse.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <896793e5-f5a8-fe74-1d8f-3dd1450d3fae@suse.de> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210804_113342_403511_C7D64F72 X-CRM114-Status: GOOD ( 23.52 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: airlied@linux.ie, tomi.valkeinen@ideasonboard.com, liviu.dudau@arm.com, stefan@agner.ch, amd-gfx@lists.freedesktop.org, anitha.chrisanthus@intel.com, Dan.Sneddon@microchip.com, patrik.r.jakobsson@gmail.com, linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org, daniel@ffwll.ch, edmund.j.dea@intel.com, s.hauer@pengutronix.de, alison.wang@nxp.com, maarten.lankhorst@linux.intel.com, mripard@kernel.org, dri-devel@lists.freedesktop.org, sean@poorly.run, linux-arm-kernel@lists.infradead.org, tomba@kernel.org, bbrezillon@kernel.org, jyri.sarha@iki.fi, christian.koenig@amd.com, robdclark@gmail.com, kernel@pengutronix.de, alexander.deucher@amd.com, shawnguo@kernel.org, brian.starkey@arm.com Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Thomas, On Wed, Aug 04, 2021 at 08:30:41PM +0200, Thomas Zimmermann wrote: > Hi > > Am 03.08.21 um 17:00 schrieb Sam Ravnborg: > > Hi Thomas, > > > > On Tue, Aug 03, 2021 at 11:07:01AM +0200, Thomas Zimmermann wrote: > > > Drop the DRM IRQ midlayer in favor of Linux IRQ interfaces. DRM's > > > IRQ helpers are mostly useful for UMS drivers. Modern KMS drivers > > > don't benefit from using it. > > > > > > DRM IRQ callbacks are now being called directly or inlined. > > > > > > Calls to platform_get_irq() can fail with a negative errno code. > > > Abort initialization in this case. The DRM IRQ midlayer does not > > > handle this case correctly. > > > > I cannot see why the irq_enabled flag is needed here, and the changelog > > do not help me. > > What do I miss? > > That's a good point. Usually, only the DRM IRQ helpers use irq_enabled in > struct drm_device. It'll become legacy and we can ignore it for the driver > conversion. > > The exception is tilcdc, which also uses irq_enabled to make its error > rollback work correctly. So I duplicated the state in the local private > structure. > > I'll add this explanation to the commit message. With this added: Acked-by: Sam Ravnborg _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4D073C432BE for ; Wed, 4 Aug 2021 18:33:41 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 136A061002 for ; Wed, 4 Aug 2021 18:33:41 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 136A061002 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ravnborg.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id ED235893EB; Wed, 4 Aug 2021 18:33:37 +0000 (UTC) Received: from mx2.smtp.larsendata.com (mx2.smtp.larsendata.com [91.221.196.228]) by gabe.freedesktop.org (Postfix) with ESMTPS id 64E2A6E434 for ; Wed, 4 Aug 2021 18:33:36 +0000 (UTC) Received: from mail01.mxhotel.dk (mail01.mxhotel.dk [91.221.196.236]) by mx2.smtp.larsendata.com (Halon) with ESMTPS id 8496dbbf-f552-11eb-8d1a-0050568cd888; Wed, 04 Aug 2021 18:33:52 +0000 (UTC) Received: from ravnborg.org (80-162-45-141-cable.dk.customer.tdc.net [80.162.45.141]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: sam@ravnborg.org) by mail01.mxhotel.dk (Postfix) with ESMTPSA id 365E9194B00; Wed, 4 Aug 2021 20:33:58 +0200 (CEST) Date: Wed, 4 Aug 2021 20:33:30 +0200 X-Report-Abuse-To: abuse@mxhotel.dk From: Sam Ravnborg To: Thomas Zimmermann Cc: daniel@ffwll.ch, airlied@linux.ie, alexander.deucher@amd.com, christian.koenig@amd.com, liviu.dudau@arm.com, brian.starkey@arm.com, bbrezillon@kernel.org, nicolas.ferre@microchip.com, maarten.lankhorst@linux.intel.com, mripard@kernel.org, stefan@agner.ch, alison.wang@nxp.com, patrik.r.jakobsson@gmail.com, anitha.chrisanthus@intel.com, robdclark@gmail.com, edmund.j.dea@intel.com, sean@poorly.run, shawnguo@kernel.org, s.hauer@pengutronix.de, kernel@pengutronix.de, jyri.sarha@iki.fi, tomba@kernel.org, Dan.Sneddon@microchip.com, tomi.valkeinen@ideasonboard.com, amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org Subject: Re: [PATCH v2 11/14] drm/tilcdc: Convert to Linux IRQ interfaces Message-ID: References: <20210803090704.32152-1-tzimmermann@suse.de> <20210803090704.32152-12-tzimmermann@suse.de> <896793e5-f5a8-fe74-1d8f-3dd1450d3fae@suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <896793e5-f5a8-fe74-1d8f-3dd1450d3fae@suse.de> X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Hi Thomas, On Wed, Aug 04, 2021 at 08:30:41PM +0200, Thomas Zimmermann wrote: > Hi > > Am 03.08.21 um 17:00 schrieb Sam Ravnborg: > > Hi Thomas, > > > > On Tue, Aug 03, 2021 at 11:07:01AM +0200, Thomas Zimmermann wrote: > > > Drop the DRM IRQ midlayer in favor of Linux IRQ interfaces. DRM's > > > IRQ helpers are mostly useful for UMS drivers. Modern KMS drivers > > > don't benefit from using it. > > > > > > DRM IRQ callbacks are now being called directly or inlined. > > > > > > Calls to platform_get_irq() can fail with a negative errno code. > > > Abort initialization in this case. The DRM IRQ midlayer does not > > > handle this case correctly. > > > > I cannot see why the irq_enabled flag is needed here, and the changelog > > do not help me. > > What do I miss? > > That's a good point. Usually, only the DRM IRQ helpers use irq_enabled in > struct drm_device. It'll become legacy and we can ignore it for the driver > conversion. > > The exception is tilcdc, which also uses irq_enabled to make its error > rollback work correctly. So I duplicated the state in the local private > structure. > > I'll add this explanation to the commit message. With this added: Acked-by: Sam Ravnborg