All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Daniel Scally <djrscally@gmail.com>
Cc: linux-kernel@vger.kernel.org, rafael@kernel.org,
	andriy.shevchenko@linux.intel.com,
	laurent.pinchart@ideasonboard.com
Subject: Re: [PATCH v2 2/2] Revert "media: device property: Call fwnode_graph_get_endpoint_by_id() for fwnode->secondary"
Date: Thu, 5 Aug 2021 10:38:04 +0200	[thread overview]
Message-ID: <YQujbIj0ynE43vw9@kroah.com> (raw)
In-Reply-To: <20210804230313.78238-3-djrscally@gmail.com>

On Thu, Aug 05, 2021 at 12:03:13AM +0100, Daniel Scally wrote:
> This reverts commit acd418bfcfc415cf5e6414b6d1c6acfec850f290. Checking for
> endpoints against fwnode->secondary in fwnode_graph_get_next_endpoint() is
> a better way to do this since that function is also used in a bunch of
> other places, for instance sensor drivers checking that they do have an
> endpoint connected during probe.
> 
> Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> Signed-off-by: Daniel Scally <djrscally@gmail.com>
> ---
>  drivers/base/property.c | 9 +--------
>  1 file changed, 1 insertion(+), 8 deletions(-)

This can only be reverted due to your 1/2 change, right?  If so, you
might want to make that explicit here...

thanks,

greg k-h

  reply	other threads:[~2021-08-05  8:38 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-04 23:03 [PATCH v2 0/2] Check for endpoints in fwnode->secondary more sensibly Daniel Scally
2021-08-04 23:03 ` [PATCH v2 1/2] device property: Check fwnode->secondary in fwnode_graph_get_next_endpoint() Daniel Scally
2021-08-04 23:03 ` [PATCH v2 2/2] Revert "media: device property: Call fwnode_graph_get_endpoint_by_id() for fwnode->secondary" Daniel Scally
2021-08-05  8:38   ` Greg KH [this message]
2021-08-05  8:59     ` Daniel Scally

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YQujbIj0ynE43vw9@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=djrscally@gmail.com \
    --cc=laurent.pinchart@ideasonboard.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rafael@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.