From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.4 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,FSL_HELO_FAKE, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5F9DDC432BE for ; Thu, 5 Aug 2021 22:35:52 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 49DA361151 for ; Thu, 5 Aug 2021 22:35:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241881AbhHEWgF (ORCPT ); Thu, 5 Aug 2021 18:36:05 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40910 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S241932AbhHEWgA (ORCPT ); Thu, 5 Aug 2021 18:36:00 -0400 Received: from mail-pj1-x102b.google.com (mail-pj1-x102b.google.com [IPv6:2607:f8b0:4864:20::102b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E6F85C0617BA for ; Thu, 5 Aug 2021 15:35:35 -0700 (PDT) Received: by mail-pj1-x102b.google.com with SMTP id mz5-20020a17090b3785b0290176ecf64922so18451455pjb.3 for ; Thu, 05 Aug 2021 15:35:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=rhBbxf1keApeH0HZr94f6ha2IwXSaTleZr4Kiwj/80I=; b=EivLKAHlfNh5KZVAVEWVk6jIbCxTHLY2FgBazDi5lsAIxuSkUlJhIk2wt4798LDj+A p97JIOuPQyPl4mGn27jmN+mvK5HS/UdqrjyiQSnoPdAp7yvv9udPYqU9mb/39rZYSRmE 7sK7tAxHWAypgvRxbwvsI0kaXMcZo+jJ9JFKKZ97UzZ/VMDynFZX6wzHlDtQb3Oh1DCm 2eKah1AN6mmSpgWX3f1hbaydV0io/5ZBNUgckAk5GXTHa1/smG/VbMy22lc/tYu2RRKe 3+pZcA31woyNn47DMWhgxiMIrDN9+fu54Z16nV1fyrLNJmhqX0IaCxQRqzcEY1J5DkeT mq0w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=rhBbxf1keApeH0HZr94f6ha2IwXSaTleZr4Kiwj/80I=; b=OnvyzzUWixj50DfGOBzhADtl04Zv1Xs45ZKAq0KOcTMhBRcsVb2T2AeQ3ESCIjIlqM 1OFu58tWH1EJW4dGBa53UrA2zkAHgz4bVxivh9/rACY4D5KgdRGEZ/IsnEOCp1po2mHx Ld0QNTytTEsWspFb9iQ5ljn4aTgTsOpz7iVDhiHdjmdNQlb2QabgtLjKrBd9KtUqIkKW 6SxPrC5bb4KdG7WSs6LrQEx/gaeqx7AbVSS8mCeEBxC2bOGT+wAVCLAnBHnIbdHjsoM6 vLYJ+qCCx4Mcx2x5s3iuMRENlJPOY0xYUPNaJymnKnKgn8ykejkhcDMvs2DVOs33tuo6 ztsw== X-Gm-Message-State: AOAM531JYSrwhiTDdikwDijsTTv18g5jzO4yI/e6LXvw5ZLs73pbIrkl b7v0UcxE38eiY6CNmd4w+a9pTA== X-Google-Smtp-Source: ABdhPJyOX8WyQFhtDFpV+MJoQfvcX4TDdK9nyvPy+iZO6MD4eVrgviSw/BBYz7FSfUSforNeQWtE+w== X-Received: by 2002:a17:90a:70c5:: with SMTP id a5mr1274437pjm.23.1628202935199; Thu, 05 Aug 2021 15:35:35 -0700 (PDT) Received: from google.com (157.214.185.35.bc.googleusercontent.com. [35.185.214.157]) by smtp.gmail.com with ESMTPSA id y2sm7309681pjl.6.2021.08.05.15.35.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 05 Aug 2021 15:35:34 -0700 (PDT) Date: Thu, 5 Aug 2021 22:35:31 +0000 From: Sean Christopherson To: Zeng Guang Cc: Paolo Bonzini , Vitaly Kuznetsov , Wanpeng Li , Jim Mattson , Joerg Roedel , kvm@vger.kernel.org, Dave Hansen , Tony Luck , Kan Liang , Thomas Gleixner , Ingo Molnar , Borislav Petkov , "H. Peter Anvin" , Kim Phillips , Jarkko Sakkinen , Jethro Beekman , Kai Huang , x86@kernel.org, linux-kernel@vger.kernel.org, Robert Hu , Gao Chao , Robert Hoo Subject: Re: [PATCH v3 3/6] KVM: VMX: Detect Tertiary VM-Execution control when setup VMCS config Message-ID: References: <20210805151317.19054-1-guang.zeng@intel.com> <20210805151317.19054-4-guang.zeng@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210805151317.19054-4-guang.zeng@intel.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Aug 05, 2021, Zeng Guang wrote: > +u64 vmx_tertiary_exec_control(struct vcpu_vmx *vmx) Make this static and drop the declaration from vmx.h, there's no nested user (yet), and I'm also working on a patch to rework how prepare_vmcs02_early() gets KVMs desires without having to call these heleprs, i.e. I want to bury all of these in vmx.c. > +{ > + return vmcs_config.cpu_based_3rd_exec_ctrl; > +} > + > /* > * Adjust a single secondary execution control bit to intercept/allow an > * instruction in the guest. This is usually done based on whether or not a > @@ -4319,6 +4354,9 @@ static void init_vmcs(struct vcpu_vmx *vmx) > secondary_exec_controls_set(vmx, vmx->secondary_exec_control); > } > > + if (cpu_has_tertiary_exec_ctrls()) > + tertiary_exec_controls_set(vmx, vmx_tertiary_exec_control(vmx)); > + > if (kvm_vcpu_apicv_active(&vmx->vcpu)) { > vmcs_write64(EOI_EXIT_BITMAP0, 0); > vmcs_write64(EOI_EXIT_BITMAP1, 0); > diff --git a/arch/x86/kvm/vmx/vmx.h b/arch/x86/kvm/vmx/vmx.h > index 945c6639ce24..448006bd8fa7 100644 > --- a/arch/x86/kvm/vmx/vmx.h > +++ b/arch/x86/kvm/vmx/vmx.h > @@ -478,6 +478,7 @@ static inline u32 vmx_vmexit_ctrl(void) > > u32 vmx_exec_control(struct vcpu_vmx *vmx); > u32 vmx_pin_based_exec_ctrl(struct vcpu_vmx *vmx); > +u64 vmx_tertiary_exec_control(struct vcpu_vmx *vmx); > > static inline struct kvm_vmx *to_kvm_vmx(struct kvm *kvm) > { > -- > 2.25.1 >