From: Christoph Hellwig <hch@infradead.org>
To: Douglas Miller <dougmill@linux.vnet.ibm.com>
Cc: linux-block@vger.kernel.org
Subject: Re: [PATCH RESEND] block: sed-opal: Add ioctl to return device status
Date: Fri, 20 Aug 2021 16:21:16 +0100 [thread overview]
Message-ID: <YR/IbHc5Mv826TQk@infradead.org> (raw)
In-Reply-To: <c43a9295-1dad-fa0a-590d-0182bba643a1@linux.vnet.ibm.com>
On Wed, Aug 18, 2021 at 07:22:09AM -0500, Douglas Miller wrote:
> +++ b/block/sed-opal.c
> @@ -75,7 +75,11 @@ struct parsed_resp {
> struct opal_dev {
> bool supported;
> + bool locking_supported;
> + bool locking_enabled;
> + bool locked;
> bool mbr_enabled;
> + bool mbr_done;
Please switch all these bools (or u8s in the user space ABI) to
flags with descriptive names on an u32 variable.
prev parent reply other threads:[~2021-08-20 15:26 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-18 12:22 [PATCH RESEND] block: sed-opal: Add ioctl to return device status Douglas Miller
2021-08-20 15:21 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YR/IbHc5Mv826TQk@infradead.org \
--to=hch@infradead.org \
--cc=dougmill@linux.vnet.ibm.com \
--cc=linux-block@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.