From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D2FBBC4338F for ; Fri, 20 Aug 2021 17:04:54 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B851C610CC for ; Fri, 20 Aug 2021 17:04:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232611AbhHTRFb (ORCPT ); Fri, 20 Aug 2021 13:05:31 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43432 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232766AbhHTRFa (ORCPT ); Fri, 20 Aug 2021 13:05:30 -0400 Received: from mail-ot1-x334.google.com (mail-ot1-x334.google.com [IPv6:2607:f8b0:4864:20::334]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AAFD9C061757 for ; Fri, 20 Aug 2021 10:04:52 -0700 (PDT) Received: by mail-ot1-x334.google.com with SMTP id k12-20020a056830150c00b0051abe7f680bso10223510otp.1 for ; Fri, 20 Aug 2021 10:04:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=Qq2zv8NidueXDY9RTP1XJuRvSThnlS4Tgw1w5ySGQso=; b=Ytw/TvevBJJxmZa6v3680rG8IdGuSSouHc+vk1jAd56rLtVmS0gGLVXQtUg/J3egdM K2ob+s5ABx/4KKfUf4O2M/c143PU72dI09LGRepF7DGG3feZgUwIDijuB2P+vrs29rN6 0hjjPEeYGP5HUOY4RuHR2Wy6ebUz402nb49W4is+Itpa1cp6j9eN2X+zRb026WCwTJZP BaLMM2CfHKKtnDuV2CFyfYMRk/N6d02okEsyBaoSAwHH/uzht9GWm9S3Rqrz/FgWG1gn RqmDyzVc+WpK7PvSwRP6NchHXiMEcw7buAVCB9PJRvaNsz9RCg3XPb8FN02TzqR+/ByH DZeQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=Qq2zv8NidueXDY9RTP1XJuRvSThnlS4Tgw1w5ySGQso=; b=rFg1iHyAd5p1uSvo6tPdhwNkw2e/ZhY5KclueKFiWrjYbumCH4Ql7DWMnQYrYWlpU5 Ug0efLCss/McxSzKhUz2koL19yPfggA/3SyDzhiq5WE/q6gGWTAgrhxswW06yQNAon43 mo1lhhrAGjebzYZZZtd6KW578b0sOHpknTW0xn1E4FUwnibBLGxw/5c/Dl/vh5OxNl6c 7YgEsyHlZKYzjYmUjXcxlCq7KaF8pvggKeE4Bcb6jO+VevmUX0O3kA+XyYhPm3WX8Pti +y+Uh7v5WtLEK/epRR4xt14Jnk82D983nwER9xQKh+1LLMszZ9MmL+6KYUvhdreUhaIN 7jsA== X-Gm-Message-State: AOAM532V6xBGsyqQByKGm+K0IxOc3Vvv6SzDNRQkmOpggEQT5FhxYZvM I2axm4+PftFD3rP/fd1QQIajXQ== X-Google-Smtp-Source: ABdhPJzf9sPEVI5OzR130ghE05XTbi5B3J4mkCHel8gpOF4PQEyk1+jhfPwySwCC8YhKiqcXpJYHKw== X-Received: by 2002:a05:6830:2808:: with SMTP id w8mr15018728otu.244.1629479092057; Fri, 20 Aug 2021 10:04:52 -0700 (PDT) Received: from ripper (104-57-184-186.lightspeed.austtx.sbcglobal.net. [104.57.184.186]) by smtp.gmail.com with ESMTPSA id u27sm1720689otj.6.2021.08.20.10.04.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 20 Aug 2021 10:04:51 -0700 (PDT) Date: Fri, 20 Aug 2021 10:06:13 -0700 From: Bjorn Andersson To: Sibi Sankar Cc: Vinod Koul , robh+dt@kernel.org, will@kernel.org, saiprakash.ranjan@codeaurora.org, swboyd@chromium.org, mka@chromium.org, ohad@wizery.com, agross@kernel.org, mathieu.poirier@linaro.org, robin.murphy@arm.com, joro@8bytes.org, p.zabel@pengutronix.de, linux-arm-msm@vger.kernel.org, linux-remoteproc@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, evgreen@chromium.org, dianders@chromium.org Subject: Re: [PATCH v3 06/10] arm64: dts: qcom: sc7280: Update reserved memory map Message-ID: References: <1629344185-27368-1-git-send-email-sibis@codeaurora.org> <1629344185-27368-7-git-send-email-sibis@codeaurora.org> <39da02506af192de14d346cdf80d0e4c@codeaurora.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <39da02506af192de14d346cdf80d0e4c@codeaurora.org> Precedence: bulk List-ID: X-Mailing-List: linux-remoteproc@vger.kernel.org On Fri 20 Aug 07:09 PDT 2021, Sibi Sankar wrote: > On 2021-08-19 10:07, Vinod Koul wrote: > > Hi Sibi, > > > > On 19-08-21, 09:06, Sibi Sankar wrote: > > > > > diff --git a/arch/arm64/boot/dts/qcom/sc7280.dtsi > > > b/arch/arm64/boot/dts/qcom/sc7280.dtsi > > > index 5e4f4f3b738a..894106efadfe 100644 > > > --- a/arch/arm64/boot/dts/qcom/sc7280.dtsi > > > +++ b/arch/arm64/boot/dts/qcom/sc7280.dtsi > > > @@ -48,6 +48,16 @@ > > > #size-cells = <2>; > > > ranges; > > > > > > + hyp_mem: memory@80000000 { > > > + reg = <0x0 0x80000000 0x0 0x600000>; > > > + no-map; > > > > This should conflict with the memory defined in this file: > > > > memory@80000000 { > > device_type = "memory"; > > /* We expect the bootloader to fill in the size */ > > reg = <0 0x80000000 0 0>; > > }; > > > > I think this should be updated? > > Vinod, > > I prefer we leave ^^ node untouched. For platforms using hyp_mem, the > regions defined in the memory map are valid and for the other > platforms not using hyp_mem we would just delete them in the board > files anyway. Logically this node describes where there is RAM, the reserved-memory then subtracts blocks of memory out of that. So I think it's perfectly legal for a region at the base to be marked as no-map. That said, isn't the address in the memory node just a placeholder? Regards, Bjorn From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DFCD4C4338F for ; Fri, 20 Aug 2021 17:06:57 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B116E610CC for ; Fri, 20 Aug 2021 17:06:57 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org B116E610CC Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=aRIdHRfcx+eOjWVASiL9CzhHRNaSpsYtyx6N6EL3VfU=; b=HmP+zwT6RllFgy +ITIVToNAlTaZRmhr6I572X0LIoUrn929MiatxdN/agMBfc6q2QYjyGB8PtiKbpWPcApm6e7SdBoK Ni91V3aI296b9wkGAL9uzZRdZWm0RwJWx4KBqP3ZV8ZZF61lkvcT6CykF2U9l4Gf603IB/SjmcSvl H2Oh8yuOKbiLnB6emmMP84twmgkGeIKKzcIo5MrwoTeJXW0Ywx6o+Hfv97osnJUmzoqPFkYfAF0tm LaKm1hXDwOfPjqWUs2lje9s9hmrPUYYt8f0zF9gUo96aBLHGDoLtx7m3DT1+WtfUiEPon8GmJPozv lIbxZ9+jQO+wOlAt6Cag==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mH7ww-00BhvW-VS; Fri, 20 Aug 2021 17:04:59 +0000 Received: from mail-ot1-x330.google.com ([2607:f8b0:4864:20::330]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mH7wr-00Bhub-CH for linux-arm-kernel@lists.infradead.org; Fri, 20 Aug 2021 17:04:57 +0000 Received: by mail-ot1-x330.google.com with SMTP id i8-20020a056830402800b0051afc3e373aso4022806ots.5 for ; Fri, 20 Aug 2021 10:04:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=Qq2zv8NidueXDY9RTP1XJuRvSThnlS4Tgw1w5ySGQso=; b=Ytw/TvevBJJxmZa6v3680rG8IdGuSSouHc+vk1jAd56rLtVmS0gGLVXQtUg/J3egdM K2ob+s5ABx/4KKfUf4O2M/c143PU72dI09LGRepF7DGG3feZgUwIDijuB2P+vrs29rN6 0hjjPEeYGP5HUOY4RuHR2Wy6ebUz402nb49W4is+Itpa1cp6j9eN2X+zRb026WCwTJZP BaLMM2CfHKKtnDuV2CFyfYMRk/N6d02okEsyBaoSAwHH/uzht9GWm9S3Rqrz/FgWG1gn RqmDyzVc+WpK7PvSwRP6NchHXiMEcw7buAVCB9PJRvaNsz9RCg3XPb8FN02TzqR+/ByH DZeQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=Qq2zv8NidueXDY9RTP1XJuRvSThnlS4Tgw1w5ySGQso=; b=aS9DUNS+TED1BLtQTffBzi6ZdO9czte/XtJVOv8FPhe4fwJiAfrxRRIU0QAOxd6XcK w1zmP6zR8+/jedW0VxAp/R0AYVQxxP1NVODK08+mB0OP7b6lrBU7CosuLBtSxDhIWpqI fw6nPSPmic/CPOTyYzMLA+2g9rrtLKpdAHXDKu9RrbCIemOPqj7xRwkXHbTfE0f+aKcU NMIRvUjWqIWaxA8305csyXJ/fKriQx7uegTzJqoLvkgrJL1Dcx1Ap/WqsW10WZOplph8 ggf0w3RQeiblYTxeXLW7fN3hv1TaldXEOQwF1YmGQMoH5hZNSILZhaTZA/Nx1pQ1n7kr t3CA== X-Gm-Message-State: AOAM533VkkCu9kjAM9z4X7PNXFpkWKu4xmCsYQbI1xD50no16/yVWdZZ BQKJ8anfJy+TvDXyE5cliDkvqQ== X-Google-Smtp-Source: ABdhPJzf9sPEVI5OzR130ghE05XTbi5B3J4mkCHel8gpOF4PQEyk1+jhfPwySwCC8YhKiqcXpJYHKw== X-Received: by 2002:a05:6830:2808:: with SMTP id w8mr15018728otu.244.1629479092057; Fri, 20 Aug 2021 10:04:52 -0700 (PDT) Received: from ripper (104-57-184-186.lightspeed.austtx.sbcglobal.net. [104.57.184.186]) by smtp.gmail.com with ESMTPSA id u27sm1720689otj.6.2021.08.20.10.04.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 20 Aug 2021 10:04:51 -0700 (PDT) Date: Fri, 20 Aug 2021 10:06:13 -0700 From: Bjorn Andersson To: Sibi Sankar Cc: Vinod Koul , robh+dt@kernel.org, will@kernel.org, saiprakash.ranjan@codeaurora.org, swboyd@chromium.org, mka@chromium.org, ohad@wizery.com, agross@kernel.org, mathieu.poirier@linaro.org, robin.murphy@arm.com, joro@8bytes.org, p.zabel@pengutronix.de, linux-arm-msm@vger.kernel.org, linux-remoteproc@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, evgreen@chromium.org, dianders@chromium.org Subject: Re: [PATCH v3 06/10] arm64: dts: qcom: sc7280: Update reserved memory map Message-ID: References: <1629344185-27368-1-git-send-email-sibis@codeaurora.org> <1629344185-27368-7-git-send-email-sibis@codeaurora.org> <39da02506af192de14d346cdf80d0e4c@codeaurora.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <39da02506af192de14d346cdf80d0e4c@codeaurora.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210820_100453_474657_526087F7 X-CRM114-Status: GOOD ( 20.84 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri 20 Aug 07:09 PDT 2021, Sibi Sankar wrote: > On 2021-08-19 10:07, Vinod Koul wrote: > > Hi Sibi, > > > > On 19-08-21, 09:06, Sibi Sankar wrote: > > > > > diff --git a/arch/arm64/boot/dts/qcom/sc7280.dtsi > > > b/arch/arm64/boot/dts/qcom/sc7280.dtsi > > > index 5e4f4f3b738a..894106efadfe 100644 > > > --- a/arch/arm64/boot/dts/qcom/sc7280.dtsi > > > +++ b/arch/arm64/boot/dts/qcom/sc7280.dtsi > > > @@ -48,6 +48,16 @@ > > > #size-cells = <2>; > > > ranges; > > > > > > + hyp_mem: memory@80000000 { > > > + reg = <0x0 0x80000000 0x0 0x600000>; > > > + no-map; > > > > This should conflict with the memory defined in this file: > > > > memory@80000000 { > > device_type = "memory"; > > /* We expect the bootloader to fill in the size */ > > reg = <0 0x80000000 0 0>; > > }; > > > > I think this should be updated? > > Vinod, > > I prefer we leave ^^ node untouched. For platforms using hyp_mem, the > regions defined in the memory map are valid and for the other > platforms not using hyp_mem we would just delete them in the board > files anyway. Logically this node describes where there is RAM, the reserved-memory then subtracts blocks of memory out of that. So I think it's perfectly legal for a region at the base to be marked as no-map. That said, isn't the address in the memory node just a placeholder? Regards, Bjorn _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel