All of lore.kernel.org
 help / color / mirror / Atom feed
From: Cyril Hrubis <chrubis@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH v5 3/3] syscalls/msgstress: tune limit of processes for small machines
Date: Fri, 20 Aug 2021 15:34:30 +0200	[thread overview]
Message-ID: <YR+vZjqYBh/f6yAZ@yuki> (raw)
In-Reply-To: <20210820100028.97487-4-krzysztof.kozlowski@canonical.com>

Hi!
> Forking the exactly amount of processes as the limit (either from
> max_pids or from cgroups) is risky - OS might be doing some work and

This comment does not seem to match the code. We apply the reserve to
the cgroup limit only. If we wanted to make sure that the reserve is
applied even in the case where there is no systemd cgroup we would have
to apply it in the tst_get_free_pids_() just before we check if
used_pids >= max_pids instead.

-- 
Cyril Hrubis
chrubis@suse.cz

  reply	other threads:[~2021-08-20 13:34 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-20 10:00 [LTP] [PATCH v5 0/3] syscalls/msgstress: fixes for small systems Krzysztof Kozlowski
2021-08-20 10:00 ` [LTP] [PATCH v5 1/3] lib/tst_pid: simplify error handling by callers of tst_get_free_pids() Krzysztof Kozlowski
2021-08-20 10:00 ` [LTP] [PATCH v5 2/3] syscalls/msgstress03: fix fork failure on small memory systems Krzysztof Kozlowski
2021-08-20 10:00 ` [LTP] [PATCH v5 3/3] syscalls/msgstress: tune limit of processes for small machines Krzysztof Kozlowski
2021-08-20 13:34   ` Cyril Hrubis [this message]
2021-08-26  9:50     ` Krzysztof Kozlowski
2021-08-20 13:34 ` [LTP] [PATCH v5 0/3] syscalls/msgstress: fixes for small systems Cyril Hrubis

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YR+vZjqYBh/f6yAZ@yuki \
    --to=chrubis@suse.cz \
    --cc=ltp@lists.linux.it \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.