From: Rob Herring <robh@kernel.org>
To: Jacopo Mondi <jacopo@jmondi.org>
Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Jonathan Cameron <jic23@kernel.org>,
Lars-Peter Clausen <lars@metafoo.de>,
Matt Ranostay <matt.ranostay@konsulko.com>,
linux-iio@vger.kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH 1/2] dt-bindings: iio: chemical: Document senseair,sunrise CO2 sensor
Date: Wed, 18 Aug 2021 11:47:20 -0500 [thread overview]
Message-ID: <YR05mNB9LDoeotkj@robh.at.kernel.org> (raw)
In-Reply-To: <20210818072943.zgj6nibmvpnd2ffu@uno.localdomain>
On Wed, Aug 18, 2021 at 09:29:43AM +0200, Jacopo Mondi wrote:
> Hi Andy,
>
> On Tue, Aug 17, 2021 at 07:50:46PM +0300, Andy Shevchenko wrote:
> > On Tue, Aug 17, 2021 at 05:49:50PM +0200, Jacopo Mondi wrote:
> > > Add documentation for the Senseair Sunrise 006-0-0007 CO2 NDIR sensor.
> >
> > > + ndry-gpios:
> > > + description: Phandle to the GPIO line connected to the nDRY pin. Active low.
> > > +
> > > + en-gpios:
> > > + description: Phandle to the GPIO line connected to the EN pin. Active high.
> >
> > Not sure you have to mention polarity. It can be changed on PCB level easily
> > and this bindings won't satisfy those (valid) changes.
>
> Well, one can indeed invert the signal on the PCB, it's weird I see most of
> the bindings reporting the pin's active polarity though...
>
> I'll drop it.
I'd keep it. It's documenting the pin on the h/w. You can prefix with
'Typically' if you want.
Rob
next prev parent reply other threads:[~2021-08-18 16:47 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-17 15:49 [PATCH 0/2] iio: chemical: Add Senseair Sunrise CO2 sensor Jacopo Mondi
2021-08-17 15:49 ` [PATCH 1/2] dt-bindings: iio: chemical: Document senseair,sunrise " Jacopo Mondi
2021-08-17 16:50 ` Andy Shevchenko
2021-08-18 7:29 ` Jacopo Mondi
2021-08-18 16:47 ` Rob Herring [this message]
2021-08-18 16:49 ` Rob Herring
2021-08-17 15:49 ` [PATCH 2/2] iio: chemical: Add Senseair Sunrise 006-0-007 driver Jacopo Mondi
2021-08-17 16:58 ` Andy Shevchenko
2021-08-18 8:02 ` Jacopo Mondi
2021-08-18 9:29 ` Andy Shevchenko
2021-08-29 16:05 ` Jonathan Cameron
2021-08-17 17:01 ` [PATCH 0/2] iio: chemical: Add Senseair Sunrise CO2 sensor Matt Ranostay
2021-08-18 8:03 ` Jacopo Mondi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YR05mNB9LDoeotkj@robh.at.kernel.org \
--to=robh@kernel.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=devicetree@vger.kernel.org \
--cc=jacopo@jmondi.org \
--cc=jic23@kernel.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=matt.ranostay@konsulko.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.