From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.0 required=3.0 tests=BAYES_00,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 43892C4320A for ; Wed, 18 Aug 2021 18:49:04 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 2D74061104 for ; Wed, 18 Aug 2021 18:49:04 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232326AbhHRSth (ORCPT ); Wed, 18 Aug 2021 14:49:37 -0400 Received: from mail-ot1-f54.google.com ([209.85.210.54]:33784 "EHLO mail-ot1-f54.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229952AbhHRStd (ORCPT ); Wed, 18 Aug 2021 14:49:33 -0400 Received: by mail-ot1-f54.google.com with SMTP id 61-20020a9d0d430000b02903eabfc221a9so5369752oti.0; Wed, 18 Aug 2021 11:48:54 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=mFM10FkKUqKwfO9MnVHXIsn1wrjSk6OwROs1K7AMqrE=; b=Y41fRhxhCxqSEISNnnrIBTZ0vTmxbVCQrvQqTw+9XXBxWrCm8TVXyo0Ay3C8C09TMq CRMIryDbtu51v1xwBVS1Xsag4NqDThGmRB4NsYO+FpK6XaaoFDadxOp7GwgrAmGrWNsZ OMSrdp2fhbyQC+mKhAp42AHdlj0Dd+MXpKaKiVlrdoCD+NA4Jbh3qYnpO1f3aS9XGytb jLgmSzBHwGburc+452deL9yB+Wl9sV5A+AHwOZptcVV8PolVMxElfIOc9o9Wbs0ML5G5 s0UXjUNzg0eX/OC47VzRlnkKQ9NFjF8CpyLNfNhLozV7aVjGf3PSI8kPT+egtAcKbdEq 0mwA== X-Gm-Message-State: AOAM532aalgn+eqzRATPlf8z6CCW51VOI50oKzLZs3TWb5kVCnXTSdUA J+cIS47lBc1TxwTVN8ffHA== X-Google-Smtp-Source: ABdhPJwNqWe9L4q1pV8YiVvQEWr2wvPBzy6QVVut+3EmfxypdzCijfLr3sz1yBEajCTLBSX3AX+ySQ== X-Received: by 2002:a05:6830:1bc1:: with SMTP id v1mr7980785ota.246.1629312534574; Wed, 18 Aug 2021 11:48:54 -0700 (PDT) Received: from robh.at.kernel.org (24-155-109-49.dyn.grandenetworks.net. [24.155.109.49]) by smtp.gmail.com with ESMTPSA id n73sm217973oig.9.2021.08.18.11.48.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 18 Aug 2021 11:48:53 -0700 (PDT) Received: (nullmailer pid 2901547 invoked by uid 1000); Wed, 18 Aug 2021 18:48:52 -0000 Date: Wed, 18 Aug 2021 13:48:52 -0500 From: Rob Herring To: haibo.chen@nxp.com Cc: adrian.hunter@intel.com, ulf.hansson@linaro.org, shawnguo@kernel.org, s.hauer@pengutronix.de, kernel@pengutronix.de, festevam@gmail.com, linux-mmc@vger.kernel.org, linux-imx@nxp.com, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v2 3/6] dt-bindings: mmc: fsl-imx-esdhc: add fsl,broken-auto-tuning binding Message-ID: References: <1629285415-7495-1-git-send-email-haibo.chen@nxp.com> <1629285415-7495-3-git-send-email-haibo.chen@nxp.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1629285415-7495-3-git-send-email-haibo.chen@nxp.com> Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Wed, Aug 18, 2021 at 07:16:52PM +0800, haibo.chen@nxp.com wrote: > From: Haibo Chen > > Add a new fsl,broken-auto-tuning binding for sdio devices. When sdio > device support sdio interrupt, need to use this property to disable > auto-tuning. Auto-tuning circuit is conflict with sdio interrupt. > > Signed-off-by: Haibo Chen > --- > Documentation/devicetree/bindings/mmc/fsl-imx-esdhc.yaml | 9 +++++++++ > 1 file changed, 9 insertions(+) > > diff --git a/Documentation/devicetree/bindings/mmc/fsl-imx-esdhc.yaml b/Documentation/devicetree/bindings/mmc/fsl-imx-esdhc.yaml > index b5baf439fbac..d7c8e5880473 100644 > --- a/Documentation/devicetree/bindings/mmc/fsl-imx-esdhc.yaml > +++ b/Documentation/devicetree/bindings/mmc/fsl-imx-esdhc.yaml > @@ -93,6 +93,15 @@ properties: > tuning step can't find the proper delay window within limited tuning retries. > default: 0 > > + fsl,broken-auto-tuning: > + description: | > + Recommend for SDIO cards that enables SDIO interrupt for SDR104 and SDR50 mode. > + SDIO interrupt uses DAT[1] to signal the card's interrupt. Auto-tuning circuit > + will detect this interrupt on DAT[1] when in 4Bit bus mode, and take it just > + as normal data, wrongly adjust the delay cell. This property is used to disable > + the auto-tuning function. > + type: boolean Seems like something that could be broken on a variety of hosts and should be common? If auto tuning is broken, shouldn't that speed be disabled? Rob From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0339DC4338F for ; Wed, 18 Aug 2021 18:50:49 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C0299610FA for ; Wed, 18 Aug 2021 18:50:48 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org C0299610FA Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=nqVyBrHK9j8ggVRrVFJ0zOqwKxu/ww5veaELNTaAZu4=; b=wu1g+WEOO5DImn FVjrxVF5QcAacS94XQlOdj7ApXAl8RJTUgtYm1RaIUrU6oTEXb/XjneABjSjhEoKoJCKYYmp7xOmF IyKFi2OcmEf53vvzTPZI8YtMNZCfjN1BXttDrlb9po6obscDHQrRGXjrK0F5VTylpBEilMFr/Bd+e yMFajS0RZp6KrZbFB9Zgi2zW4BgGZ9qi83sPD4JJ56HmDY1lv9/3Okz2J/EbtptlRDvIpHnKXPuES QaO6zVzpeOAX97SQQdYsmDEH2SPKwqxbsOnai9mPMBk37y2sFX6iT0nzgXaOqBoDtFeDQStmXwxtM e7KCOmat6I9SuYrNKD/w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mGQcU-006RW6-OF; Wed, 18 Aug 2021 18:48:58 +0000 Received: from mail-ot1-f42.google.com ([209.85.210.42]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mGQcR-006RVm-JX for linux-arm-kernel@lists.infradead.org; Wed, 18 Aug 2021 18:48:56 +0000 Received: by mail-ot1-f42.google.com with SMTP id n1-20020a9d1e810000b0290514da4485e4so5305088otn.4 for ; Wed, 18 Aug 2021 11:48:55 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=mFM10FkKUqKwfO9MnVHXIsn1wrjSk6OwROs1K7AMqrE=; b=jMOrhOr+HtVBXVKIsvl6oLbUfjgUlv9LBWEgRL8oyU/cjqpmbA8RE2MtM95rdIB1db OtljOz6Ffk3uLWCX53DEBkd6vD8WGiwXS3O0eM4Kua1aQcyojD9S72/Oh+pHM2uq25ox AzCi/FdOpY29WjrCmyqE8qZOul2EoIpow+SxBXxr2U0yxMNozpSa/nLEGKGp3jyE+nnc IuF7s//2j34kP1vdfMlgIkKY0JRQyovA2ba4SRHVwL7XSE1q4Rs8vePvUQwWjyu0HD7N 3UfcvKJrzk1NX8k9gj3tRpRK5H3usBjnajd6IgcgGCPIhM8yFq9BoGZ5QPAqooSYNZXt 9ohw== X-Gm-Message-State: AOAM530aD8sSYrOmJ1EZuBdCn1YbcSFcQsD5W3P2uLVG+ZXX+5iebms0 HGUz7+I0e+NddoR7ct7NwQ== X-Google-Smtp-Source: ABdhPJwNqWe9L4q1pV8YiVvQEWr2wvPBzy6QVVut+3EmfxypdzCijfLr3sz1yBEajCTLBSX3AX+ySQ== X-Received: by 2002:a05:6830:1bc1:: with SMTP id v1mr7980785ota.246.1629312534574; Wed, 18 Aug 2021 11:48:54 -0700 (PDT) Received: from robh.at.kernel.org (24-155-109-49.dyn.grandenetworks.net. [24.155.109.49]) by smtp.gmail.com with ESMTPSA id n73sm217973oig.9.2021.08.18.11.48.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 18 Aug 2021 11:48:53 -0700 (PDT) Received: (nullmailer pid 2901547 invoked by uid 1000); Wed, 18 Aug 2021 18:48:52 -0000 Date: Wed, 18 Aug 2021 13:48:52 -0500 From: Rob Herring To: haibo.chen@nxp.com Cc: adrian.hunter@intel.com, ulf.hansson@linaro.org, shawnguo@kernel.org, s.hauer@pengutronix.de, kernel@pengutronix.de, festevam@gmail.com, linux-mmc@vger.kernel.org, linux-imx@nxp.com, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v2 3/6] dt-bindings: mmc: fsl-imx-esdhc: add fsl,broken-auto-tuning binding Message-ID: References: <1629285415-7495-1-git-send-email-haibo.chen@nxp.com> <1629285415-7495-3-git-send-email-haibo.chen@nxp.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1629285415-7495-3-git-send-email-haibo.chen@nxp.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210818_114855_691090_B789307C X-CRM114-Status: GOOD ( 19.05 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Aug 18, 2021 at 07:16:52PM +0800, haibo.chen@nxp.com wrote: > From: Haibo Chen > > Add a new fsl,broken-auto-tuning binding for sdio devices. When sdio > device support sdio interrupt, need to use this property to disable > auto-tuning. Auto-tuning circuit is conflict with sdio interrupt. > > Signed-off-by: Haibo Chen > --- > Documentation/devicetree/bindings/mmc/fsl-imx-esdhc.yaml | 9 +++++++++ > 1 file changed, 9 insertions(+) > > diff --git a/Documentation/devicetree/bindings/mmc/fsl-imx-esdhc.yaml b/Documentation/devicetree/bindings/mmc/fsl-imx-esdhc.yaml > index b5baf439fbac..d7c8e5880473 100644 > --- a/Documentation/devicetree/bindings/mmc/fsl-imx-esdhc.yaml > +++ b/Documentation/devicetree/bindings/mmc/fsl-imx-esdhc.yaml > @@ -93,6 +93,15 @@ properties: > tuning step can't find the proper delay window within limited tuning retries. > default: 0 > > + fsl,broken-auto-tuning: > + description: | > + Recommend for SDIO cards that enables SDIO interrupt for SDR104 and SDR50 mode. > + SDIO interrupt uses DAT[1] to signal the card's interrupt. Auto-tuning circuit > + will detect this interrupt on DAT[1] when in 4Bit bus mode, and take it just > + as normal data, wrongly adjust the delay cell. This property is used to disable > + the auto-tuning function. > + type: boolean Seems like something that could be broken on a variety of hosts and should be common? If auto tuning is broken, shouldn't that speed be disabled? Rob _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel