All of lore.kernel.org
 help / color / mirror / Atom feed
From: Alexander Dahl <ada@thorsis.com>
To: Eugen Hristev <eugen.hristev@microchip.com>
Cc: u-boot@lists.denx.de, mihai.sain@microchip.com
Subject: Re: [PATCH 3/4] ARM: dts: at91: sama5d2: fix dtc warning for ohci and ehci
Date: Fri, 20 Aug 2021 08:25:00 +0200	[thread overview]
Message-ID: <YR9KvAbZ42TEuZC6@ada.ifak-system.com> (raw)
In-Reply-To: <20210817102925.62787-3-eugen.hristev@microchip.com>

Hello,

Am Tue, Aug 17, 2021 at 01:29:24PM +0300 schrieb Eugen Hristev:
> Fixed the following DTC build warning (reproducible with W=1)
> 
> arch/arm/dts/at91-sama5d2_icp.dtb: Warning (unit_address_format): /ahb/ohci@00400000: unit name should not have leading 0s
> arch/arm/dts/at91-sama5d2_icp.dtb: Warning (unit_address_format): /ahb/ehci@00500000: unit name should not have leading 0s
> 
> Signed-off-by: Eugen Hristev <eugen.hristev@microchip.com>
> ---
>  arch/arm/dts/at91-sama5d27_som1_ek.dts | 4 ++--
>  arch/arm/dts/at91-sama5d2_ptc_ek.dts   | 4 ++--
>  arch/arm/dts/at91-sama5d2_xplained.dts | 4 ++--
>  arch/arm/dts/sama5d2.dtsi              | 4 ++--
>  4 files changed, 8 insertions(+), 8 deletions(-)
> 
> diff --git a/arch/arm/dts/at91-sama5d27_som1_ek.dts b/arch/arm/dts/at91-sama5d27_som1_ek.dts
> index ee851a1bef..efd1a5d197 100644
> --- a/arch/arm/dts/at91-sama5d27_som1_ek.dts
> +++ b/arch/arm/dts/at91-sama5d27_som1_ek.dts
> @@ -68,7 +68,7 @@
>  	};
>  
>  	ahb {
> -		usb1: ohci@00400000 {
> +		usb1: ohci@400000 {
>  			num-ports = <3>;
>  			atmel,vbus-gpio = <&pioA 42 0>;
>  			pinctrl-names = "default";
> @@ -76,7 +76,7 @@
>  			status = "okay";
>  		};
>  
> -		usb2: ehci@00500000 {
> +		usb2: ehci@500000 {
>  			status = "okay";
>  		};
>  
> diff --git a/arch/arm/dts/at91-sama5d2_ptc_ek.dts b/arch/arm/dts/at91-sama5d2_ptc_ek.dts
> index cd3711a02a..f45fb1ef26 100644
> --- a/arch/arm/dts/at91-sama5d2_ptc_ek.dts
> +++ b/arch/arm/dts/at91-sama5d2_ptc_ek.dts
> @@ -76,7 +76,7 @@
>  			status = "okay";
>  		};
>  
> -		usb1: ohci@00400000 {
> +		usb1: ohci@400000 {
>  			num-ports = <3>;
>  			atmel,vbus-gpio = <0
>  					   &pioA PIN_PB12 GPIO_ACTIVE_HIGH
> @@ -87,7 +87,7 @@
>  			status = "okay";
>  		};
>  
> -		usb2: ehci@00500000 {
> +		usb2: ehci@500000 {
>  			status = "okay";
>  		};
>  
> diff --git a/arch/arm/dts/at91-sama5d2_xplained.dts b/arch/arm/dts/at91-sama5d2_xplained.dts
> index b733c4d4ce..e7c91c5fec 100644
> --- a/arch/arm/dts/at91-sama5d2_xplained.dts
> +++ b/arch/arm/dts/at91-sama5d2_xplained.dts
> @@ -25,7 +25,7 @@
>  	};
>  
>  	ahb {
> -		usb1: ohci@00400000 {
> +		usb1: ohci@400000 {
>  			num-ports = <3>;
>  			atmel,vbus-gpio = <&pioA 42 0>;
>  			pinctrl-names = "default";
> @@ -33,7 +33,7 @@
>  			status = "okay";
>  		};
>  
> -		usb2: ehci@00500000 {
> +		usb2: ehci@500000 {
>  			status = "okay";
>  		};
>  
> diff --git a/arch/arm/dts/sama5d2.dtsi b/arch/arm/dts/sama5d2.dtsi
> index 6fb2cb25f9..d8a125b073 100644
> --- a/arch/arm/dts/sama5d2.dtsi
> +++ b/arch/arm/dts/sama5d2.dtsi
> @@ -32,7 +32,7 @@
>  		#size-cells = <1>;
>  		u-boot,dm-pre-reloc;
>  
> -		usb1: ohci@00400000 {
> +		usb1: ohci@400000 {
>  			compatible = "atmel,at91rm9200-ohci", "usb-ohci";
>  			reg = <0x00400000 0x100000>;
>  			clocks = <&uhphs_clk>, <&uhphs_clk>, <&uhpck>;
> @@ -40,7 +40,7 @@
>  			status = "disabled";
>  		};
>  
> -		usb2: ehci@00500000 {
> +		usb2: ehci@500000 {
>  			compatible = "atmel,at91sam9g45-ehci", "usb-ehci";
>  			reg = <0x00500000 0x100000>;
>  			clocks = <&utmi>, <&uhphs_clk>;

Reviewed-by: Alexander Dahl <ada@thorsis.com>

Greets
Alex


  reply	other threads:[~2021-08-20  6:25 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-17 10:29 [PATCH 1/4] ARM: dts: at91: sama5d2_icp: add QSPI1 device Eugen Hristev
2021-08-17 10:29 ` [PATCH 2/4] ARM: dts: at91: sama5d2_icp: cosmetic arrangement of the nodes Eugen Hristev
2021-08-17 10:29 ` [PATCH 3/4] ARM: dts: at91: sama5d2: fix dtc warning for ohci and ehci Eugen Hristev
2021-08-20  6:25   ` Alexander Dahl [this message]
2021-08-17 10:29 ` [PATCH 4/4] configs: sama5d2: add qspi config for QSPI1 Eugen Hristev
2021-09-07  9:25 ` [PATCH 1/4] ARM: dts: at91: sama5d2_icp: add QSPI1 device Eugen.Hristev

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YR9KvAbZ42TEuZC6@ada.ifak-system.com \
    --to=ada@thorsis.com \
    --cc=eugen.hristev@microchip.com \
    --cc=mihai.sain@microchip.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.