From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BAF3DC432BE for ; Mon, 9 Aug 2021 13:35:31 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A084061052 for ; Mon, 9 Aug 2021 13:35:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233442AbhHINfu (ORCPT ); Mon, 9 Aug 2021 09:35:50 -0400 Received: from vps0.lunn.ch ([185.16.172.187]:39978 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229474AbhHINfs (ORCPT ); Mon, 9 Aug 2021 09:35:48 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Disposition:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:From:Sender:Reply-To:Subject: Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Content-Disposition:In-Reply-To:References; bh=4ANahQ2cqmBDHTiQEa5YLbEqQAFRzNMJ3iDCtBOXvgI=; b=ZBYHEpi+HbXPwkc/gBLFF8X5pf 880QW5VjvwWasYI5PzgwK41YsF9fYzv0YeC7r6EwGDR7Au3ztt/yjWgGwM2pvhpBiDrpowKHpPptG OUqP2HB7ie0GOy8N5LlbFHRKbBZ63pc9lDK5Q+a6nscl9Vjemgdz3XQnB/GFs6V7icdE=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1mD5Qr-00Gi51-F9; Mon, 09 Aug 2021 15:35:09 +0200 Date: Mon, 9 Aug 2021 15:35:09 +0200 From: Andrew Lunn To: Wong Vee Khee Cc: Vivien Didelot , Florian Fainelli , "David S . Miller" , Jakub Kicinski , Giuseppe Cavallaro , Alexandre Torgue , Jose Abreu , Maxime Coquelin , Heiner Kallweit , Russell King , Voon Weifeng , Michael Sit Wei Hong , Vladimir Oltean , linux-arm-kernel@lists.infradead.org, linux-stm32@st-md-mailman.stormreply.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH net-next 1/2] net: pcs: xpcs: enable skip xPCS soft reset Message-ID: References: <20210809102229.933748-1-vee.khee.wong@linux.intel.com> <20210809102229.933748-2-vee.khee.wong@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210809102229.933748-2-vee.khee.wong@linux.intel.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Aug 09, 2021 at 06:22:28PM +0800, Wong Vee Khee wrote: > From: Michael Sit Wei Hong > > Unlike any other platforms, Intel AlderLake-S uses Synopsys SerDes where > all the SerDes PLL configurations are controlled by the xPCS at the BIOS > level. If the driver perform a xPCS soft reset on initialization, these > settings will be switched back to the power on reset values. > > This changes the xpcs_create function to take in an additional argument > to check if the platform request to skip xPCS soft reset during device > initialization. Why not just call into the BIOS and ask it to configure the SERDES? Isn't that what ACPI is all about, hiding the details from the OS? Or did the BIOS writers not add a control method to do this? Andrew From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E343BC4320A for ; Mon, 9 Aug 2021 13:37:28 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 743E46101D for ; Mon, 9 Aug 2021 13:37:28 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 743E46101D Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lunn.ch Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=1nFFfd0KaWMl26wTdnaU5yBL5hHDbp6NGNWS8UhzG80=; b=aD+KW59QJBrNdz pQ9/ga0+HoRf/xkoXfVMV+n5b3h7/2o8tmZtjXng2bAaZsFehXfQCcpaAm3/hHDax0tJhH8FWQvJ3 6cKkvppUh4wro+Qb7rqWEmKlw9AiAXL8PCssMWFIPu7aEPWIUXMRktt4KONC4Ekkhg3zgwV8jwLor uGUJrcqAjI03TOSTRLu/3TWaGFq1NfIAnxqeGVSZxm4kuIYka7RdOR1SDlaPx35kY0jZ+/ZQkce08 qK65FNP3dxpnxqaEKQms6NO9X4VjoJNWF5r8UtlE3Jva/rOqrYbVZMptu70r+dBoLBYPr6YKDF+Ek tH3ib6ZsMHvQeyngJ2dQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mD5RB-000muj-Hu; Mon, 09 Aug 2021 13:35:29 +0000 Received: from vps0.lunn.ch ([185.16.172.187]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mD5R7-000mt5-Lp for linux-arm-kernel@lists.infradead.org; Mon, 09 Aug 2021 13:35:26 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Disposition:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:From:Sender:Reply-To:Subject: Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Content-Disposition:In-Reply-To:References; bh=4ANahQ2cqmBDHTiQEa5YLbEqQAFRzNMJ3iDCtBOXvgI=; b=ZBYHEpi+HbXPwkc/gBLFF8X5pf 880QW5VjvwWasYI5PzgwK41YsF9fYzv0YeC7r6EwGDR7Au3ztt/yjWgGwM2pvhpBiDrpowKHpPptG OUqP2HB7ie0GOy8N5LlbFHRKbBZ63pc9lDK5Q+a6nscl9Vjemgdz3XQnB/GFs6V7icdE=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1mD5Qr-00Gi51-F9; Mon, 09 Aug 2021 15:35:09 +0200 Date: Mon, 9 Aug 2021 15:35:09 +0200 From: Andrew Lunn To: Wong Vee Khee Cc: Vivien Didelot , Florian Fainelli , "David S . Miller" , Jakub Kicinski , Giuseppe Cavallaro , Alexandre Torgue , Jose Abreu , Maxime Coquelin , Heiner Kallweit , Russell King , Voon Weifeng , Michael Sit Wei Hong , Vladimir Oltean , linux-arm-kernel@lists.infradead.org, linux-stm32@st-md-mailman.stormreply.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH net-next 1/2] net: pcs: xpcs: enable skip xPCS soft reset Message-ID: References: <20210809102229.933748-1-vee.khee.wong@linux.intel.com> <20210809102229.933748-2-vee.khee.wong@linux.intel.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210809102229.933748-2-vee.khee.wong@linux.intel.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210809_063525_758670_36685FBE X-CRM114-Status: GOOD ( 13.41 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Aug 09, 2021 at 06:22:28PM +0800, Wong Vee Khee wrote: > From: Michael Sit Wei Hong > > Unlike any other platforms, Intel AlderLake-S uses Synopsys SerDes where > all the SerDes PLL configurations are controlled by the xPCS at the BIOS > level. If the driver perform a xPCS soft reset on initialization, these > settings will be switched back to the power on reset values. > > This changes the xpcs_create function to take in an additional argument > to check if the platform request to skip xPCS soft reset during device > initialization. Why not just call into the BIOS and ask it to configure the SERDES? Isn't that what ACPI is all about, hiding the details from the OS? Or did the BIOS writers not add a control method to do this? Andrew _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel