From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Dongliang Mu <mudongliangabcd@gmail.com>
Cc: Samuel Iglesias Gonsalvez <siglesias@igalia.com>,
Jens Taprogge <jens.taprogge@taprogge.org>,
Aditya Srivastava <yashsri421@gmail.com>,
Randy Dunlap <rdunlap@infradead.org>,
Lv Yunlong <lyl2019@mail.ustc.edu.cn>,
Zhouyang Jia <jiazhouyang09@gmail.com>,
industrypack-devel@lists.sourceforge.net,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 2/4] ipack: tpci200: fix memory leak in the tpci200_register
Date: Mon, 9 Aug 2021 17:32:46 +0200 [thread overview]
Message-ID: <YRFKnvN+jUoOaCiA@kroah.com> (raw)
In-Reply-To: <20210809143049.3531188-2-mudongliangabcd@gmail.com>
On Mon, Aug 09, 2021 at 10:30:27PM +0800, Dongliang Mu wrote:
> The error handling code in tpci200_register does not free interface_regs
> allocated by ioremap and the current version of error handling code is
> problematic.
>
> Fix this by refactoring the error handling code and free interface_regs
> when necessary.
>
> Reported-by: Dongliang Mu <mudongliangabcd@gmail.com>
> Fixes: 43986798fd50 ("ipack: add error handling for ioremap_nocache")
> Signed-off-by: Dongliang Mu <mudongliangabcd@gmail.com>
> ---
> drivers/ipack/carriers/tpci200.c | 24 ++++++++++++++----------
> 1 file changed, 14 insertions(+), 10 deletions(-)
Also for stable?
next prev parent reply other threads:[~2021-08-09 15:34 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-09 14:30 [PATCH v2 1/4] ipack: tpci200: fix many double free issues in tpci200_pci_probe Dongliang Mu
2021-08-09 14:30 ` [PATCH v2 2/4] ipack: tpci200: fix memory leak in the tpci200_register Dongliang Mu
2021-08-09 15:32 ` Greg Kroah-Hartman [this message]
2021-08-09 23:09 ` Dongliang Mu
2021-08-10 6:09 ` Greg Kroah-Hartman
2021-08-09 14:30 ` [PATCH v2 3/4] ipack: tpci200: change pci_iounmap to iounmap Dongliang Mu
2021-08-09 15:33 ` Greg Kroah-Hartman
2021-08-09 18:22 ` kernel test robot
2021-08-09 18:22 ` kernel test robot
2021-08-09 18:29 ` Andy Shevchenko
2021-08-09 21:23 ` kernel test robot
2021-08-09 21:23 ` kernel test robot
2021-08-09 14:30 ` [PATCH v2 4/4] ipack: tpci200: move tpci200_unregister close to tpci200_register Dongliang Mu
2021-08-09 15:33 ` Greg Kroah-Hartman
2021-08-09 23:54 ` Dongliang Mu
2021-08-09 15:32 ` [PATCH v2 1/4] ipack: tpci200: fix many double free issues in tpci200_pci_probe Greg Kroah-Hartman
2021-08-09 23:08 ` Dongliang Mu
2021-08-09 23:41 ` Dongliang Mu
2021-08-10 6:12 ` Greg Kroah-Hartman
2021-08-10 6:27 ` Dongliang Mu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YRFKnvN+jUoOaCiA@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=industrypack-devel@lists.sourceforge.net \
--cc=jens.taprogge@taprogge.org \
--cc=jiazhouyang09@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lyl2019@mail.ustc.edu.cn \
--cc=mudongliangabcd@gmail.com \
--cc=rdunlap@infradead.org \
--cc=siglesias@igalia.com \
--cc=yashsri421@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.