From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.9 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FSL_HELO_FAKE,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2E86CC4338F for ; Wed, 11 Aug 2021 07:57:48 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 08D1660551 for ; Wed, 11 Aug 2021 07:57:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235832AbhHKH6G (ORCPT ); Wed, 11 Aug 2021 03:58:06 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49074 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235506AbhHKH5w (ORCPT ); Wed, 11 Aug 2021 03:57:52 -0400 Received: from mail-wm1-x32a.google.com (mail-wm1-x32a.google.com [IPv6:2a00:1450:4864:20::32a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 17BA2C061765 for ; Wed, 11 Aug 2021 00:57:29 -0700 (PDT) Received: by mail-wm1-x32a.google.com with SMTP id 6so1266731wme.5 for ; Wed, 11 Aug 2021 00:57:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=fwdGYBFgtkOqg6Jmf4Lw7TWs5Ty3SB5HHOMxdZUGSIU=; b=CYpPDOwh8i/ZK3wz1cD++NtBIT2vsMW9FxdhQK83mZxvfUv3mpZIADIbXdpBQWCkV1 JJXOn7lvraaFMao3SNN982YcUzOVUSOcNNAJm1VZTGFzq/24Fke94qtXfTXwfvaai8vD U+NGFKtBnZFrKcDHXkr9NtGjwhhYGJzFL/RjW1rCCrryAHdhmdFtq4iq/8qUT8UsjgPw 5XOWuieIbH8kG6hMdYWcoJqKVP3dOOR/1pQAAErUypVgtBh0QOe9pckV6RGJQOY3vjpm Q3LegtABagGHMmMvyBR9G3wdUjfzcH43lEW7O2k7YF0Q3fJjC8q82RU5BbhbqxDsCh7K +uIA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=fwdGYBFgtkOqg6Jmf4Lw7TWs5Ty3SB5HHOMxdZUGSIU=; b=eme2c45S1ZoiK6ocGNQrzy+aIN6Lq1SbJr9FQo8BvozxMs2MX8NLcI/AVA3R+cp3vY 1gebhmTu2j6M7SF4qZptKkqsVtNVFdugck0rNaoZj70PBRMs6VljMP/s5fD7VBEGHI5k 2Wy4TmdJZlteNx2FIa1j21wHxMSc/1R/nM5e2abeU79pZEa5luCLj+IS5FBlCE+FT2yQ crsPIm40EPLgC/q38z7eONFcaNcjRHnAJWZgSsY/X08/FJDmpActeHuFfii7kY13HhNU Lnx6idB9S3iRMux0gVC4o+DrSw1eVMChOAoiCE1r+naC6bSoeMc7JH3BR2cYsjEtKIgT d1Aw== X-Gm-Message-State: AOAM530+vdVUwh4tRZReDkDKChr4x4TBqBEi6YHsfnw9mWquVS76u+6l ENl6EMaSi6Eqs8JbZ2PRFT7X5w== X-Google-Smtp-Source: ABdhPJzuv3WRP4WOBZMGrILo9gbtARiKtSXE/OqYs5yJ13//2rk/TkadbKotKF/Z+voBJNIhQQLXaw== X-Received: by 2002:a7b:c399:: with SMTP id s25mr8606394wmj.180.1628668647684; Wed, 11 Aug 2021 00:57:27 -0700 (PDT) Received: from google.com ([95.148.6.212]) by smtp.gmail.com with ESMTPSA id h2sm5082806wmm.33.2021.08.11.00.57.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 11 Aug 2021 00:57:26 -0700 (PDT) Date: Wed, 11 Aug 2021 08:57:25 +0100 From: Lee Jones To: Thomas Gleixner Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Ming Lei , Hannes Reinecke Subject: Re: [PATCH 1/1] genirq/cpuhotplug: Bump debugging information print down to KERN_DEBUG Message-ID: References: <20210617073136.315723-1-lee.jones@linaro.org> <8735rhs7n6.ffs@tglx> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <8735rhs7n6.ffs@tglx> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 10 Aug 2021, Thomas Gleixner wrote: > On Thu, Jun 17 2021 at 08:31, Lee Jones wrote: > > This sort of information is only generally useful when debugging. > > > > No need to have these sprinkled through the kernel log otherwise. > > Yes and no. > > > Cc: Thomas Gleixner > > Signed-off-by: Lee Jones > > --- > > kernel/irq/cpuhotplug.c | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/kernel/irq/cpuhotplug.c b/kernel/irq/cpuhotplug.c > > index 02236b13b3599..cf8d4f75632e8 100644 > > --- a/kernel/irq/cpuhotplug.c > > +++ b/kernel/irq/cpuhotplug.c > > @@ -42,7 +42,7 @@ static inline bool irq_needs_fixup(struct irq_data *d) > > * If this happens then there was a missed IRQ fixup at some > > * point. Warn about it and enforce fixup. > > */ > > - pr_warn("Eff. affinity %*pbl of IRQ %u contains only offline CPUs after offlining CPU %u\n", > > This one is clearly a warning as this should not happen. See the > comments around that. > > > + pr_debug("Eff. affinity %*pbl of IRQ %u contains only offline CPUs after offlining CPU %u\n", > > cpumask_pr_args(m), d->irq, cpu); > > return true; > > } > > @@ -166,7 +166,7 @@ void irq_migrate_all_off_this_cpu(void) > > raw_spin_unlock(&desc->lock); > > > > if (affinity_broken) { > > - pr_warn_ratelimited("IRQ %u: no longer affine to CPU%u\n", > > + pr_debug_ratelimited("IRQ %u: no longer affine to CPU%u\n", > > irq, smp_processor_id()); > > Maybe, but distro people might have opinions on that. The trouble is, even if these are real warnings, they have an affect on performance on real products. To the point where so much logging builds up during pre-release testing, that it sets off the watchdog(s) on some high profile consumer devices. What would you suggest? -- Lee Jones [李琼斯] Senior Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,FSL_HELO_FAKE,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 55C4FC4320E for ; Wed, 11 Aug 2021 07:59:39 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 17EAC60F38 for ; Wed, 11 Aug 2021 07:59:39 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 17EAC60F38 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=6IBNvRRsQ0Nf4IidLlXlvSpwVGhpHnLiiKHI6+CipMo=; b=VIu2NNKm8DgsRs VCWbqWmyQVNUJmBkyhhGR5xP2beOQNYPW+2YD4nXwBHsAh+eE6cM92otBk88jkWLE/kjAdkIEmZSF ahBhYQS4dqpDIKi6S3h24v7A9jSl77HBWjk2iOa99TTFxcJgeE5t3GnXXELniz9AaSr7Fm7gfpYu+ IR23e5ywgPoCcR1FaToRu34cqGqXR5qeUS56G8ZyaJEkJ6mu5BIazLq4A+5IBT50iTCEBp5uIL6Uq MJy5sLAOi6g9ka/1BByQJNNLMFRSHotZ8QCavo3TqXeCTIsGrgnESKAf1SXzAQ++NUK4m1Na9DfrY 0MzVkdg2I4HzCq4JAEJQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mDj7K-005wev-Hw; Wed, 11 Aug 2021 07:57:38 +0000 Received: from mail-wm1-x332.google.com ([2a00:1450:4864:20::332]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mDj7D-005wdo-W4 for linux-arm-kernel@lists.infradead.org; Wed, 11 Aug 2021 07:57:35 +0000 Received: by mail-wm1-x332.google.com with SMTP id k4so1273560wms.3 for ; Wed, 11 Aug 2021 00:57:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=fwdGYBFgtkOqg6Jmf4Lw7TWs5Ty3SB5HHOMxdZUGSIU=; b=CYpPDOwh8i/ZK3wz1cD++NtBIT2vsMW9FxdhQK83mZxvfUv3mpZIADIbXdpBQWCkV1 JJXOn7lvraaFMao3SNN982YcUzOVUSOcNNAJm1VZTGFzq/24Fke94qtXfTXwfvaai8vD U+NGFKtBnZFrKcDHXkr9NtGjwhhYGJzFL/RjW1rCCrryAHdhmdFtq4iq/8qUT8UsjgPw 5XOWuieIbH8kG6hMdYWcoJqKVP3dOOR/1pQAAErUypVgtBh0QOe9pckV6RGJQOY3vjpm Q3LegtABagGHMmMvyBR9G3wdUjfzcH43lEW7O2k7YF0Q3fJjC8q82RU5BbhbqxDsCh7K +uIA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=fwdGYBFgtkOqg6Jmf4Lw7TWs5Ty3SB5HHOMxdZUGSIU=; b=pIM4FVE496MFxF0uLju6fR4TL4lJlJA+EW1UVNuWMM6gsF2rLt7f+YShMj0O+7IBrk 7BAqu/CzcrSF2eD8G1E63Vberw32zseOx1lYW2dYw0b0Y3lzxbGWfAcr4p3u+1mOU5Vk 5/YicbDqftoRLnYvkHOgYX0o0FXg0gUTOLxOrhcxBo/6Ttzu1sBKdJ3mj9GT3o5Aayz8 XAsa1zGbGcjDd91nzy3euqKqWehpZpH6I9CiAWx+bB7bApg8zIYNqWFc1P9fI1KQ6iHg 7fC6ZNTJ66BuxKpgvht2YQe/7rXFO4gkgR5N4w5YFZFQARABxFnQ92G8Ov4GaZuMB52E eUKA== X-Gm-Message-State: AOAM533KXX3Yz3lfp8REFb8M94WlfNW5MSShmrfmDK95Q7g+en5M3uYS t6+M55xcCKuTPlXQakW1CoyH+A== X-Google-Smtp-Source: ABdhPJzuv3WRP4WOBZMGrILo9gbtARiKtSXE/OqYs5yJ13//2rk/TkadbKotKF/Z+voBJNIhQQLXaw== X-Received: by 2002:a7b:c399:: with SMTP id s25mr8606394wmj.180.1628668647684; Wed, 11 Aug 2021 00:57:27 -0700 (PDT) Received: from google.com ([95.148.6.212]) by smtp.gmail.com with ESMTPSA id h2sm5082806wmm.33.2021.08.11.00.57.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 11 Aug 2021 00:57:26 -0700 (PDT) Date: Wed, 11 Aug 2021 08:57:25 +0100 From: Lee Jones To: Thomas Gleixner Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Ming Lei , Hannes Reinecke Subject: Re: [PATCH 1/1] genirq/cpuhotplug: Bump debugging information print down to KERN_DEBUG Message-ID: References: <20210617073136.315723-1-lee.jones@linaro.org> <8735rhs7n6.ffs@tglx> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <8735rhs7n6.ffs@tglx> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210811_005732_086431_5878A402 X-CRM114-Status: GOOD ( 25.30 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gVHVlLCAxMCBBdWcgMjAyMSwgVGhvbWFzIEdsZWl4bmVyIHdyb3RlOgoKPiBPbiBUaHUsIEp1 biAxNyAyMDIxIGF0IDA4OjMxLCBMZWUgSm9uZXMgd3JvdGU6Cj4gPiBUaGlzIHNvcnQgb2YgaW5m b3JtYXRpb24gaXMgb25seSBnZW5lcmFsbHkgdXNlZnVsIHdoZW4gZGVidWdnaW5nLgo+ID4KPiA+ IE5vIG5lZWQgdG8gaGF2ZSB0aGVzZSBzcHJpbmtsZWQgdGhyb3VnaCB0aGUga2VybmVsIGxvZyBv dGhlcndpc2UuCj4gCj4gWWVzIGFuZCBuby4gCj4gCj4gPiBDYzogVGhvbWFzIEdsZWl4bmVyIDx0 Z2x4QGxpbnV0cm9uaXguZGU+Cj4gPiBTaWduZWQtb2ZmLWJ5OiBMZWUgSm9uZXMgPGxlZS5qb25l c0BsaW5hcm8ub3JnPgo+ID4gLS0tCj4gPiAga2VybmVsL2lycS9jcHVob3RwbHVnLmMgfCA0ICsr LS0KPiA+ICAxIGZpbGUgY2hhbmdlZCwgMiBpbnNlcnRpb25zKCspLCAyIGRlbGV0aW9ucygtKQo+ ID4KPiA+IGRpZmYgLS1naXQgYS9rZXJuZWwvaXJxL2NwdWhvdHBsdWcuYyBiL2tlcm5lbC9pcnEv Y3B1aG90cGx1Zy5jCj4gPiBpbmRleCAwMjIzNmIxM2IzNTk5Li5jZjhkNGY3NTYzMmU4IDEwMDY0 NAo+ID4gLS0tIGEva2VybmVsL2lycS9jcHVob3RwbHVnLmMKPiA+ICsrKyBiL2tlcm5lbC9pcnEv Y3B1aG90cGx1Zy5jCj4gPiBAQCAtNDIsNyArNDIsNyBAQCBzdGF0aWMgaW5saW5lIGJvb2wgaXJx X25lZWRzX2ZpeHVwKHN0cnVjdCBpcnFfZGF0YSAqZCkKPiA+ICAJCSAqIElmIHRoaXMgaGFwcGVu cyB0aGVuIHRoZXJlIHdhcyBhIG1pc3NlZCBJUlEgZml4dXAgYXQgc29tZQo+ID4gIAkJICogcG9p bnQuIFdhcm4gYWJvdXQgaXQgYW5kIGVuZm9yY2UgZml4dXAuCj4gPiAgCQkgKi8KPiA+IC0JCXBy X3dhcm4oIkVmZi4gYWZmaW5pdHkgJSpwYmwgb2YgSVJRICV1IGNvbnRhaW5zIG9ubHkgb2ZmbGlu ZSBDUFVzIGFmdGVyIG9mZmxpbmluZyBDUFUgJXVcbiIsCj4gCj4gVGhpcyBvbmUgaXMgY2xlYXJs eSBhIHdhcm5pbmcgYXMgdGhpcyBzaG91bGQgbm90IGhhcHBlbi4gU2VlIHRoZQo+IGNvbW1lbnRz IGFyb3VuZCB0aGF0Lgo+IAo+ID4gKwkJcHJfZGVidWcoIkVmZi4gYWZmaW5pdHkgJSpwYmwgb2Yg SVJRICV1IGNvbnRhaW5zIG9ubHkgb2ZmbGluZSBDUFVzIGFmdGVyIG9mZmxpbmluZyBDUFUgJXVc biIsCj4gPiAgCQkJY3B1bWFza19wcl9hcmdzKG0pLCBkLT5pcnEsIGNwdSk7Cj4gPiAgCQlyZXR1 cm4gdHJ1ZTsKPiA+ICAJfQo+ID4gQEAgLTE2Niw3ICsxNjYsNyBAQCB2b2lkIGlycV9taWdyYXRl X2FsbF9vZmZfdGhpc19jcHUodm9pZCkKPiA+ICAJCXJhd19zcGluX3VubG9jaygmZGVzYy0+bG9j ayk7Cj4gPiAgCj4gPiAgCQlpZiAoYWZmaW5pdHlfYnJva2VuKSB7Cj4gPiAtCQkJcHJfd2Fybl9y YXRlbGltaXRlZCgiSVJRICV1OiBubyBsb25nZXIgYWZmaW5lIHRvIENQVSV1XG4iLAo+ID4gKwkJ CXByX2RlYnVnX3JhdGVsaW1pdGVkKCJJUlEgJXU6IG5vIGxvbmdlciBhZmZpbmUgdG8gQ1BVJXVc biIsCj4gPiAgCQkJCQkgICAgaXJxLCBzbXBfcHJvY2Vzc29yX2lkKCkpOwo+IAo+IE1heWJlLCBi dXQgZGlzdHJvIHBlb3BsZSBtaWdodCBoYXZlIG9waW5pb25zIG9uIHRoYXQuCgpUaGUgdHJvdWJs ZSBpcywgZXZlbiBpZiB0aGVzZSBhcmUgcmVhbCB3YXJuaW5ncywgdGhleSBoYXZlIGFuIGFmZmVj dApvbiBwZXJmb3JtYW5jZSBvbiByZWFsIHByb2R1Y3RzLiAgVG8gdGhlIHBvaW50IHdoZXJlIHNv IG11Y2ggbG9nZ2luZwpidWlsZHMgdXAgZHVyaW5nIHByZS1yZWxlYXNlIHRlc3RpbmcsIHRoYXQg aXQgc2V0cyBvZmYgdGhlIHdhdGNoZG9nKHMpCm9uIHNvbWUgaGlnaCBwcm9maWxlIGNvbnN1bWVy IGRldmljZXMuCgpXaGF0IHdvdWxkIHlvdSBzdWdnZXN0PwoKLS0gCkxlZSBKb25lcyBb5p2O55C8 5pavXQpTZW5pb3IgVGVjaG5pY2FsIExlYWQgLSBEZXZlbG9wZXIgU2VydmljZXMKTGluYXJvLm9y ZyDilIIgT3BlbiBzb3VyY2Ugc29mdHdhcmUgZm9yIEFybSBTb0NzCkZvbGxvdyBMaW5hcm86IEZh Y2Vib29rIHwgVHdpdHRlciB8IEJsb2cKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fCmxpbnV4LWFybS1rZXJuZWwgbWFpbGluZyBsaXN0CmxpbnV4LWFybS1r ZXJuZWxAbGlzdHMuaW5mcmFkZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWls bWFuL2xpc3RpbmZvL2xpbnV4LWFybS1rZXJuZWwK