From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.7 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 56988C4320E for ; Wed, 11 Aug 2021 12:50:42 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3CF4A60FE6 for ; Wed, 11 Aug 2021 12:50:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230281AbhHKMvD (ORCPT ); Wed, 11 Aug 2021 08:51:03 -0400 Received: from mga07.intel.com ([134.134.136.100]:51583 "EHLO mga07.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229793AbhHKMvD (ORCPT ); Wed, 11 Aug 2021 08:51:03 -0400 X-IronPort-AV: E=McAfee;i="6200,9189,10072"; a="278861581" X-IronPort-AV: E=Sophos;i="5.84,313,1620716400"; d="scan'208";a="278861581" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Aug 2021 05:50:39 -0700 X-IronPort-AV: E=Sophos;i="5.84,313,1620716400"; d="scan'208";a="590083571" Received: from smile.fi.intel.com (HELO smile) ([10.237.68.40]) by fmsmga001-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Aug 2021 05:50:36 -0700 Received: from andy by smile with local (Exim 4.94.2) (envelope-from ) id 1mDngk-007pI5-Q6; Wed, 11 Aug 2021 15:50:30 +0300 Date: Wed, 11 Aug 2021 15:50:30 +0300 From: Andy Shevchenko To: Sergey Ryazanov Cc: "David S. Miller" , netdev , open list , Loic Poulain , Johannes Berg , Jakub Kicinski Subject: Re: [PATCH v2 2/2] wwan: core: Unshadow error code returned by ida_alloc_range)) Message-ID: References: <20210806085413.61536-1-andriy.shevchenko@linux.intel.com> <20210806085413.61536-2-andriy.shevchenko@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Aug 06, 2021 at 11:35:04PM +0300, Sergey Ryazanov wrote: > On Fri, Aug 6, 2021 at 5:20 PM Andy Shevchenko > wrote: > > On Fri, Aug 6, 2021 at 5:14 PM Sergey Ryazanov wrote: > >> On Fri, Aug 6, 2021 at 12:00 PM Andy Shevchenko > >> wrote: > >>> ida_alloc_range)) may return other than -ENOMEM error code. > >>> Unshadow it in the wwan_create_port(). > >>> > >>> Signed-off-by: Andy Shevchenko > >> > >> A small nitpick, looks like "ida_alloc_range))" in the description is > >> a typo and should be "ida_alloc_range()". Besides this: > > > > Shall I resend? > > Yes, please. And specify the target tree in the subject, please. See > patchwork warning [1, 2]. The first patch is a clear bug fix, so it > should be targeted to the 'net' tree, while the second patch despite > its usefulness could not be considered a bug fix, so it should be > targeted to the 'net-next' tree. Subjects could be like this: > > [PATCHv3 net 1/2] wwan: core: Avoid returning NULL from wwan_create_dev() > [PATCHv3 net-next 2/2] wwan: core: Unshadow error code returned by > ida_alloc_range() > > Or since the second patch is not depends on the first one and patches > target different trees, patches could be submitted independently: > > [PATCHv3 net] wwan: core: Avoid returning NULL from wwan_create_dev() > [PATCHv3 net-next] wwan: core: Unshadow error code returned by ida_alloc_range() Split and sent separately, thanks! > 1. https://patchwork.kernel.org/project/netdevbpf/patch/20210806085413.61536-1-andriy.shevchenko@linux.intel.com/ > 2. https://patchwork.kernel.org/project/netdevbpf/patch/20210806085413.61536-2-andriy.shevchenko@linux.intel.com/ -- With Best Regards, Andy Shevchenko