From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BFA28C4338F for ; Wed, 11 Aug 2021 12:56:13 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A39F760F38 for ; Wed, 11 Aug 2021 12:56:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230018AbhHKM4g (ORCPT ); Wed, 11 Aug 2021 08:56:36 -0400 Received: from mga07.intel.com ([134.134.136.100]:51935 "EHLO mga07.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229737AbhHKM4e (ORCPT ); Wed, 11 Aug 2021 08:56:34 -0400 X-IronPort-AV: E=McAfee;i="6200,9189,10072"; a="278862257" X-IronPort-AV: E=Sophos;i="5.84,313,1620716400"; d="scan'208";a="278862257" Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Aug 2021 05:56:10 -0700 X-IronPort-AV: E=Sophos;i="5.84,313,1620716400"; d="scan'208";a="639153610" Received: from smile.fi.intel.com (HELO smile) ([10.237.68.40]) by orsmga005-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Aug 2021 05:56:09 -0700 Received: from andy by smile with local (Exim 4.94.2) (envelope-from ) id 1mDnm7-007pMn-81; Wed, 11 Aug 2021 15:56:03 +0300 Date: Wed, 11 Aug 2021 15:56:03 +0300 From: Andy Shevchenko To: Linus Walleij Cc: "open list:GPIO SUBSYSTEM" , linux-kernel , Bartosz Golaszewski Subject: Re: [PATCH v1 1/1] gpiolib: Deduplicate forward declaration in the consumer.h header Message-ID: References: <20210803173925.57216-1-andriy.shevchenko@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org On Wed, Aug 11, 2021 at 02:05:40PM +0200, Linus Walleij wrote: > On Tue, Aug 3, 2021 at 7:39 PM Andy Shevchenko > wrote: > > > struct acpi_device is repeated in two branches of ifdeffery. > > Move it out and hence deduplicate. > > > > Signed-off-by: Andy Shevchenko > > That's neat! > Reviewed-by: Linus Walleij Thanks! Bart, I'll send this inside my usual PR in terms of GPIO ACPI support. -- With Best Regards, Andy Shevchenko