From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 445A5C4320A for ; Wed, 11 Aug 2021 14:21:34 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 2726D60E78 for ; Wed, 11 Aug 2021 14:21:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232460AbhHKOV4 (ORCPT ); Wed, 11 Aug 2021 10:21:56 -0400 Received: from vps0.lunn.ch ([185.16.172.187]:45150 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232341AbhHKOVy (ORCPT ); Wed, 11 Aug 2021 10:21:54 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Disposition:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:From:Sender:Reply-To:Subject: Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Content-Disposition:In-Reply-To:References; bh=hKc2VUZOlUn7+9qhTayubrmJeEFnKYw+IpcOlyGgPPk=; b=PbyC/yxQGYgnOdQZDAa0h8cp6m Qlzmv+ahlLg98NOGhtKsPTjc5n4pywyf0RD2mgvwWFJpCpJOwSLsu/y58jWtQNZO5bTSbHSy3cQS3 4PsgXxyKHPz9IbUkdqdRUBChsNzWnr6T2OhDC2hLQDR7n57+YaDf/GW9w/bBFFq6NEbY=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1mDp6G-00H7vb-PU; Wed, 11 Aug 2021 16:20:56 +0200 Date: Wed, 11 Aug 2021 16:20:56 +0200 From: Andrew Lunn To: Florian Fainelli Cc: Wong Vee Khee , Vivien Didelot , "David S . Miller" , Jakub Kicinski , Giuseppe Cavallaro , Alexandre Torgue , Jose Abreu , Maxime Coquelin , Heiner Kallweit , Russell King , Voon Weifeng , Michael Sit Wei Hong , Vladimir Oltean , linux-arm-kernel@lists.infradead.org, linux-stm32@st-md-mailman.stormreply.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH net-next 1/2] net: pcs: xpcs: enable skip xPCS soft reset Message-ID: References: <20210809102229.933748-1-vee.khee.wong@linux.intel.com> <20210809102229.933748-2-vee.khee.wong@linux.intel.com> <20210810235529.GB30818@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > > BIOS does configured the SerDes. The problem here is that all the > > configurations done by BIOS are being reset at xpcs_create(). > > > > We would want user of the pcs-xpcs module (stmmac, sja1105) to have > > control whether or not we need to perform to the soft reset in the > > xpcs_create() call. > > I understood Andrew's response as suggesting to introduce the ability for > xpcs_create() to make a BIOS call which would configure the SerDes after > xpcs_soft_reset(). Yes. Exactly. That is what ACPI is for, so we should use it for this. Andrew From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 876D9C4338F for ; Wed, 11 Aug 2021 14:23:23 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 426C46101D for ; Wed, 11 Aug 2021 14:23:23 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 426C46101D Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lunn.ch Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=mKDB9I3Ut67DSR6g+vA95V5XqAX1ZQT8KG34Zpq9Ftg=; b=a7vhZWlQcX0kQW taPxR39VWne69x40gRNWFsPCvuM3arsdXO+M7ziFe5eWzlL0i8uCLMYcZUKeZwP4Ja/GGMlIQHmRY sCkWKBYnNW9tPg3eO/pINgINjencobyJbU4O1H9Fz7QWbkuBslGlL4k0FQ9Vdz6sMW1sqLIA3RaPy YbqY/v/tfjTjx3TiF5dlwxIrXRV+BrsM78wj+kvtCq6zSj48nUbRsJM/c5nOF5OS6mDIjmmiYpGRt g4sn+7jv6u5ArNk4IKriTKV2FMOYo4gwzA5OUymMBqXQhuSBb/wWhIJ9GtiEH7sRA07a6Hgs41M3k tN4KgGIZbyMYIrDVQM9A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mDp6s-007Rlv-Um; Wed, 11 Aug 2021 14:21:35 +0000 Received: from vps0.lunn.ch ([185.16.172.187]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mDp6n-007RlN-4T for linux-arm-kernel@lists.infradead.org; Wed, 11 Aug 2021 14:21:33 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Disposition:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:From:Sender:Reply-To:Subject: Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Content-Disposition:In-Reply-To:References; bh=hKc2VUZOlUn7+9qhTayubrmJeEFnKYw+IpcOlyGgPPk=; b=PbyC/yxQGYgnOdQZDAa0h8cp6m Qlzmv+ahlLg98NOGhtKsPTjc5n4pywyf0RD2mgvwWFJpCpJOwSLsu/y58jWtQNZO5bTSbHSy3cQS3 4PsgXxyKHPz9IbUkdqdRUBChsNzWnr6T2OhDC2hLQDR7n57+YaDf/GW9w/bBFFq6NEbY=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1mDp6G-00H7vb-PU; Wed, 11 Aug 2021 16:20:56 +0200 Date: Wed, 11 Aug 2021 16:20:56 +0200 From: Andrew Lunn To: Florian Fainelli Cc: Wong Vee Khee , Vivien Didelot , "David S . Miller" , Jakub Kicinski , Giuseppe Cavallaro , Alexandre Torgue , Jose Abreu , Maxime Coquelin , Heiner Kallweit , Russell King , Voon Weifeng , Michael Sit Wei Hong , Vladimir Oltean , linux-arm-kernel@lists.infradead.org, linux-stm32@st-md-mailman.stormreply.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH net-next 1/2] net: pcs: xpcs: enable skip xPCS soft reset Message-ID: References: <20210809102229.933748-1-vee.khee.wong@linux.intel.com> <20210809102229.933748-2-vee.khee.wong@linux.intel.com> <20210810235529.GB30818@linux.intel.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210811_072129_214649_CD949905 X-CRM114-Status: GOOD ( 12.08 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org > > BIOS does configured the SerDes. The problem here is that all the > > configurations done by BIOS are being reset at xpcs_create(). > > > > We would want user of the pcs-xpcs module (stmmac, sja1105) to have > > control whether or not we need to perform to the soft reset in the > > xpcs_create() call. > > I understood Andrew's response as suggesting to introduce the ability for > xpcs_create() to make a BIOS call which would configure the SerDes after > xpcs_soft_reset(). Yes. Exactly. That is what ACPI is for, so we should use it for this. Andrew _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel