From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0FA97C4338F for ; Wed, 11 Aug 2021 23:30:25 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E032D6101D for ; Wed, 11 Aug 2021 23:30:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232830AbhHKXas (ORCPT ); Wed, 11 Aug 2021 19:30:48 -0400 Received: from cloud.peff.net ([104.130.231.41]:44922 "EHLO cloud.peff.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232725AbhHKXar (ORCPT ); Wed, 11 Aug 2021 19:30:47 -0400 Received: (qmail 23890 invoked by uid 109); 11 Aug 2021 23:30:23 -0000 Received: from Unknown (HELO peff.net) (10.0.1.2) by cloud.peff.net (qpsmtpd/0.94) with ESMTP; Wed, 11 Aug 2021 23:30:23 +0000 Authentication-Results: cloud.peff.net; auth=none Received: (qmail 16319 invoked by uid 111); 11 Aug 2021 23:30:23 -0000 Received: from coredump.intra.peff.net (HELO sigill.intra.peff.net) (10.0.0.2) by peff.net (qpsmtpd/0.94) with (TLS_AES_256_GCM_SHA384 encrypted) ESMTPS; Wed, 11 Aug 2021 19:30:23 -0400 Authentication-Results: peff.net; auth=none Date: Wed, 11 Aug 2021 19:30:22 -0400 From: Jeff King To: "brian m. carlson" Cc: git@vger.kernel.org, Junio C Hamano , =?utf-8?B?w4Z2YXIgQXJuZmrDtnLDsA==?= Bjarmason , Son Luong Ngoc Subject: Re: [PATCH v2] t5607: avoid using prerequisites to select algorithm Message-ID: References: <20210811231644.570030-1-sandals@crustytoothpaste.net> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20210811231644.570030-1-sandals@crustytoothpaste.net> Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org On Wed, Aug 11, 2021 at 11:16:44PM +0000, brian m. carlson wrote: > In this test, we currently use the SHA1 prerequisite to specify the > algorithm we're using to test, since SHA-256 bundles are always v3, > whereas SHA-1 bundles default to v2, and as a result the default output > differs. > > However, this causes a problem if we run with GIT_TEST_FAIL_PREREQS set, > since that means that we'll unexpectedly fail the SHA1 prerequisite, > resulting in incorrect expected output. Let's fix this by checking > against the built-in data called "algo", which tells us which algorithm > is in use. This should work in any situation, making our test a little > more robust. Thanks, this seems like a reasonable step, and fixes the test for me. I still get tons of other failures because I set GIT_TEST_HTTPD=yes, which implies to me we should still be fixing GIT_TEST_FAIL_PREREQS. But I am happy to take this in the meantime for people who do care. -Peff