From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9067AC4338F for ; Fri, 13 Aug 2021 10:32:06 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 710686109E for ; Fri, 13 Aug 2021 10:32:05 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 710686109E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id D57B81890; Fri, 13 Aug 2021 12:31:13 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz D57B81890 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1628850723; bh=XdbaZK3e/Y4S1CI0OQ+z4VQ+k5YeTjMqSSJmyqWFErU=; h=Date:From:To:Subject:References:In-Reply-To:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=NXatSJs4oPl5KcKfD1FRcub4j4eVwb37x55AEIPLFuB2Htgm8SF0QsPfVXFWiWZMp PeeygntaB+Qj2QFTE7ynWey6mHIaf+hcn1jDomkUFFl5jxX97IymmsWS8HSHQ6+aK3 qIxvzeIXSVL3U8ij48AqSg1Igl1puydGI178F//8= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 7259AF8020D; Fri, 13 Aug 2021 12:31:13 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 29E25F802D2; Fri, 13 Aug 2021 12:31:12 +0200 (CEST) Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 518F2F800E5 for ; Fri, 13 Aug 2021 12:31:01 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 518F2F800E5 X-IronPort-AV: E=McAfee;i="6200,9189,10074"; a="301125184" X-IronPort-AV: E=Sophos;i="5.84,318,1620716400"; d="scan'208";a="301125184" Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Aug 2021 03:31:00 -0700 X-IronPort-AV: E=Sophos;i="5.84,318,1620716400"; d="scan'208";a="674271543" Received: from smile.fi.intel.com (HELO smile) ([10.237.68.40]) by fmsmga006-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Aug 2021 03:30:58 -0700 Received: from andy by smile with local (Exim 4.94.2) (envelope-from ) id 1mEUSi-00924n-6I; Fri, 13 Aug 2021 13:30:52 +0300 Date: Fri, 13 Aug 2021 13:30:52 +0300 From: Andy Shevchenko To: Pierre-Louis Bossart Subject: Re: [PATCH v2 0/8] ASoC: Intel: boards: use software node API Message-ID: References: <20210812224443.170144-1-pierre-louis.bossart@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210812224443.170144-1-pierre-louis.bossart@linux.intel.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Cc: tiwai@suse.de, Hans de Goede , alsa-devel@alsa-project.org, broonie@kernel.org, Heikki Krogerus X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On Thu, Aug 12, 2021 at 05:44:35PM -0500, Pierre-Louis Bossart wrote: > This is an update on an earlier contribution from Heikki Krogerus > > The function device_add_properties() is going to be removed. > Replacing it with software node API equivalents. > > Thanks for Hans de Goede and Andy Shevchenko for their comments, > suggestions and Reviewed-by tags on GitHub. The review thread can be > found at https://github.com/thesofproject/linux/pull/3041) For all non-commented Reviewed-by: Andy Shevchenko > v2 changes: feedback from Andy and Hans > Better error handling > Codec reference is kept until the .remove callback > Remove bus search to find device > > v1 changes from Heikki's patches: > Avoid the use of devm_ routines for Baytrail machine drivers. > > Heikki Krogerus (1): > ASoC: Intel: boards: use software node API in Atom boards > > Pierre-Louis Bossart (7): > ASoC: Intel: boards: harden codec property handling > ASoC: Intel: boards: handle errors with acpi_dev_get_first_match_dev() > ASoC: Intel: boards: get codec device with ACPI instead of bus search > ASoC: Intel: sof_sdw: pass card information to init/exit functions > ASoC: Intel: sof_sdw_rt711*: keep codec device reference until remove > ASoC: Intel: use software node API in SoundWire machines > ASoC: Intel: remove device_properties for Atom boards > > sound/soc/intel/boards/bytcht_es8316.c | 31 ++++++++-- > sound/soc/intel/boards/bytcr_rt5640.c | 57 ++++++++++++++----- > sound/soc/intel/boards/bytcr_rt5651.c | 63 ++++++++++++++------- > sound/soc/intel/boards/sof_sdw.c | 20 ++++--- > sound/soc/intel/boards/sof_sdw_common.h | 37 +++++++----- > sound/soc/intel/boards/sof_sdw_max98373.c | 3 +- > sound/soc/intel/boards/sof_sdw_rt1308.c | 3 +- > sound/soc/intel/boards/sof_sdw_rt1316.c | 3 +- > sound/soc/intel/boards/sof_sdw_rt5682.c | 3 +- > sound/soc/intel/boards/sof_sdw_rt700.c | 3 +- > sound/soc/intel/boards/sof_sdw_rt711.c | 51 +++++++++-------- > sound/soc/intel/boards/sof_sdw_rt711_sdca.c | 52 +++++++++-------- > sound/soc/intel/boards/sof_sdw_rt715.c | 3 +- > sound/soc/intel/boards/sof_sdw_rt715_sdca.c | 3 +- > 14 files changed, 221 insertions(+), 111 deletions(-) > > -- > 2.25.1 > -- With Best Regards, Andy Shevchenko