From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.0 required=3.0 tests=BAYES_00,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B306AC4320A for ; Fri, 13 Aug 2021 18:11:18 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 935DB610CC for ; Fri, 13 Aug 2021 18:11:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232698AbhHMSLo (ORCPT ); Fri, 13 Aug 2021 14:11:44 -0400 Received: from mail-ot1-f54.google.com ([209.85.210.54]:40516 "EHLO mail-ot1-f54.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229612AbhHMSLn (ORCPT ); Fri, 13 Aug 2021 14:11:43 -0400 Received: by mail-ot1-f54.google.com with SMTP id h63-20020a9d14450000b02904ce97efee36so13036558oth.7; Fri, 13 Aug 2021 11:11:16 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=LPzED54xeKgTV0uzpxN25ycvgJ7+FnU0XzwWfHIGp+M=; b=dDJgmPyy1TLYFPtdQcVksT1WJVApRCL7jHpWiOrCZbcZ2T7D8pR1p/bxM61F9VPxP1 8v6OKbFJPQSpJ3VqLmgFn0Pf3uNjK/hMfkLeNVeuTvDXF5yuoXu2H+xwe/REosUJ8BMy F+AQLLvW73JDsgX0o5tZmwEK/xl4IdXL+7HOuvhagtUNaCi1VOelv+LwYWsAr4OErRcL bJz/r1At15AH4WAVrQl+vY8mqeYasKIsyuG2K8IS+6eEQQPVNzAAUzlca6S0+6GljXlZ rxBsicw6JkV/9vUNXA2y+nsNZtjdbFtFplYYjaSPlJ9cl1Ox3iE+/YAUjUd7fsmZWTcF UZrw== X-Gm-Message-State: AOAM531ykPe7TbayIhATpUXQvgbdtkj9ap5vfk74T+2kCicMRXhdhR7g UOaWAb1fsU0deqnQ8yxdlQ== X-Google-Smtp-Source: ABdhPJz8TQwhStwIV9j8ES8mQkAGtJtCOHamui/b/Nfn3PlJ7eO4OR+QBnqqGox4c2KtcK7WKRRqGA== X-Received: by 2002:a9d:5e5:: with SMTP id 92mr3056054otd.193.1628878275680; Fri, 13 Aug 2021 11:11:15 -0700 (PDT) Received: from robh.at.kernel.org (24-155-109-49.dyn.grandenetworks.net. [24.155.109.49]) by smtp.gmail.com with ESMTPSA id g13sm218710oos.39.2021.08.13.11.11.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 13 Aug 2021 11:11:15 -0700 (PDT) Received: (nullmailer pid 3786586 invoked by uid 1000); Fri, 13 Aug 2021 18:11:13 -0000 Date: Fri, 13 Aug 2021 13:11:13 -0500 From: Rob Herring To: Andreas =?iso-8859-1?Q?F=E4rber?= Cc: Chester Lin , Greg Kroah-Hartman , s32@nxp.com, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-serial@vger.kernel.org, Shawn Guo , Krzysztof Kozlowski , Oleksij Rempel , Stefan Riedmueller , Matthias Schiffer , Li Yang , Fabio Estevam , Matteo Lisi , Frieder Schrempf , Tim Harvey , Jagan Teki , catalin-dan.udma@nxp.com, bogdan.hamciuc@nxp.com, bogdan.folea@nxp.com, ciprianmarian.costea@nxp.com, radu-nicolae.pirea@nxp.com, ghennadi.procopciuc@nxp.com, Matthias Brugger , "Ivan T . Ivanov" , "Lee, Chun-Yi" Subject: Re: [PATCH 3/8] dt-bindings: serial: fsl-linflexuart: Add compatible for S32G2 Message-ID: References: <20210805065429.27485-1-clin@suse.com> <20210805065429.27485-4-clin@suse.com> <96c02ee6-cd3a-59df-0b3b-1632bb355019@suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <96c02ee6-cd3a-59df-0b3b-1632bb355019@suse.de> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Aug 12, 2021 at 06:27:57PM +0200, Andreas Färber wrote: > On 05.08.21 08:54, Chester Lin wrote: > > Add a compatible string for the uart binding of NXP S32G2 platforms. Here > > we use "s32v234-linflexuart" as fallback since the current linflexuart > > driver still works on S32G2. > > > > Signed-off-by: Chester Lin > > --- > > .../bindings/serial/fsl,s32-linflexuart.yaml | 26 ++++++++++++++++--- > > 1 file changed, 22 insertions(+), 4 deletions(-) > > > > diff --git a/Documentation/devicetree/bindings/serial/fsl,s32-linflexuart.yaml b/Documentation/devicetree/bindings/serial/fsl,s32-linflexuart.yaml > > index acfe34706ccb..e731f3f6cea4 100644 > > --- a/Documentation/devicetree/bindings/serial/fsl,s32-linflexuart.yaml > > +++ b/Documentation/devicetree/bindings/serial/fsl,s32-linflexuart.yaml > > @@ -21,10 +21,20 @@ allOf: > > > > properties: > > compatible: > > - description: The LINFlexD controller on S32V234 SoC, which can be > > - configured in UART mode. > > - items: > > - - const: fsl,s32v234-linflexuart > > + minItems: 1 > > + maxItems: 2 > > Are these necessary for oneOf? > > > + oneOf: > > + - description: The LINFlexD controller on S32G2 SoC, which can be > > + configured in UART mode. > > + items: > > + - enum: > > + - fsl,s32g2-linflexuart > > + - const: fsl,s32v234-linflexuart > > This reads inconsistent to me: Either this oneOf is for S32G2 only, then > please turn the enum into a const. Or change the description to "on SoCs > compatible with S32V234" if we expect the enum list to grow. > > I believe the idea here was to avoid unnecessary driver compatible and > earlycon compatible additions, while preparing for eventual quirks > specific to S32G2. > > @NXP: Should this be s32g2- like above or s32g274a- specifically? Do you > agree this is a useful thing to prepare here, as opposed to using only > s32v234- in the s32g2* DT? > > I assume the ordering is done alphabetically as S32G < S32V; > alternatively we might order S32V234 first and then the compatible ones. > > > + > > + - description: The LINFlexD controller on S32V234 SoC, which can be > > + configured in UART mode. > > + items: > > + - const: fsl,s32v234-linflexuart > > To minimize this S32G2 patch, would it be valid to do oneOf for the > single S32V in the preceding patch already? Then we would avoid the text > movement and re-indentation above and more easily see the lines newly > getting added for S32G2. > > > > > reg: > > maxItems: 1 > > @@ -41,8 +51,16 @@ unevaluatedProperties: false > > > > examples: > > - | > > + /* S32V234 */ > > Could this be: > - description: S32V234 > | > ? No, that would not be valid json-schema. Rob From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7F145C4338F for ; Fri, 13 Aug 2021 18:13:12 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 38A4B610CC for ; Fri, 13 Aug 2021 18:13:12 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 38A4B610CC Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=N/SQfIqfaoAPP8MSvwHz2FVi30QV1hBvqV1ruEejH6g=; b=MTh8dJd0OOzzE2 lSb2mo+kY9ECApxCrTe34LpxXCmdn/1BBdmrlSIy/o5dyOoFkXXcYslDyxlsd9S2pErBXung/Iaoc 5mcFN8v8B3CLmoVLw/3McunXQZvgPalgK/FkfuLBtKWEMzTrIiP3Bu4XJiL2nBI2BoGB8M4ERXmqm RRHy9dcZY/6GJO/co/wxNgyWe5lKtMoo35Ibnj2gnhJGNsCROin/ednu976UiZjDCsipzB1cbpOGB kQq6gmKtRAOT6M+6oLKDZ7WkX1R7oGV5aGgIatY/tS996DjykpuBBZPrd+E+C2RU8xOrmB16HgFu/ JiRp8FooVgnDszsJbMWw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mEbeK-00DL7n-Ip; Fri, 13 Aug 2021 18:11:20 +0000 Received: from mail-ot1-f45.google.com ([209.85.210.45]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mEbeG-00DL6P-8d for linux-arm-kernel@lists.infradead.org; Fri, 13 Aug 2021 18:11:17 +0000 Received: by mail-ot1-f45.google.com with SMTP id c2-20020a0568303482b029048bcf4c6bd9so12997960otu.8 for ; Fri, 13 Aug 2021 11:11:16 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=LPzED54xeKgTV0uzpxN25ycvgJ7+FnU0XzwWfHIGp+M=; b=uHoOlz+ZnYcOdzQrwaofJ4bmSQo9ArdiF1csjP9yiVgnV0vE2lrXjzmCAC/SX8uHye myU9KBzMRHhuaaRyq5LHH6IDG+1VSKSx040AyyrgOrf6wceXl5u7Q1XCVPF7SlUTp5ls hGXdxKfuXrwepvSsedr+I/MWV8l4+iuGUqTTjZrr99jokX/PR6aY7gWNw7XSo2uubs02 1terWDmUS4MKQ0vkZTqNx16fhDrvjXgYLZfIW0PPFROQ5sQ2do4SEqAQujkkKEtBSQD9 15+itYBTiHLv5BUivzNkWn4MSY0vgkrXZBQHXX4uOzQoQWRbBc6Gk4QakrH1LRTX4v7m wPDQ== X-Gm-Message-State: AOAM5337iKPkxp4U/ml9JNrmVyiZHV4Nx98ScAgWNmlpBIuvkEURiFa3 rP20YqlM+WpiTvnkU8Na/A== X-Google-Smtp-Source: ABdhPJz8TQwhStwIV9j8ES8mQkAGtJtCOHamui/b/Nfn3PlJ7eO4OR+QBnqqGox4c2KtcK7WKRRqGA== X-Received: by 2002:a9d:5e5:: with SMTP id 92mr3056054otd.193.1628878275680; Fri, 13 Aug 2021 11:11:15 -0700 (PDT) Received: from robh.at.kernel.org (24-155-109-49.dyn.grandenetworks.net. [24.155.109.49]) by smtp.gmail.com with ESMTPSA id g13sm218710oos.39.2021.08.13.11.11.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 13 Aug 2021 11:11:15 -0700 (PDT) Received: (nullmailer pid 3786586 invoked by uid 1000); Fri, 13 Aug 2021 18:11:13 -0000 Date: Fri, 13 Aug 2021 13:11:13 -0500 From: Rob Herring To: Andreas =?iso-8859-1?Q?F=E4rber?= Cc: Chester Lin , Greg Kroah-Hartman , s32@nxp.com, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-serial@vger.kernel.org, Shawn Guo , Krzysztof Kozlowski , Oleksij Rempel , Stefan Riedmueller , Matthias Schiffer , Li Yang , Fabio Estevam , Matteo Lisi , Frieder Schrempf , Tim Harvey , Jagan Teki , catalin-dan.udma@nxp.com, bogdan.hamciuc@nxp.com, bogdan.folea@nxp.com, ciprianmarian.costea@nxp.com, radu-nicolae.pirea@nxp.com, ghennadi.procopciuc@nxp.com, Matthias Brugger , "Ivan T . Ivanov" , "Lee, Chun-Yi" Subject: Re: [PATCH 3/8] dt-bindings: serial: fsl-linflexuart: Add compatible for S32G2 Message-ID: References: <20210805065429.27485-1-clin@suse.com> <20210805065429.27485-4-clin@suse.com> <96c02ee6-cd3a-59df-0b3b-1632bb355019@suse.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <96c02ee6-cd3a-59df-0b3b-1632bb355019@suse.de> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210813_111116_349497_F0EDDB01 X-CRM114-Status: GOOD ( 28.45 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Aug 12, 2021 at 06:27:57PM +0200, Andreas F=E4rber wrote: > On 05.08.21 08:54, Chester Lin wrote: > > Add a compatible string for the uart binding of NXP S32G2 platforms. He= re > > we use "s32v234-linflexuart" as fallback since the current linflexuart > > driver still works on S32G2. > > = > > Signed-off-by: Chester Lin > > --- > > .../bindings/serial/fsl,s32-linflexuart.yaml | 26 ++++++++++++++++--- > > 1 file changed, 22 insertions(+), 4 deletions(-) > > = > > diff --git a/Documentation/devicetree/bindings/serial/fsl,s32-linflexua= rt.yaml b/Documentation/devicetree/bindings/serial/fsl,s32-linflexuart.yaml > > index acfe34706ccb..e731f3f6cea4 100644 > > --- a/Documentation/devicetree/bindings/serial/fsl,s32-linflexuart.yaml > > +++ b/Documentation/devicetree/bindings/serial/fsl,s32-linflexuart.yaml > > @@ -21,10 +21,20 @@ allOf: > > = > > properties: > > compatible: > > - description: The LINFlexD controller on S32V234 SoC, which can be > > - configured in UART mode. > > - items: > > - - const: fsl,s32v234-linflexuart > > + minItems: 1 > > + maxItems: 2 > = > Are these necessary for oneOf? > = > > + oneOf: > > + - description: The LINFlexD controller on S32G2 SoC, which can be > > + configured in UART mode. > > + items: > > + - enum: > > + - fsl,s32g2-linflexuart > > + - const: fsl,s32v234-linflexuart > = > This reads inconsistent to me: Either this oneOf is for S32G2 only, then > please turn the enum into a const. Or change the description to "on SoCs > compatible with S32V234" if we expect the enum list to grow. > = > I believe the idea here was to avoid unnecessary driver compatible and > earlycon compatible additions, while preparing for eventual quirks > specific to S32G2. > = > @NXP: Should this be s32g2- like above or s32g274a- specifically? Do you > agree this is a useful thing to prepare here, as opposed to using only > s32v234- in the s32g2* DT? > = > I assume the ordering is done alphabetically as S32G < S32V; > alternatively we might order S32V234 first and then the compatible ones. > = > > + > > + - description: The LINFlexD controller on S32V234 SoC, which can= be > > + configured in UART mode. > > + items: > > + - const: fsl,s32v234-linflexuart > = > To minimize this S32G2 patch, would it be valid to do oneOf for the > single S32V in the preceding patch already? Then we would avoid the text > movement and re-indentation above and more easily see the lines newly > getting added for S32G2. > = > > = > > reg: > > maxItems: 1 > > @@ -41,8 +51,16 @@ unevaluatedProperties: false > > = > > examples: > > - | > > + /* S32V234 */ > = > Could this be: > - description: S32V234 > | > ? No, that would not be valid json-schema. Rob _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel