From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=BAYES_00,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9E4DEC4320E for ; Fri, 13 Aug 2021 20:24:02 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6E92E60EE4 for ; Fri, 13 Aug 2021 20:24:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234276AbhHMUY2 (ORCPT ); Fri, 13 Aug 2021 16:24:28 -0400 Received: from mail-ot1-f54.google.com ([209.85.210.54]:35375 "EHLO mail-ot1-f54.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233875AbhHMUYZ (ORCPT ); Fri, 13 Aug 2021 16:24:25 -0400 Received: by mail-ot1-f54.google.com with SMTP id r19-20020a0568301353b029050aa53c3801so13469852otq.2; Fri, 13 Aug 2021 13:23:58 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=G5GJqobectD9I3QiKt1pYv/rhZ007RjyGQ0PhxTSAes=; b=UblapYUZ4fDNPE6XELWDmfBowqmUcA9yyK4G+ZAn08fkQK52zYO9wqZYjPcNRquFzx 9fP0dqOLH794dijsW6kJySxnPh12tOD9fnlhJ9EHRufVhi5RWXFn70WYR3zwLK8RCMTT bffsOM3MipOhSGa8Z/MtPfYPdMZpS6lRvDuoYOUb50nZL2cPJ7EEgECDHWAwa7fUyuu6 gLOJsnj7fXFLDe2Y/BnqcyNCPruPpQBdRE5jBHKhPAUuKzsjEwNoRRjkvwHcRfwJT1bm GAR1NRredg+AiPDsOZTSCVcmpFtQChHi+aF1YH43M0kAPV6oAtoSukSK4n2ReoTCl91V /auw== X-Gm-Message-State: AOAM530fELK3uXMOMz27oAobZjv8nsbiCo5Wxd2Y/wD3HhdeIGerZTyp dgYhnkxEWCdVqueF4Q5HAw== X-Google-Smtp-Source: ABdhPJxHmdkVN3w0pkbBAvep1kmZBeHOY5DJblDrmCZZrwhtBv5GIJPUw3iaHTaXyu/42R+C/ffNbg== X-Received: by 2002:a9d:66d1:: with SMTP id t17mr3510683otm.152.1628886237846; Fri, 13 Aug 2021 13:23:57 -0700 (PDT) Received: from robh.at.kernel.org (2603-8080-2a06-ed00-7254-0b80-dd3c-00c6.res6.spectrum.com. [2603:8080:2a06:ed00:7254:b80:dd3c:c6]) by smtp.gmail.com with ESMTPSA id 17sm551246oiy.50.2021.08.13.13.23.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 13 Aug 2021 13:23:57 -0700 (PDT) Received: (nullmailer pid 3963897 invoked by uid 1000); Fri, 13 Aug 2021 20:23:56 -0000 Date: Fri, 13 Aug 2021 15:23:56 -0500 From: Rob Herring To: Claudiu Beznea Cc: ulf.hansson@linaro.org, nicolas.ferre@microchip.com, alexandre.belloni@bootlin.com, ludovic.desroches@microchip.com, linux-mmc@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 0/4] mmc: pwrseq: sd8787: add support for selectable Message-ID: References: <20210806113001.821660-1-claudiu.beznea@microchip.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210806113001.821660-1-claudiu.beznea@microchip.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Aug 06, 2021 at 02:29:57PM +0300, Claudiu Beznea wrote: > Hi, > > This series adds support for selecting the delay b/w reset and power > lines on pwrseq-sd8787. With this the driver could also be used by > other devices (e.g. WILC1000/WILC3000 which needs a delay of 5ms). Along > with this added the DT bindings for WILC3000 device present on > SAMA5D27 WLSOM1 board. A 300ms delay doesn't work? Is powering on the device so timing critical? Add a new compatible for your device and imply the timing from that. That way we're not extending the binding a property at a time in a poorly designed way for each new timing quirk. Rob From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 20C17C4338F for ; Fri, 13 Aug 2021 20:26:15 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D4A5960560 for ; Fri, 13 Aug 2021 20:26:14 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org D4A5960560 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=yjUrZafphu1XKTG6lwj7bIeIjXRChT+xZK9FEcAuJnU=; b=HJiImKq0hRICSy rePw3USTXoucKpyZ6DrGsPNUTb9qYiuU5ZD1zmwuXERsUeKeRm86tfKMlEHYEpqmOl2ijwPt1rC/S +Z8iOirS8Jhhhl32tjh27gIXMLvaNl/JIkhOMARa3B/50chhyn6HpXst35raZd/ISpFOD59Wz1VWB s/9Ziovk+X+s/68cl5+ICjdEmnqKnfj35Y4sRKY2h4bWxcq/pK/vFtfHa+2MfLrztcjyj7cmFcIj3 bceiBGD/oVk4rwNmnGx4rFZbEQ04S5jbEalolBTHs3LO7uJdLnCzHOgPO2EBcSXiQibV3hBfaLvpt ZSo95n2Kl+f9b4L1D36Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mEdim-00DYLu-Qu; Fri, 13 Aug 2021 20:24:04 +0000 Received: from mail-ot1-f46.google.com ([209.85.210.46]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mEdih-00DYL7-3R for linux-arm-kernel@lists.infradead.org; Fri, 13 Aug 2021 20:24:02 +0000 Received: by mail-ot1-f46.google.com with SMTP id n1-20020a9d1e810000b0290514da4485e4so10683460otn.4 for ; Fri, 13 Aug 2021 13:23:58 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=G5GJqobectD9I3QiKt1pYv/rhZ007RjyGQ0PhxTSAes=; b=KJoTcAXhKJdaoONmbdhIlejUDLVkl/nDcOJuxBBvviMNOeJfDkkm+khKQcOnP9YIW9 NdPaXOjc2r8HqGrs0UOckeDjSUqVuFQDVS9LIZvnN9X4XZQJ0INA2UZM01VwZINW4h4C 9ji4O8I1P0E76jKmdQr2VJph4SqoAFlwCp0W8RgKk3nj7CbeCwDDgS+bPnpxOsLF+y/q Q9JR7mxjr+AYpXLYlawKmkCzoCKmQgrf6xJk8dDN+5METejbGKmuXekg5L/Bx1ZjLO14 eblV5TiDBu8mRV1YnssBmdh0j5eJJPKlYTfKEBCOo4h5f5+X/9djlz4Ox67f+mfI0vCQ pj8A== X-Gm-Message-State: AOAM532sGxRoM8BEGehrG3WluKfyXv0TyDRZUV95T6V6gs9KeGldgwv4 9+lqI9DGXcNbsSj+G85FIQ== X-Google-Smtp-Source: ABdhPJxHmdkVN3w0pkbBAvep1kmZBeHOY5DJblDrmCZZrwhtBv5GIJPUw3iaHTaXyu/42R+C/ffNbg== X-Received: by 2002:a9d:66d1:: with SMTP id t17mr3510683otm.152.1628886237846; Fri, 13 Aug 2021 13:23:57 -0700 (PDT) Received: from robh.at.kernel.org (2603-8080-2a06-ed00-7254-0b80-dd3c-00c6.res6.spectrum.com. [2603:8080:2a06:ed00:7254:b80:dd3c:c6]) by smtp.gmail.com with ESMTPSA id 17sm551246oiy.50.2021.08.13.13.23.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 13 Aug 2021 13:23:57 -0700 (PDT) Received: (nullmailer pid 3963897 invoked by uid 1000); Fri, 13 Aug 2021 20:23:56 -0000 Date: Fri, 13 Aug 2021 15:23:56 -0500 From: Rob Herring To: Claudiu Beznea Subject: Re: [PATCH 0/4] mmc: pwrseq: sd8787: add support for selectable Message-ID: References: <20210806113001.821660-1-claudiu.beznea@microchip.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210806113001.821660-1-claudiu.beznea@microchip.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210813_132359_188525_2E05E0DC X-CRM114-Status: GOOD ( 14.61 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, ulf.hansson@linaro.org, alexandre.belloni@bootlin.com, linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org, ludovic.desroches@microchip.com, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Aug 06, 2021 at 02:29:57PM +0300, Claudiu Beznea wrote: > Hi, > > This series adds support for selecting the delay b/w reset and power > lines on pwrseq-sd8787. With this the driver could also be used by > other devices (e.g. WILC1000/WILC3000 which needs a delay of 5ms). Along > with this added the DT bindings for WILC3000 device present on > SAMA5D27 WLSOM1 board. A 300ms delay doesn't work? Is powering on the device so timing critical? Add a new compatible for your device and imply the timing from that. That way we're not extending the binding a property at a time in a poorly designed way for each new timing quirk. Rob _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel