From: "Alexandre Belloni" <alexandre.belloni@bootlin.com>
To: Joe Slater <joe.slater@windriver.com>
Cc: openembedded-core@lists.openembedded.org, randy.macleod@windriver.com
Subject: Re: [oe-core][PATCH 1/1] blktrace: add rdepends
Date: Sat, 14 Aug 2021 11:39:07 +0200 [thread overview]
Message-ID: <YRePO49ByXUDHv+R@piout.net> (raw)
In-Reply-To: <20210813202416.138888-1-joe.slater@windriver.com>
Hello,
On 13/08/2021 13:24:16-0700, Joe Slater wrote:
> bno_plot.py uses gnuplot. Also change shebangs to
> python3 because we do not support python2.
>
> Signed-off-by: Joe Slater <joe.slater@windriver.com>
> ---
> meta/recipes-kernel/blktrace/blktrace_git.bb | 6 +++-
> .../blktrace/files/python3-shebangs.patch | 30 +++++++++++++++++++
> 2 files changed, 35 insertions(+), 1 deletion(-)
> create mode 100644 meta/recipes-kernel/blktrace/files/python3-shebangs.patch
>
> diff --git a/meta/recipes-kernel/blktrace/blktrace_git.bb b/meta/recipes-kernel/blktrace/blktrace_git.bb
> index d00b1bd0be..36ce282481 100644
> --- a/meta/recipes-kernel/blktrace/blktrace_git.bb
> +++ b/meta/recipes-kernel/blktrace/blktrace_git.bb
> @@ -10,11 +10,15 @@ LIC_FILES_CHKSUM = "file://COPYING;md5=393a5ca445f6965873eca0259a17f833"
>
> DEPENDS = "libaio"
>
> +RDEPENDS:${PN} += "gnuplot"
> +
This breaks many builds on the autobuilders with:
stdio: ERROR: Nothing RPROVIDES 'gnuplot' (but /home/pokybuild/yocto-worker/genericx86-64/build/meta/recipes-kernel/blktrace/blktrace_git.bb RDEPENDS on or otherwise requires it)
stdio: ERROR: Nothing RPROVIDES 'blktrace-dev' (but /home/pokybuild/yocto-worker/genericx86-64/build/meta/recipes-kernel/blktrace/blktrace_git.bb RDEPENDS on or otherwise requires it)
because gnuplot is part of meta-oe
> SRCREV = "366d30b9cdb20345c5d064af850d686da79b89eb"
>
> PV = "1.3.0+git${SRCPV}"
>
> -SRC_URI = "git://git.kernel.dk/blktrace.git"
> +SRC_URI = "git://git.kernel.dk/blktrace.git \
> + file://python3-shebangs.patch \
> + "
>
> S = "${WORKDIR}/git"
>
> diff --git a/meta/recipes-kernel/blktrace/files/python3-shebangs.patch b/meta/recipes-kernel/blktrace/files/python3-shebangs.patch
> new file mode 100644
> index 0000000000..70a35c2c3a
> --- /dev/null
> +++ b/meta/recipes-kernel/blktrace/files/python3-shebangs.patch
> @@ -0,0 +1,30 @@
> +blktrace: Use python3 shebangs
> +
> +blktrace can use either python2 or python3, but we really want
> +python3, so modify the shebangs.
> +
> +Upstream-Status: pending
> +
> +Signed-off-by: Joe Slater <joe.slater@windriver.com.
> +
> +
> +diff --git a/btt/bno_plot.py b/btt/bno_plot.py
> +index 3aa4e19..d7d7159 100644
> +--- a/btt/bno_plot.py
> ++++ b/btt/bno_plot.py
> +@@ -1,4 +1,4 @@
> +-#! /usr/bin/env python
> ++#! /usr/bin/env python3
> + #
> + # btt blkno plotting interface
> + #
> +diff --git a/btt/btt_plot.py b/btt/btt_plot.py
> +index 40bc71f..8620d31 100755
> +--- a/btt/btt_plot.py
> ++++ b/btt/btt_plot.py
> +@@ -1,4 +1,4 @@
> +-#! /usr/bin/env python
> ++#! /usr/bin/env python3
> + #
> + # btt_plot.py: Generate matplotlib plots for BTT generate data files
> + #
> --
> 2.25.1
>
>
>
>
--
Alexandre Belloni, co-owner and COO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
next prev parent reply other threads:[~2021-08-14 9:39 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-13 20:24 [oe-core][PATCH 1/1] blktrace: add rdepends Joe Slater
2021-08-13 23:34 ` Randy MacLeod
2021-08-15 1:33 ` Khem Raj
2021-08-16 17:26 ` Joe Slater
2021-08-14 9:39 ` Alexandre Belloni [this message]
2021-08-16 17:29 ` Joe Slater
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YRePO49ByXUDHv+R@piout.net \
--to=alexandre.belloni@bootlin.com \
--cc=joe.slater@windriver.com \
--cc=openembedded-core@lists.openembedded.org \
--cc=randy.macleod@windriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.