From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E0A96C432BE for ; Mon, 16 Aug 2021 13:31:15 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id CD1E260E76 for ; Mon, 16 Aug 2021 13:31:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240923AbhHPNbp (ORCPT ); Mon, 16 Aug 2021 09:31:45 -0400 Received: from relay4-d.mail.gandi.net ([217.70.183.196]:33451 "EHLO relay4-d.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S241488AbhHPN3n (ORCPT ); Mon, 16 Aug 2021 09:29:43 -0400 Received: (Authenticated sender: alexandre.belloni@bootlin.com) by relay4-d.mail.gandi.net (Postfix) with ESMTPSA id F3464E0009; Mon, 16 Aug 2021 13:29:07 +0000 (UTC) Date: Mon, 16 Aug 2021 15:29:07 +0200 From: Alexandre Belloni To: Vladimir Oltean Cc: netdev@vger.kernel.org, Jakub Kicinski , "David S. Miller" , Russell King , Horatiu Vultur , Colin Foster , Florian Fainelli , Andrew Lunn , Vivien Didelot , Claudiu Manoil , UNGLinuxDriver@microchip.com Subject: Re: [PATCH v2 net-next 0/2] Convert ocelot to phylink Message-ID: References: <20210815014748.1262458-1-vladimir.oltean@nxp.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210815014748.1262458-1-vladimir.oltean@nxp.com> Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Hi, On 15/08/2021 04:47:46+0300, Vladimir Oltean wrote: > The ocelot switchdev and felix dsa drivers are interesting because they > target the same class of hardware switches but used in different modes. > > Colin has an interesting use case where he wants to use a hardware > switch supported by the ocelot switchdev driver with the felix dsa > driver. > > So far, the existing hardware revisions were similar between the ocelot > and felix drivers, but not completely identical. With identical hardware, > it is absurd that the felix driver uses phylink while the ocelot driver > uses phylib - this should not be one of the differences between the > switchdev and dsa driver, and we could eliminate it. > > Colin will need the common phylink support in ocelot and felix when > adding a phylink_pcs driver for the PCS1G block inside VSC7514, which > will make the felix driver work with either the NXP or the Microchip PCS. > > As usual, Alex, Horatiu, sorry for bugging you, but it would be > appreciated if you could give this a quick run on actual VSC7514 > hardware (which I don't have) to make sure I'm not introducing any > breakage. > No worries, if there is any breakage, we'll fix it up. -- Alexandre Belloni, co-owner and COO, Bootlin Embedded Linux and Kernel engineering https://bootlin.com