From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B1CFEC4338F for ; Tue, 17 Aug 2021 02:35:38 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8F4B260C3F for ; Tue, 17 Aug 2021 02:35:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233748AbhHQCgK (ORCPT ); Mon, 16 Aug 2021 22:36:10 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34536 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233634AbhHQCgJ (ORCPT ); Mon, 16 Aug 2021 22:36:09 -0400 Received: from mail-oi1-x22b.google.com (mail-oi1-x22b.google.com [IPv6:2607:f8b0:4864:20::22b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 719BEC0613C1 for ; Mon, 16 Aug 2021 19:35:37 -0700 (PDT) Received: by mail-oi1-x22b.google.com with SMTP id bd1so22332216oib.3 for ; Mon, 16 Aug 2021 19:35:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=NdyGEYcMNe8BiminkuBCItjHjvXDyAXJh8MNR3OdTVA=; b=bWqdF64VY/gZ0txHUPvtOyRYx/7413DAHTyvrWOEFLI8Z5zIC+H1GkaCheBYSMLNPP xz/TOUln9srtWWj0EQduVMM+M09U4WIyJwmXs34nLYTtJ6ZVKBKWNDQpVpWifKiVgzhA YJFlDtXY4D0gaQ/P5BE06IsNvRnwiu4D55/Ji7ZGTXmrEF4oz/zH6/CJg5SF8CtX6Rkh pqMfnbR9jNWDeBDcsr12bkxosdYXNRwZ+rAoik0IRpr6c54nL7iby0rOTBdpnAkt7eR3 kv5rcrTqrcijFf1jxR8NUjrRPKg9fssGBEt6ZHTtr079ub4luBvQurn3sp1Pz67ACsE/ 43nA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=NdyGEYcMNe8BiminkuBCItjHjvXDyAXJh8MNR3OdTVA=; b=uSAIvGtrL+qWRAvehV/LQ2c9GyD6lYCzbkRplYMsNf4X2oQ7jS0eWSVg1JJ7/zsGIZ RViMSfDtxZhkt1Fnv75uooIYdRFVwos8QPPmyLM84rknsCqpqnOndFfa8XtguTX2XqaA zST9swJWjbLA6Awb71CxwqAqPSObEy1woq5zixpmkoGdNVTtdmni6bCeYwmjN6iAcUGs xCuA2agJFsyIDaPk33/iX6IU6g5fO/huRMisvQVgAVyAjSjxLGcAunNshA+N5lvGPG9I cfAAVXH/pHiCh43VzfWKe8vaBJaae1nBzLRet6X/VqVGHzJfu056UEXNOdERPSLdsLiy Trlw== X-Gm-Message-State: AOAM53181sE56Etk6nS5gY3r024T4J/uINgvF/zM/GuBfiy8MJDHqQGD WsT7eqHzEzxq6n+PW0LS3ZhhYg== X-Google-Smtp-Source: ABdhPJymyQJLqdiw2YDOsltDdciCYnn251jtZQLVfsywLgi83bxWlqaNn4EhafXoU05oQICTq1XjrA== X-Received: by 2002:aca:1014:: with SMTP id 20mr722410oiq.70.1629167736646; Mon, 16 Aug 2021 19:35:36 -0700 (PDT) Received: from yoga (104-57-184-186.lightspeed.austtx.sbcglobal.net. [104.57.184.186]) by smtp.gmail.com with ESMTPSA id d1sm128671otb.61.2021.08.16.19.35.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 16 Aug 2021 19:35:36 -0700 (PDT) Date: Mon, 16 Aug 2021 21:35:33 -0500 From: Bjorn Andersson To: Antonio Martorana Cc: Andy Gross , Elliot Berman , Trilok Soni , linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] soc: qcom: socinfo: Fixed argument passed to platform_set_data() Message-ID: References: <1629159879-95777-1-git-send-email-amartora@codeaurora.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1629159879-95777-1-git-send-email-amartora@codeaurora.org> Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On Mon 16 Aug 19:24 CDT 2021, Antonio Martorana wrote: > Set qcom_socinfo pointer as data being stored instead of pointer > to soc_device structure. Aligns with future calls to platform_get_data() > which expects qcom_socinfo pointer. > Thanks for the patch Antonio! This should have a fixes tag, to ensure that it's appropriately backported. Fixes: efb448d0a3fc ("soc: qcom: Add socinfo driver") Reviewed-by: Bjorn Andersson Regards, Bjorn > Signed-off-by: Antonio Martorana > --- > drivers/soc/qcom/socinfo.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/soc/qcom/socinfo.c b/drivers/soc/qcom/socinfo.c > index 9faf483..52e5811 100644 > --- a/drivers/soc/qcom/socinfo.c > +++ b/drivers/soc/qcom/socinfo.c > @@ -628,7 +628,7 @@ static int qcom_socinfo_probe(struct platform_device *pdev) > /* Feed the soc specific unique data into entropy pool */ > add_device_randomness(info, item_size); > > - platform_set_drvdata(pdev, qs->soc_dev); > + platform_set_drvdata(pdev, qs); > > return 0; > } > -- > The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, > a Linux Foundation Collaborative Project >