From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, UNWANTED_LANGUAGE_BODY autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9844FC4320A for ; Tue, 17 Aug 2021 19:30:29 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 785F061008 for ; Tue, 17 Aug 2021 19:30:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233499AbhHQTbB (ORCPT ); Tue, 17 Aug 2021 15:31:01 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:47821 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229640AbhHQTbA (ORCPT ); Tue, 17 Aug 2021 15:31:00 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1629228626; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=d9FE22rxp6AYKElT4XtdoX7zLTcx3lonKYmaIy1Dz4c=; b=G37IKFDCscNp6Y05fllAdtQYuKNqcDbuBmSBrbXP0xql5swk0Lr4jpgFJR5QLwo0W+fs4a v7kIs5UwIalXNNN8Azs3LLbtRzuw/m985eikTROPHxsopkix90OnjY6nMXyMK4FvPML6aB WeEdkTQ/WaS7rGmF2+wHjH0EJ8BKT38= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-600-4vvYO79JPfeSXV7wb0FHTg-1; Tue, 17 Aug 2021 15:30:23 -0400 X-MC-Unique: 4vvYO79JPfeSXV7wb0FHTg-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id C148F1008060; Tue, 17 Aug 2021 19:30:19 +0000 (UTC) Received: from lorien.usersys.redhat.com (unknown [10.22.10.126]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 4CC301036D28; Tue, 17 Aug 2021 19:30:12 +0000 (UTC) Date: Tue, 17 Aug 2021 15:30:10 -0400 From: Phil Auld To: Sebastian Andrzej Siewior Cc: Valentin Schneider , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, rcu@vger.kernel.org, linux-rt-users@vger.kernel.org, Catalin Marinas , Will Deacon , Ingo Molnar , Peter Zijlstra , Thomas Gleixner , Steven Rostedt , Daniel Bristot de Oliveira , "Paul E. McKenney" , Frederic Weisbecker , Josh Triplett , Mathieu Desnoyers , Davidlohr Bueso , Lai Jiangshan , Joel Fernandes , Anshuman Khandual , Vincenzo Frascino , Steven Price , Ard Biesheuvel , Boqun Feng , Mike Galbraith Subject: Re: [PATCH v3 2/4] sched: Introduce migratable() Message-ID: References: <20210811201354.1976839-1-valentin.schneider@arm.com> <20210811201354.1976839-3-valentin.schneider@arm.com> <20210817170925.2jwqvgvmqab2glwu@linutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20210817170925.2jwqvgvmqab2glwu@linutronix.de> X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Aug 17, 2021 at 07:09:25PM +0200 Sebastian Andrzej Siewior wrote: > On 2021-08-11 21:13:52 [+0100], Valentin Schneider wrote: > > diff --git a/include/linux/sched.h b/include/linux/sched.h > > index debc960f41e3..8ba7b4a7ee69 100644 > > --- a/include/linux/sched.h > > +++ b/include/linux/sched.h > > @@ -1715,6 +1715,16 @@ static inline bool is_percpu_thread(void) > > #endif > > } > > > > +/* Is the current task guaranteed to stay on its current CPU? */ > > +static inline bool migratable(void) > > I'm going to rename this in my tree to `is_migratable' because of It's better anyway. See is_percpu_thread() 5 lines above :) > |security/keys/trusted-keys/trusted_core.c:45:22: error: ‘migratable’ redeclared as different kind of symbol > | 45 | static unsigned char migratable; > | | ^~~~~~~~~~ > |In file included from arch/arm64/include/asm/compat.h:16, > | from arch/arm64/include/asm/stat.h:13, > | from include/linux/stat.h:6, > | from include/linux/sysfs.h:22, > | from include/linux/kobject.h:20, > | from include/linux/of.h:17, > | from include/linux/irqdomain.h:35, > | from include/linux/acpi.h:13, > | from include/linux/tpm.h:21, > | from include/keys/trusted-type.h:12, > | from security/keys/trusted-keys/trusted_core.c:10: > |include/linux/sched.h:1719:20: note: previous definition of ‘migratable’ was here > | 1719 | static inline bool migratable(void) > | | ^~~~~~~~~~ > > Sebastian > -- From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C94E4C4338F for ; Tue, 17 Aug 2021 19:32:23 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9002A61008 for ; Tue, 17 Aug 2021 19:32:23 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 9002A61008 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=/c1+y4WycGvwrGB6hMqMY+qUl9A/t4N0BvvHC6l7g4k=; b=c3PlgJbO5U9F3F WZznG9BvaYWpxzBFivJHmbTitBtQUJJSfJ5NjBXEodOEmhdDkXPuigb/yY0ZT6Jy+06DozkadC5qr PMzXc0OPj8D/JAH0NE7adWr+4GMPmTvPJ45N/2cRNfcv0AGkSG8nMxYHlaSjQOPgvUMOtCCWOaiRM FOZYEhAQIq9AWtepss1p3GK/ibW0Ocw7KsopdIEeI7FQVAA8KN9zd49olBQSZIMI0sL8uHHyU7W2d jvNwx6uC8FkWYQeTx8rYdK8rdl6x41Qs0YgjfIthA40+Dmaai28iidBzEBl/ClayTBA3sw+UE/s6l Kca0mmk0nyDMKrIPCavw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mG4nA-003JZT-QV; Tue, 17 Aug 2021 19:30:32 +0000 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mG4n6-003JYb-PQ for linux-arm-kernel@lists.infradead.org; Tue, 17 Aug 2021 19:30:30 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1629228626; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=d9FE22rxp6AYKElT4XtdoX7zLTcx3lonKYmaIy1Dz4c=; b=G37IKFDCscNp6Y05fllAdtQYuKNqcDbuBmSBrbXP0xql5swk0Lr4jpgFJR5QLwo0W+fs4a v7kIs5UwIalXNNN8Azs3LLbtRzuw/m985eikTROPHxsopkix90OnjY6nMXyMK4FvPML6aB WeEdkTQ/WaS7rGmF2+wHjH0EJ8BKT38= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-600-4vvYO79JPfeSXV7wb0FHTg-1; Tue, 17 Aug 2021 15:30:23 -0400 X-MC-Unique: 4vvYO79JPfeSXV7wb0FHTg-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id C148F1008060; Tue, 17 Aug 2021 19:30:19 +0000 (UTC) Received: from lorien.usersys.redhat.com (unknown [10.22.10.126]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 4CC301036D28; Tue, 17 Aug 2021 19:30:12 +0000 (UTC) Date: Tue, 17 Aug 2021 15:30:10 -0400 From: Phil Auld To: Sebastian Andrzej Siewior Cc: Valentin Schneider , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, rcu@vger.kernel.org, linux-rt-users@vger.kernel.org, Catalin Marinas , Will Deacon , Ingo Molnar , Peter Zijlstra , Thomas Gleixner , Steven Rostedt , Daniel Bristot de Oliveira , "Paul E. McKenney" , Frederic Weisbecker , Josh Triplett , Mathieu Desnoyers , Davidlohr Bueso , Lai Jiangshan , Joel Fernandes , Anshuman Khandual , Vincenzo Frascino , Steven Price , Ard Biesheuvel , Boqun Feng , Mike Galbraith Subject: Re: [PATCH v3 2/4] sched: Introduce migratable() Message-ID: References: <20210811201354.1976839-1-valentin.schneider@arm.com> <20210811201354.1976839-3-valentin.schneider@arm.com> <20210817170925.2jwqvgvmqab2glwu@linutronix.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210817170925.2jwqvgvmqab2glwu@linutronix.de> X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210817_123029_251124_3A35A16B X-CRM114-Status: GOOD ( 16.89 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gVHVlLCBBdWcgMTcsIDIwMjEgYXQgMDc6MDk6MjVQTSArMDIwMCBTZWJhc3RpYW4gQW5kcnpl aiBTaWV3aW9yIHdyb3RlOgo+IE9uIDIwMjEtMDgtMTEgMjE6MTM6NTIgWyswMTAwXSwgVmFsZW50 aW4gU2NobmVpZGVyIHdyb3RlOgo+ID4gZGlmZiAtLWdpdCBhL2luY2x1ZGUvbGludXgvc2NoZWQu aCBiL2luY2x1ZGUvbGludXgvc2NoZWQuaAo+ID4gaW5kZXggZGViYzk2MGY0MWUzLi44YmE3YjRh N2VlNjkgMTAwNjQ0Cj4gPiAtLS0gYS9pbmNsdWRlL2xpbnV4L3NjaGVkLmgKPiA+ICsrKyBiL2lu Y2x1ZGUvbGludXgvc2NoZWQuaAo+ID4gQEAgLTE3MTUsNiArMTcxNSwxNiBAQCBzdGF0aWMgaW5s aW5lIGJvb2wgaXNfcGVyY3B1X3RocmVhZCh2b2lkKQo+ID4gICNlbmRpZgo+ID4gIH0KPiA+ICAK PiA+ICsvKiBJcyB0aGUgY3VycmVudCB0YXNrIGd1YXJhbnRlZWQgdG8gc3RheSBvbiBpdHMgY3Vy cmVudCBDUFU/ICovCj4gPiArc3RhdGljIGlubGluZSBib29sIG1pZ3JhdGFibGUodm9pZCkKPiAK PiBJJ20gZ29pbmcgdG8gcmVuYW1lIHRoaXMgaW4gbXkgdHJlZSB0byBgaXNfbWlncmF0YWJsZScg YmVjYXVzZSBvZgoKSXQncyBiZXR0ZXIgYW55d2F5LiBTZWUgaXNfcGVyY3B1X3RocmVhZCgpIDUg bGluZXMgYWJvdmUgOikKCgo+IHxzZWN1cml0eS9rZXlzL3RydXN0ZWQta2V5cy90cnVzdGVkX2Nv cmUuYzo0NToyMjogZXJyb3I6IOKAmG1pZ3JhdGFibGXigJkgcmVkZWNsYXJlZCBhcyBkaWZmZXJl bnQga2luZCBvZiBzeW1ib2wKPiB8ICAgNDUgfCBzdGF0aWMgdW5zaWduZWQgY2hhciBtaWdyYXRh YmxlOwo+IHwgICAgICB8ICAgICAgICAgICAgICAgICAgICAgIF5+fn5+fn5+fn4KPiB8SW4gZmls ZSBpbmNsdWRlZCBmcm9tIGFyY2gvYXJtNjQvaW5jbHVkZS9hc20vY29tcGF0Lmg6MTYsCj4gfCAg ICAgICAgICAgICAgICAgZnJvbSBhcmNoL2FybTY0L2luY2x1ZGUvYXNtL3N0YXQuaDoxMywKPiB8 ICAgICAgICAgICAgICAgICBmcm9tIGluY2x1ZGUvbGludXgvc3RhdC5oOjYsCj4gfCAgICAgICAg ICAgICAgICAgZnJvbSBpbmNsdWRlL2xpbnV4L3N5c2ZzLmg6MjIsCj4gfCAgICAgICAgICAgICAg ICAgZnJvbSBpbmNsdWRlL2xpbnV4L2tvYmplY3QuaDoyMCwKPiB8ICAgICAgICAgICAgICAgICBm cm9tIGluY2x1ZGUvbGludXgvb2YuaDoxNywKPiB8ICAgICAgICAgICAgICAgICBmcm9tIGluY2x1 ZGUvbGludXgvaXJxZG9tYWluLmg6MzUsCj4gfCAgICAgICAgICAgICAgICAgZnJvbSBpbmNsdWRl L2xpbnV4L2FjcGkuaDoxMywKPiB8ICAgICAgICAgICAgICAgICBmcm9tIGluY2x1ZGUvbGludXgv dHBtLmg6MjEsCj4gfCAgICAgICAgICAgICAgICAgZnJvbSBpbmNsdWRlL2tleXMvdHJ1c3RlZC10 eXBlLmg6MTIsCj4gfCAgICAgICAgICAgICAgICAgZnJvbSBzZWN1cml0eS9rZXlzL3RydXN0ZWQt a2V5cy90cnVzdGVkX2NvcmUuYzoxMDoKPiB8aW5jbHVkZS9saW51eC9zY2hlZC5oOjE3MTk6MjA6 IG5vdGU6IHByZXZpb3VzIGRlZmluaXRpb24gb2Yg4oCYbWlncmF0YWJsZeKAmSB3YXMgaGVyZQo+ IHwgMTcxOSB8IHN0YXRpYyBpbmxpbmUgYm9vbCBtaWdyYXRhYmxlKHZvaWQpCj4gfCAgICAgIHwg ICAgICAgICAgICAgICAgICAgIF5+fn5+fn5+fn4KPiAKPiBTZWJhc3RpYW4KPiAKCi0tIAoKCl9f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmxpbnV4LWFybS1r ZXJuZWwgbWFpbGluZyBsaXN0CmxpbnV4LWFybS1rZXJuZWxAbGlzdHMuaW5mcmFkZWFkLm9yZwpo dHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4LWFybS1rZXJu ZWwK