All of lore.kernel.org
 help / color / mirror / Atom feed
From: Wolfram Sang <wsa@kernel.org>
To: Sergey Shtylyov <s.shtylyov@omp.ru>
Cc: linux-i2c@vger.kernel.org
Subject: Re: [PATCH v2 3/5] i2c: pmcmsp: fix IRQ check
Date: Tue, 17 Aug 2021 22:08:15 +0200	[thread overview]
Message-ID: <YRwXL3TGBMUdgyBX@kunai> (raw)
In-Reply-To: <fd0dd13c-2fe7-c954-ff0f-917067c8252c@omp.ru>

[-- Attachment #1: Type: text/plain, Size: 600 bytes --]

On Sun, Jul 04, 2021 at 05:41:50PM +0300, Sergey Shtylyov wrote:
> The driver's probe() method is written as if platform_get_irq() returns 0
> on error, while actually it returns a negative error code (with all the
> other values considered valid IRQs).  Rewrite the driver's IRQ checking
> code to pass the positive IRQ #s to request_irq() and use polling mode
> when platform_get_irq() returns negative error code (or IRQ0)...
> 
> Fixes: 1b144df1d7d6 ("i2c: New PMC MSP71xx TWI bus driver")
> Signed-off-by: Sergey Shtylyov <s.shtylyov@omp.ru>

The driver has been removed meanwhile.


[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

  reply	other threads:[~2021-08-17 20:08 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-04 14:32 [PATCH v2 0/5] Correctly handle plaform_get_irq()'s result in the i2C drivers Sergey Shtylyov
2021-07-04 14:32 ` Sergey Shtylyov
2021-07-04 14:32 ` Sergey Shtylyov
2021-07-04 14:35 ` [PATCH v2 1/5] i2c: hix5hd2: fix IRQ check Sergey Shtylyov
2021-08-17 20:10   ` Wolfram Sang
2021-07-04 14:38 ` [PATCH v2 2/5] i2c: mt65xx: " Sergey Shtylyov
2021-07-04 14:38   ` Sergey Shtylyov
2021-07-04 14:38   ` Sergey Shtylyov
2021-08-17 20:09   ` Wolfram Sang
2021-08-17 20:09     ` Wolfram Sang
2021-08-17 20:09     ` Wolfram Sang
2021-08-20  1:46     ` Qii Wang
2021-08-20  1:46       ` Qii Wang
2021-08-20  1:46       ` Qii Wang
2021-08-25 21:00   ` Wolfram Sang
2021-08-25 21:00     ` Wolfram Sang
2021-08-25 21:00     ` Wolfram Sang
2021-07-04 14:41 ` [PATCH v2 3/5] i2c: pmcmsp: " Sergey Shtylyov
2021-08-17 20:08   ` Wolfram Sang [this message]
2021-07-04 14:45 ` [PATCH v2 4/5] i2c: s3c2410: " Sergey Shtylyov
2021-07-04 14:45   ` Sergey Shtylyov
2021-07-05  7:46   ` Krzysztof Kozlowski
2021-07-05  7:46     ` Krzysztof Kozlowski
2021-08-17 20:08   ` Wolfram Sang
2021-08-17 20:08     ` Wolfram Sang
2021-07-04 14:47 ` [PATCH v2 5/5] i2c: xlp9xx: fix main " Sergey Shtylyov
2021-08-17 20:13   ` Wolfram Sang
2021-08-25 21:05   ` Wolfram Sang
2021-08-11 20:12 ` [PATCH v2 0/5] Correctly handle plaform_get_irq()'s result in the i2C drivers Sergey Shtylyov
2021-08-11 20:12   ` Sergey Shtylyov
2021-08-11 20:12   ` Sergey Shtylyov
2021-08-11 20:14   ` Sergey Shtylyov
2021-08-11 20:14     ` Sergey Shtylyov
2021-08-11 20:14     ` Sergey Shtylyov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YRwXL3TGBMUdgyBX@kunai \
    --to=wsa@kernel.org \
    --cc=linux-i2c@vger.kernel.org \
    --cc=s.shtylyov@omp.ru \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.